From patchwork Thu Nov 9 17:10:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksandr Tyshchenko X-Patchwork-Id: 10051383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EA9E060381 for ; Thu, 9 Nov 2017 17:13:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1C452B038 for ; Thu, 9 Nov 2017 17:13:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C66D42B051; Thu, 9 Nov 2017 17:13:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 463F22B04F for ; Thu, 9 Nov 2017 17:13:33 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCqM2-0004hK-Gc; Thu, 09 Nov 2017 17:11:02 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCqM0-0004bZ-HL for xen-devel@lists.xenproject.org; Thu, 09 Nov 2017 17:11:00 +0000 Received: from [85.158.139.211] by server-1.bemta-5.messagelabs.com id F0/0E-02029-32C840A5; Thu, 09 Nov 2017 17:10:59 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRWlGSWpSXmKPExsVyMfS6k65yD0u UwatVIhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bReztZC26pViycfputgfGRfBcjF4eQwAxG ieuPLrGAOCwCL1kkps2/zAziSAj0s0psfTGXrYuRE8jJkuhuuc0OYadJnFn3gwXCrpKYNnULI 4gtJKAk8XrnZiaIsbOZJPo+nQVrYBMwkNj/7gmYLQJUdG/VZLAiZoE9jBLr715lAkkIC/hIbF vxDWwSi4CqxOQVS4HiHBy8Ai4ST+ZCLZaTuHmukxnE5gQKv/l4nQ1isbPExdfH2SYwCi5gZFj FqFGcWlSWWqRrZKyXVJSZnlGSm5iZo2toYKqXm1pcnJiempOYVKyXnJ+7iREYdPUMDIw7GHe0 +x1ilORgUhLllbJkiRLiS8pPqcxILM6ILyrNSS0+xCjDwaEkwevdDZQTLEpNT61Iy8wBhj9MW oKDR0mE910XUJq3uCAxtzgzHSJ1itGe48KdS3+YOA7suQUkn8183cDMMe1qaxOzEEtefl6qlD ivFchUAZC2jNI8uKGweL3EKCslzMvIwMAgxFOQWpSbWYIq/4pRnINRSZg3C2QKT2ZeCdzuV0B nMQGdFc0OdlZJIkJKqoFR+McCqfBH00zl/tU95Z28dd4vhRuy2eyxBX0ruey+ywrvEzaJFpL7 dWLz/3cvPn3w8j5q8fjB1kW3pqu3xp6wSBBitb5sqJjlFLLxotbNW868v7eKef1bGpK+dNmSk HuSR25qHudOVOw8uq1FZMLyLD35eQdWlYskX1iQcf61vuDvNYGvb81zU2Ipzkg01GIuKk4EAK cT7JzSAgAA X-Env-Sender: olekstysh@gmail.com X-Msg-Ref: server-8.tower-206.messagelabs.com!1510247458!106397044!1 X-Originating-IP: [209.85.215.66] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.45; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39775 invoked from network); 9 Nov 2017 17:10:59 -0000 Received: from mail-lf0-f66.google.com (HELO mail-lf0-f66.google.com) (209.85.215.66) by server-8.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 9 Nov 2017 17:10:59 -0000 Received: by mail-lf0-f66.google.com with SMTP id r129so8038666lff.8 for ; Thu, 09 Nov 2017 09:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/e07b8k6AdMKOJ+ekf7szKijHTKss6Ey/d3bRb3Mm4c=; b=D7GIk03KXMQ8awB3pwbm5HKIhhJehQOu2WVsCRsQT0t/5E9Hi8MqtjrND603fcAHJd b3B5yCWjMmBzOMnq3PsSKuVGH7Pviz5hxJ9hEv+uFhrPbCItWDRzgdgxWjzosvzU9q3F IOtYKAYANWF/Xx0hdWmI5a9bnQr7DZCistU1B5kMHqfIY8g4JgNtB1D8jTHv2oAwGQ7w 76UeqhoGfk06XXQJxcvrs0P3ky8RCSMLl6FyeRbVjkVKW2mRZI7JRuhUJHkoudx1JZt0 YkSl3eSUT1cPUUPlduRdSfp8Jtdmjr7/jF2fT3PA8kvaoE7gFGHLXU0Jg6F7YWkDsUmY gS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/e07b8k6AdMKOJ+ekf7szKijHTKss6Ey/d3bRb3Mm4c=; b=NkufKHZRWPDjTUjsmdOIpnZA9xAQ6oM6eDU7DQRGuW/07F42QKzt/Wgaob///sRzyq Jpxy9njdSDOl99gRNm1nfNn+Pd9Bkdw8Hdz/DK01UnMmpnPSeBTB49lOwp43H3pmm+7D UkY1xZgAZhDV+W+X8PabfNNVhY2kpgl9QZi/U5pu5Kg0yoJTdRtIKeGxOFqU5EqwANcU KMYcbx1NGTQNY0gFG05uOoLdvtgDjRs86buHDUNZPvcEMMyRiHGRxyNlfHsq69Wnpy+3 Km0mko1OPfASTK4jW5yPnW7q1mBMfX8Mx0+1nr1Uk5jDudv7nUPy6LqJpvmKk2nSwIjq 6FfA== X-Gm-Message-State: AJaThX6EFU+F8U3YkwOEJctkO9gUf6mDMWLObt1MUa2OY3L2PtR335O9 J2cT5MopVCxTZf5uc15NWNGwBA== X-Google-Smtp-Source: ABhQp+RgwkfeKwWSHDESdsKBrCh8qpNldPUTd4ArpFmCGgyo2Zued4GK/gu5v45FCC1awRwePJ2o3Q== X-Received: by 10.25.153.206 with SMTP id b197mr442996lfe.109.1510247458488; Thu, 09 Nov 2017 09:10:58 -0800 (PST) Received: from otyshchenko.kyiv.epam.com (ll-53.209.223.85.sovam.net.ua. [85.223.209.53]) by smtp.gmail.com with ESMTPSA id x90sm1394299ljb.86.2017.11.09.09.10.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 09 Nov 2017 09:10:57 -0800 (PST) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Date: Thu, 9 Nov 2017 19:10:14 +0200 Message-Id: <1510247421-24094-25-git-send-email-olekstysh@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510247421-24094-1-git-send-email-olekstysh@gmail.com> References: <1510247421-24094-1-git-send-email-olekstysh@gmail.com> Cc: Oleksandr Tyshchenko , Stefano Stabellini , Andre Przywara , Julien Grall Subject: [Xen-devel] [RFC PATCH 24/31] xen/arm: Add Xen changes to ARM SMC based mailbox X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Oleksandr Tyshchenko Modify the direct ported ARM SMC based mailbox to be functional inside Xen. Include "wrappers.h" which contains all required things the direct ported code relies on. Signed-off-by: Oleksandr Tyshchenko CC: Stefano Stabellini CC: Julien Grall CC: Andre Przywara --- xen/arch/arm/cpufreq/arm-smc-mailbox.c | 101 +++++++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/xen/arch/arm/cpufreq/arm-smc-mailbox.c b/xen/arch/arm/cpufreq/arm-smc-mailbox.c index d7b61a7..65d183e 100644 --- a/xen/arch/arm/cpufreq/arm-smc-mailbox.c +++ b/xen/arch/arm/cpufreq/arm-smc-mailbox.c @@ -8,14 +8,73 @@ * This device provides a mechanism for emulating a mailbox by using * smc calls, allowing a "mailbox" consumer to sit in firmware running * on the same core. + * + * Based on patch series which hasn't reach upstream yet: + * => https://lkml.org/lkml/2017/7/23/129 + * [PATCH v2 0/3] mailbox: arm: introduce smc triggered mailbox + * + * Xen modification: + * Oleksandr Tyshchenko + * Copyright (C) 2017 EPAM Systems Inc. */ +#if 0 #include #include #include #include #include #include +#endif + +#include +#include +#include + +#include "mailbox_controller.h" +#include "wrappers.h" + +/* + * TODO: + * 1. Add releasing resources since devm. + */ + +struct arm_smccc_res { + unsigned long a0; + unsigned long a1; + unsigned long a2; + unsigned long a3; +}; + +/* This is just to align interfaces. */ +static inline void arm_smccc_smc(unsigned long a0, unsigned long a1, + unsigned long a2, unsigned long a3, unsigned long a4, + unsigned long a5, unsigned long a6, unsigned long a7, + struct arm_smccc_res *res) +{ + register_t ret[4] = { 0 }; + + call_smccc_smc(a0, a1, a2, a3, a4, a5, a6, a7, ret); + + res->a0 = ret[0]; + res->a1 = ret[1]; + res->a2 = ret[2]; + res->a3 = ret[3]; +} + +static inline void arm_smccc_hvc(unsigned long a0, unsigned long a1, + unsigned long a2, unsigned long a3, unsigned long a4, + unsigned long a5, unsigned long a6, unsigned long a7, + struct arm_smccc_res *res) +{ + /* + * We should never get here since the "use_hvc" flag is always false + * (smc is only allowed method). + */ + BUG(); +} + +/***** Start of Linux code *****/ #define ARM_SMC_MBOX_USE_HVC BIT(0) @@ -69,6 +128,9 @@ static int arm_smc_mbox_probe(struct platform_device *pdev) if (!of_property_read_string(dev->of_node, "method", &method)) { if (!strcmp("hvc", method)) { use_hvc = true; + + dev_warn(dev,"method must be smc\n"); + return -EINVAL; } else if (!strcmp("smc", method)) { use_hvc = false; } else { @@ -112,6 +174,11 @@ static int arm_smc_mbox_probe(struct platform_device *pdev) mbox->txdone_poll = true; mbox->txdone_irq = false; mbox->txpoll_period = 1; + /* + * We don't have RX-done irq, but always have received data in hand since + * mailbox is synchronous. + */ + mbox->rxdone_auto = true; mbox->ops = &arm_smc_mbox_chan_ops; mbox->dev = dev; @@ -126,6 +193,7 @@ static int arm_smc_mbox_probe(struct platform_device *pdev) return ret; } +#if 0 static int arm_smc_mbox_remove(struct platform_device *pdev) { struct mbox_controller *mbox = platform_get_drvdata(pdev); @@ -133,6 +201,7 @@ static int arm_smc_mbox_remove(struct platform_device *pdev) mbox_controller_unregister(mbox); return 0; } +#endif static const struct of_device_id arm_smc_mbox_of_match[] = { { .compatible = "arm,smc-mbox", }, @@ -140,6 +209,7 @@ static const struct of_device_id arm_smc_mbox_of_match[] = { }; MODULE_DEVICE_TABLE(of, arm_smc_mbox_of_match); +#if 0 static struct platform_driver arm_smc_mbox_driver = { .driver = { .name = "arm-smc-mbox", @@ -153,3 +223,34 @@ module_platform_driver(arm_smc_mbox_driver); MODULE_AUTHOR("Andre Przywara "); MODULE_DESCRIPTION("Generic ARM smc mailbox driver"); MODULE_LICENSE("GPL v2"); +#endif + +/***** End of Linux code *****/ + +static int __init arm_smc_mbox_init(struct dt_device_node *dev, + const void *data) +{ + int ret; + + ret = arm_smc_mbox_probe(dev); + if (ret) { + dev_err(&dev->dev, "failed to init ARM SMC mailbox (%d)\n", ret); + return ret; + } + + return 0; +} + +DT_DEVICE_START(arm_smc_mbox, "ARM SMC mailbox", DEVICE_MAILBOX) + .dt_match = arm_smc_mbox_of_match, + .init = arm_smc_mbox_init, +DT_DEVICE_END + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 8 + * indent-tabs-mode: t + * End: + */