Message ID | 1510763827-5539-1-git-send-email-boris.ostrovsky@oracle.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On 15/11/17 17:37, Boris Ostrovsky wrote: > Since commit ba1029c9cbc5 ("modpost: detect modules without a > MODULE_LICENSE") modules without said macro will generate > > WARNING: modpost: missing MODULE_LICENSE() in <filename> > > While at it, also add module description and attribution. > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Reviewed-by: Juergen Gross <jgross@suse.com> Juergen
On Wed, 15 Nov 2017, Boris Ostrovsky wrote: > Since commit ba1029c9cbc5 ("modpost: detect modules without a > MODULE_LICENSE") modules without said macro will generate > > WARNING: modpost: missing MODULE_LICENSE() in <filename> > > While at it, also add module description and attribution. > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Ack. Thank you! > --- > drivers/xen/pvcalls-back.c | 4 ++++ > drivers/xen/pvcalls-front.c | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > index b209cd4..02cd33c 100644 > --- a/drivers/xen/pvcalls-back.c > +++ b/drivers/xen/pvcalls-back.c > @@ -1238,3 +1238,7 @@ static void __exit pvcalls_back_fin(void) > } > > module_exit(pvcalls_back_fin); > + > +MODULE_DESCRIPTION("Xen PV Calls backend driver"); > +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>"); > +MODULE_LICENSE("GPL"); > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index 2925b2f..9e40c2c 100644 > --- a/drivers/xen/pvcalls-front.c > +++ b/drivers/xen/pvcalls-front.c > @@ -1273,3 +1273,7 @@ static int __init pvcalls_frontend_init(void) > } > > module_init(pvcalls_frontend_init); > + > +MODULE_DESCRIPTION("Xen PV Calls frontend driver"); > +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>"); > +MODULE_LICENSE("GPL"); > -- > 2.7.5 >
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c index b209cd4..02cd33c 100644 --- a/drivers/xen/pvcalls-back.c +++ b/drivers/xen/pvcalls-back.c @@ -1238,3 +1238,7 @@ static void __exit pvcalls_back_fin(void) } module_exit(pvcalls_back_fin); + +MODULE_DESCRIPTION("Xen PV Calls backend driver"); +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>"); +MODULE_LICENSE("GPL"); diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 2925b2f..9e40c2c 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -1273,3 +1273,7 @@ static int __init pvcalls_frontend_init(void) } module_init(pvcalls_frontend_init); + +MODULE_DESCRIPTION("Xen PV Calls frontend driver"); +MODULE_AUTHOR("Stefano Stabellini <sstabellini@kernel.org>"); +MODULE_LICENSE("GPL");
Since commit ba1029c9cbc5 ("modpost: detect modules without a MODULE_LICENSE") modules without said macro will generate WARNING: modpost: missing MODULE_LICENSE() in <filename> While at it, also add module description and attribution. Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> --- drivers/xen/pvcalls-back.c | 4 ++++ drivers/xen/pvcalls-front.c | 4 ++++ 2 files changed, 8 insertions(+)