| Message ID | 1559195244-7692-1-git-send-email-chenbaodong@mxnavi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xen: 'keyhandler' is not used in null scheduler | expand |
> On May 30, 2019, at 6:47 AM, Baodong Chen <chenbaodong@mxnavi.com> wrote: > > So remove 'keyhandler.h' include. > Also add 'static' prefix for 'schud_bull_def' > > Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com> Thanks for the patch — these changes look good. I think the title would be better something like: xen/sched_null: Superficial clean-ups Then just list both in bullet points; something like: * Remove unused dependency ‘keyhandler.’h * Make sched_null_def static Would you mind re-sending the patch? You can add: Reviewed-by: George Dunlap <george.dunlap@citrix.com> Thanks, -George
Hello George, On 5/30/19 17:05, George Dunlap wrote: >> On May 30, 2019, at 6:47 AM, Baodong Chen <chenbaodong@mxnavi.com> wrote: >> >> So remove 'keyhandler.h' include. >> Also add 'static' prefix for 'schud_bull_def' >> >> Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com> > Thanks for the patch — these changes look good. I think the title would be better something like: > > xen/sched_null: Superficial clean-ups > > Then just list both in bullet points; something like: > > * Remove unused dependency ‘keyhandler.’h > * Make sched_null_def static > > Would you mind re-sending the patch? You can add: > > Reviewed-by: George Dunlap <george.dunlap@citrix.com> Thanks for your review, resent. > Thanks, > -George >
diff --git a/xen/common/sched_null.c b/xen/common/sched_null.c index a59dbb2..c9700f1 100644 --- a/xen/common/sched_null.c +++ b/xen/common/sched_null.c @@ -31,7 +31,6 @@ #include <xen/sched.h> #include <xen/sched-if.h> #include <xen/softirq.h> -#include <xen/keyhandler.h> #include <xen/trace.h> /* @@ -871,7 +870,7 @@ static void null_dump(const struct scheduler *ops) spin_unlock_irqrestore(&prv->lock, flags); } -const struct scheduler sched_null_def = { +static const struct scheduler sched_null_def = { .name = "null Scheduler", .opt_name = "null", .sched_id = XEN_SCHEDULER_NULL,
So remove 'keyhandler.h' include. Also add 'static' prefix for 'schud_bull_def' Signed-off-by: Baodong Chen <chenbaodong@mxnavi.com> --- xen/common/sched_null.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)