From patchwork Wed Nov 6 09:19:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrii Anisov X-Patchwork-Id: 11229735 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 75CA716B1 for ; Wed, 6 Nov 2019 09:21:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 518342173E for ; Wed, 6 Nov 2019 09:21:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c5p9lkfk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 518342173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSHTZ-0006tk-Qp; Wed, 06 Nov 2019 09:19:41 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iSHTX-0006tH-Tu for xen-devel@lists.xenproject.org; Wed, 06 Nov 2019 09:19:39 +0000 X-Inumbo-ID: 86901026-0076-11ea-984a-bc764e2007e4 Received: from mail-lj1-x242.google.com (unknown [2a00:1450:4864:20::242]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 86901026-0076-11ea-984a-bc764e2007e4; Wed, 06 Nov 2019 09:19:25 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id g3so19076591ljl.11 for ; Wed, 06 Nov 2019 01:19:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=coiWn1foYoNL5/AHwQss8xRczmLkid+ReOf0kjJjIa4=; b=c5p9lkfkPe1akEiHY6SyoTNGB06FZdfk2JT3oZmB0h/1/HgrOtKYPPp7+/Z7S2kDXs DwWw0Li/JdvHxVzqL/gzj+HG1qZ1Qvfytnh8/Ma0yOmZr+/TjWRtP8u/BBeRXKO05sCy LKI38lXWDn2tSotce8QCXD0pZAxr4YDOiMhudt+TK/NpVMqAsbfnVyY4KyTdFYtTzJjx yFFnx5LZPB4GtN/KrrfJ/Kzo0P+5S0GpkZ0//1qWBPJVK/Nlh2XhUM4jPaSbTSM7TPsq 26Y0x0zztQSsAdhon+mMKYM5MWpwIuV4T6SULhEO3qa/iuUx7Pc89ThL983fpdxV9D4+ hJOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=coiWn1foYoNL5/AHwQss8xRczmLkid+ReOf0kjJjIa4=; b=gam/llvvIp4trmRDtMeQ/D/C1GkRJHSOZfDf+elRnoaErCGnhH/OuKbihbxV55yxP8 3+G7Wt08qcT3LpK90aKTLszrUyEsXzds6kp7xEtrbzF2jE1uhmZCV/jm2hTkGdqrVj0V f2YPGVLLragbwFZPg20aj1IRP/IGBhScsmKNcc42S3WivRH7jwB7BXes/45RWlKXppcs KeaaY1zyBMwLLwpGvSpoV6/S7lfOiLDjYlHlbl8c3+/7K8HO1EDfk4XvF3+qMnneLx3D 6oMVGWYnb2MFpgEH5uI3tDtKSR954QJQ21bZAlq60xpPwwT2xpiAQdl6zzUUZHXv9s0V ngUg== X-Gm-Message-State: APjAAAU36OeB7QDMrw6AxS/TMfeM6FGagnMmvWlWriZHrwSNdPPSZqP0 vDIe0fIv2bZJVU44Gv4/CWLjVD2FpbM= X-Google-Smtp-Source: APXvYqygdjzLjOvj1bpIRCpLaoDOXVgFUJvWRiA3Gkn04WMGh7ovdTcNuDOEBxyaYwy494eRkolrHg== X-Received: by 2002:a2e:b163:: with SMTP id a3mr1073177ljm.72.1573031964209; Wed, 06 Nov 2019 01:19:24 -0800 (PST) Received: from aanisov-work.kyiv.epam.com (ll-74.141.223.85.sovam.net.ua. [85.223.141.74]) by smtp.gmail.com with ESMTPSA id g23sm3945937lja.104.2019.11.06.01.19.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Nov 2019 01:19:22 -0800 (PST) From: Andrii Anisov To: xen-devel@lists.xenproject.org Date: Wed, 6 Nov 2019 11:19:10 +0200 Message-Id: <1573031953-12894-5-git-send-email-andrii.anisov@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1573031953-12894-1-git-send-email-andrii.anisov@gmail.com> References: <1573031953-12894-1-git-send-email-andrii.anisov@gmail.com> Subject: [Xen-devel] [RFC 4/7] arm/gic: Drop pointless assertions X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Andrii Anisov , Volodymyr Babchuk MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" From: Andrii Anisov Also armclang complains about the condition always true, because `sgi` is of type enum with all its values under 16. Signed-off-by: Andrii Anisov --- xen/arch/arm/gic.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index 113655a..58c6141 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -294,8 +294,6 @@ void __init gic_init(void) void send_SGI_mask(const cpumask_t *cpumask, enum gic_sgi sgi) { - ASSERT(sgi < 16); /* There are only 16 SGIs */ - gic_hw_ops->send_SGI(sgi, SGI_TARGET_LIST, cpumask); } @@ -306,15 +304,11 @@ void send_SGI_one(unsigned int cpu, enum gic_sgi sgi) void send_SGI_self(enum gic_sgi sgi) { - ASSERT(sgi < 16); /* There are only 16 SGIs */ - gic_hw_ops->send_SGI(sgi, SGI_TARGET_SELF, NULL); } void send_SGI_allbutself(enum gic_sgi sgi) { - ASSERT(sgi < 16); /* There are only 16 SGIs */ - gic_hw_ops->send_SGI(sgi, SGI_TARGET_OTHERS, NULL); }