From patchwork Thu Mar 12 13:44:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 11434309 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6E495913 for ; Thu, 12 Mar 2020 13:45:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A782067C for ; Thu, 12 Mar 2020 13:45:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51A782067C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCO8I-0002Sz-7H; Thu, 12 Mar 2020 13:44:18 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCO8H-0002Sr-6L for xen-devel@lists.xenproject.org; Thu, 12 Mar 2020 13:44:17 +0000 X-Inumbo-ID: 90c17b84-6467-11ea-bec1-bc764e2007e4 Received: from mail-wm1-f65.google.com (unknown [209.85.128.65]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 90c17b84-6467-11ea-bec1-bc764e2007e4; Thu, 12 Mar 2020 13:44:16 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id e26so6353329wme.5 for ; Thu, 12 Mar 2020 06:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=98rImuk8IgJ1Sk8C9NZCFORwdYVoL50Apj68nHt8iOs=; b=gbfGvL90gexOJw1vxigawF0PoGDzt7oJ3RWt9TovQVgJ/JXAhjg6aaYD7GftauD6ow ON+jC4as1D9kx+I+IKuZqW/TZUEoLw6ppBeWYjyzthGbElcbKzYmlbkxhe2qP9fsYJM0 QTGQiZcycy+6htYNHds4PR2rwNxz7zcOpNvw+xsGUaCGvgPOHA2ZRz4tM2pvsIkgMrSQ qtpvOYA4TA5qCHLp16svU07dW+L4rxenGpLwFekfyfrUqYLPrOLyLyh2kteG880PFdF0 1U7ajVFzONMHWngdLc96EDj4Zq9eZeQq6vjpOFN6ltFqJmf9I0ZItWMHGR5MsD59aGLK E2MQ== X-Gm-Message-State: ANhLgQ35FkB3CUimMoVSyHsmCeI0l8D/TKM3gxIrMyt9ly21CgXJatwi tRf5dT9WuPTeICNhCik8X4AWjJ3NQl4= X-Google-Smtp-Source: ADFU+vuw0C1Ft5UK6/Rw6nUF9pEZrM6dQcfnjCcOOEZJOV2XMB+TEKCabEoti3XVGNLtP12LdlMx6g== X-Received: by 2002:a1c:b686:: with SMTP id g128mr166104wmf.75.1584020655642; Thu, 12 Mar 2020 06:44:15 -0700 (PDT) Received: from [192.168.0.36] (87.78.186.89.cust.ip.kpnqwest.it. [89.186.78.87]) by smtp.gmail.com with ESMTPSA id 7sm1086475wmf.20.2020.03.12.06.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 06:44:15 -0700 (PDT) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Thu, 12 Mar 2020 14:44:14 +0100 Message-ID: <158402065414.753.15785539969715690913.stgit@Palanthas> In-Reply-To: <158402056376.753.7091379488590272336.stgit@Palanthas> References: <158402056376.753.7091379488590272336.stgit@Palanthas> User-Agent: StGit/0.21 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 1/2] xen: credit2: avoid vCPUs to ever reach lower credits than idle X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Charles Arnold , Tomas Mozes , Glen , George Dunlap , Jan Beulich , Sarah Newman Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There have been report of stalls of guest vCPUs, when Credit2 was used. It seemed like these vCPUs were not getting scheduled for very long time, even under light load conditions (e.g., during dom0 boot). Investigations led to the discovery that --although rarely-- it can happen that a vCPU manages to run for very long timeslices. In Credit2, this means that, when runtime accounting happens, the vCPU will lose a large quantity of credits. This in turn may lead to the vCPU having less credits than the idle vCPUs (-2^30). At this point, the scheduler will pick the idle vCPU, instead of the ready to run vCPU, for a few "epochs", which often times is enough for the guest kernel to think the vCPU is not responding and crashing. An example of this situation is shown here. In fact, we can see d0v1 sitting in the runqueue while all the CPUs are idle, as it has -1254238270 credits, which is smaller than -2^30 = −1073741824: (XEN) Runqueue 0: (XEN) ncpus = 28 (XEN) cpus = 0-27 (XEN) max_weight = 256 (XEN) pick_bias = 22 (XEN) instload = 1 (XEN) aveload = 293391 (~111%) (XEN) idlers: 00,00000000,00000000,00000000,00000000,00000000,0fffffff (XEN) tickled: 00,00000000,00000000,00000000,00000000,00000000,00000000 (XEN) fully idle cores: 00,00000000,00000000,00000000,00000000,00000000,0fffffff [...] (XEN) Runqueue 0: (XEN) CPU[00] runq=0, sibling=00,..., core=00,... (XEN) CPU[01] runq=0, sibling=00,..., core=00,... [...] (XEN) CPU[26] runq=0, sibling=00,..., core=00,... (XEN) CPU[27] runq=0, sibling=00,..., core=00,... (XEN) RUNQ: (XEN) 0: [0.1] flags=0 cpu=5 credit=-1254238270 [w=256] load=262144 (~100%) We certainly don't want, under any circumstance, this to happen. Therefore, let's use INT_MIN for the credits of the idle vCPU, in Credit2, to be sure that no vCPU can get below that value. NOTE: investigations have been done about _how_ it is possible for a vCPU to execute for so long that its credits becomes so low. While still not completely clear, there are evidence that: - it only happens very rarely - it appears to be both machine and workload specific - it does not look to be a Credit2 (e.g., as it happens when running with Credit1 as well) issue, or a scheduler issue This patch makes Credit2 more robust to events like this, whatever the cause is, and should hence be backported (as far as possible). Signed-off-by: Dario Faggioli Reported-by: Glen Reported-by: Tomas Mozes Acked-by: George Dunlap --- Cc: George Dunlap Cc: Juergen Gross Cc: Jan Beulich Cc: Charles Arnold Cc: Sarah Newman --- I will provide the backports myself, at least for 4.13 and 4.12.x (and feel free to ask for more). --- For Sarah, looking back at the various threads, I am not quite sure whether you also experienced the issue and reported it. If yes, I'm happy to add a "Reported-by:" line about you too (or, if this is fine to go in, for this to be done while committing, if possible). --- xen/common/sched/credit2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched/credit2.c b/xen/common/sched/credit2.c index c7241944a8..5c0ab9cd05 100644 --- a/xen/common/sched/credit2.c +++ b/xen/common/sched/credit2.c @@ -234,7 +234,7 @@ * units does not consume credits, and it must be lower than whatever * amount of credit 'regular' unit would end up with. */ -#define CSCHED2_IDLE_CREDIT (-(1U<<30)) +#define CSCHED2_IDLE_CREDIT INT_MIN /* * Carryover: How much "extra" credit may be carried over after * a reset.