| Message ID | 162135616513.20014.6303562342690753615.stgit@Wayrath (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | automation: fix building in the openSUSE Tumbleweed | expand |
On Tue, May 18, 2021 at 06:42:45PM +0200, Dario Faggioli wrote: > Fix the build inside our openSUSE Tumbleweed container by using > adding libzstd headers. While there, remove the explicit dependency > for python and python3 as the respective -devel packages will pull > them in anyway. > > Signed-off-by: Dario Faggioli <dfaggioli@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> Can you try to push an updated container to the registry? Thanks!
On Wed, 2021-05-19 at 08:28 +0200, Roger Pau Monné wrote: > On Tue, May 18, 2021 at 06:42:45PM +0200, Dario Faggioli wrote: > > Fix the build inside our openSUSE Tumbleweed container by using > > adding libzstd headers. While there, remove the explicit dependency > > for python and python3 as the respective -devel packages will pull > > them in anyway. > > > > Signed-off-by: Dario Faggioli <dfaggioli@suse.com> > > Acked-by: Roger Pau Monné <roger.pau@citrix.com> > Thanks! > Can you try to push an updated container to the registry? > Yeah, I tried, but I'm getting this: STEP 8: COMMIT registry.gitlab.com/xen-project/xen/suse:opensuse-tumbleweed --> 940c6edbff9 940c6edbff965135a25bc20f0e2a59cf6062b9e8bc3516858828cbb7bba92d8f Getting image source signatures Copying blob acc28ee93e9b [--------------------------------------] 8.0b / 3.5KiB Copying blob 89c6eef91991 [--------------------------------------] 8.0b / 57.0MiB Copying blob 20dabc80d591 [--------------------------------------] 8.0b / 90.6MiB Copying blob 5ea007576ed8 [--------------------------------------] 8.0b / 2.0GiB Error: error copying image to the remote destination: Error writing blob: Error initiating layer upload to /v2/xen-project/xen/suse/blobs/uploads/ in registry.gitlab.com: errors: denied: requested access to the resource is denied unauthorized: authentication required make: *** [Makefile:15: suse/opensuse-tumbleweed] Error 125 So, either I'm doing something wrong, or I was just misremembering and I don't have the permission to do that... Can we check if I do? Regards
On 19/05/2021 18:52, Dario Faggioli wrote: > On Wed, 2021-05-19 at 08:28 +0200, Roger Pau Monné wrote: >> On Tue, May 18, 2021 at 06:42:45PM +0200, Dario Faggioli wrote: >>> Fix the build inside our openSUSE Tumbleweed container by using >>> adding libzstd headers. While there, remove the explicit dependency >>> for python and python3 as the respective -devel packages will pull >>> them in anyway. >>> >>> Signed-off-by: Dario Faggioli <dfaggioli@suse.com> >> Acked-by: Roger Pau Monné <roger.pau@citrix.com> >> > Thanks! > >> Can you try to push an updated container to the registry? >> > Yeah, I tried, but I'm getting this: > > STEP 8: COMMIT registry.gitlab.com/xen-project/xen/suse:opensuse-tumbleweed > --> 940c6edbff9 > 940c6edbff965135a25bc20f0e2a59cf6062b9e8bc3516858828cbb7bba92d8f > Getting image source signatures > Copying blob acc28ee93e9b [--------------------------------------] 8.0b / 3.5KiB > Copying blob 89c6eef91991 [--------------------------------------] 8.0b / 57.0MiB > Copying blob 20dabc80d591 [--------------------------------------] 8.0b / 90.6MiB > Copying blob 5ea007576ed8 [--------------------------------------] 8.0b / 2.0GiB > Error: error copying image to the remote destination: Error writing blob: Error initiating layer upload to /v2/xen-project/xen/suse/blobs/uploads/ in registry.gitlab.com: errors: > denied: requested access to the resource is denied > unauthorized: authentication required > > make: *** [Makefile:15: suse/opensuse-tumbleweed] Error 125 > > So, either I'm doing something wrong, or I was just misremembering and > I don't have the permission to do that... Can we check if I do? Hmm. I built the container locally, which reused some of the layers you pushed, and it all pushed successfully for me. I've committed this series so xen.git matches reality. Lets see how the updated container fairs... ~Andrew
On Wed, 2021-05-19 at 20:25 +0100, Andrew Cooper wrote: > > I built the container locally, which reused some of the layers you > pushed, and it all pushed successfully for me. > > I've committed this series so xen.git matches reality. Lets see how > the > updated container fairs... > Well, something still looks off, although I don't know what. In fact, we still see: https://gitlab.com/xen-project/xen/-/jobs/1277448985 checking for deflateCopy in -lz... no 2608configure: error: Could not find zlib 2609configure: error: ./configure failed for tools Which means we're missing libz. In fact, if I pull the container that's currently in the registry, I can see that: dario@b17aaa86cacf:~> rpm -qa|grep zlib zlib-devel-1.2.11-18.3.x86_64 However, if I build it locally, with: dario@Solace:~/src/xen/xen.git/automation/build> make suse/opensuse-tumbleweed And then enter and use it for building, the package is there and configure works. dario@51e463d1d47e:~> rpm -qa|grep libz libzstd1-1.4.9-1.2.x86_64 libz1-1.2.11-18.3.x86_64 libzck1-1.1.11-1.1.x86_64 libzypp-17.25.10-1.1.x86_64 libzio1-1.06-4.26.x86_64 libzzip-0-13-0.13.72-1.2.x86_64 libzstd-devel-1.4.9-1.2.x86_64 dario@51e463d1d47e:~> ./configure checking build system type... x86_64-pc-linux-gnu checking host system type... x86_64-pc-linux-gnu ... ... ... checking for pandoc... /usr/bin/pandoc checking for perl... /usr/bin/perl configure: creating ./config.status So, what am I missing or doing wrong? Thanks and Regards
diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-tumbleweed.dockerfile index 8ff7b9b5ce..a33ab0d870 100644 --- a/automation/build/suse/opensuse-tumbleweed.dockerfile +++ b/automation/build/suse/opensuse-tumbleweed.dockerfile @@ -45,6 +45,7 @@ RUN zypper install -y --no-recommends \ libtasn1-devel \ libuuid-devel \ libyajl-devel \ + libzstd-devel \ lzo-devel \ make \ nasm \ @@ -56,9 +57,7 @@ RUN zypper install -y --no-recommends \ pandoc \ patch \ pkg-config \ - python \ python-devel \ - python3 \ python3-devel \ systemd-devel \ tar \
Fix the build inside our openSUSE Tumbleweed container by using adding libzstd headers. While there, remove the explicit dependency for python and python3 as the respective -devel packages will pull them in anyway. Signed-off-by: Dario Faggioli <dfaggioli@suse.com> --- Cc: Doug Goldstein <cardoe@cardoe.com> Cc: Roger Pau Monne <roger.pau@citrix.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> --- Changes from v1: - fix my email address in From: - don't request python38-devel explicitly, python3-devel is just fine and is more generic (and hence better!) --- .../build/suse/opensuse-tumbleweed.dockerfile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)