| Message ID | 1630562763-390068-6-git-send-email-fnu.vikram@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Support for dynamic Programming | expand |
Hi Vikram On 02/09/2021 07:05, Vikram Garhwal wrote: > Remove static function type from overlay_get_target(). Please explain why this is necessary. But if we really need then... > > Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com> > --- > xen/common/libfdt/fdt_overlay.c | 2 +- > xen/include/xen/libfdt/libfdt.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c > index 15a8cdb..1ffb669 100644 > --- a/xen/common/libfdt/fdt_overlay.c > +++ b/xen/common/libfdt/fdt_overlay.c > @@ -56,7 +56,7 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) > * the targeted node offset in the base device tree > * Negative error code on error > */ > -static int overlay_get_target(const void *fdt, const void *fdto, > +int overlay_get_target(const void *fdt, const void *fdto, > int fragment, char const **pathp) ... the function should be prefixed to fdt_*. I would also like to avoid diverging from what the original source. So can this please be sent to the libfdt community first? > { > uint32_t phandle; > diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h > index b6c8b67..e1cc6f2 100644 > --- a/xen/include/xen/libfdt/libfdt.h > +++ b/xen/include/xen/libfdt/libfdt.h > @@ -1737,4 +1737,6 @@ int fdt_overlay_apply(void *fdt, void *fdto); > > const char *fdt_strerror(int errval); > > +int overlay_get_target(const void *fdt, const void *fdto, int fragment, > + char const **pathp); > #endif /* _LIBFDT_H */ > Cheers,
diff --git a/xen/common/libfdt/fdt_overlay.c b/xen/common/libfdt/fdt_overlay.c index 15a8cdb..1ffb669 100644 --- a/xen/common/libfdt/fdt_overlay.c +++ b/xen/common/libfdt/fdt_overlay.c @@ -56,7 +56,7 @@ static uint32_t overlay_get_target_phandle(const void *fdto, int fragment) * the targeted node offset in the base device tree * Negative error code on error */ -static int overlay_get_target(const void *fdt, const void *fdto, +int overlay_get_target(const void *fdt, const void *fdto, int fragment, char const **pathp) { uint32_t phandle; diff --git a/xen/include/xen/libfdt/libfdt.h b/xen/include/xen/libfdt/libfdt.h index b6c8b67..e1cc6f2 100644 --- a/xen/include/xen/libfdt/libfdt.h +++ b/xen/include/xen/libfdt/libfdt.h @@ -1737,4 +1737,6 @@ int fdt_overlay_apply(void *fdt, void *fdto); const char *fdt_strerror(int errval); +int overlay_get_target(const void *fdt, const void *fdto, int fragment, + char const **pathp); #endif /* _LIBFDT_H */
Remove static function type from overlay_get_target(). Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com> --- xen/common/libfdt/fdt_overlay.c | 2 +- xen/include/xen/libfdt/libfdt.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)