diff mbox series

[XEN,RFC,v2,02/12] xen: arm: Add CONFIG_OVERLAY_DTB

Message ID 1636441347-133850-3-git-send-email-fnu.vikram@xilinx.com (mailing list archive)
State New, archived
Headers show
Series dynamic node programming using overlay dtbo | expand

Commit Message

Vikram Garhwal Nov. 9, 2021, 7:02 a.m. UTC
Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
---
 xen/arch/arm/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Julien Grall Dec. 22, 2021, 2:02 p.m. UTC | #1
Hi,

Please add a short commit message explaning how this is going to be used.

On 09/11/2021 08:02, Vikram Garhwal wrote:
> Signed-off-by: Vikram Garhwal <fnu.vikram@xilinx.com>
> ---
>   xen/arch/arm/Kconfig | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index ecfa682..895f0ee 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -46,6 +46,14 @@ config HAS_ITS
>           bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
>           depends on GICV3 && !NEW_VGIC
>   
> +config OVERLAY_DTB
> +    depends on MPSOC_PLATFORM

None of the code looks to be Xilinx specific and this will prevent one 
to build a generic Xen and test your code. So can you remove the dependency?

> +    bool "Enable DTB overlay"
> +    default y

In general, for new feature, we want to disable them by default and gate 
them with UNSUPPORTED.

They can move off UNSUPPORTED once they are ready enough to be supported 
(and possibly security supported).

Cheers,
diff mbox series

Patch

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ecfa682..895f0ee 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -46,6 +46,14 @@  config HAS_ITS
         bool "GICv3 ITS MSI controller support (UNSUPPORTED)" if UNSUPPORTED
         depends on GICV3 && !NEW_VGIC
 
+config OVERLAY_DTB
+    depends on MPSOC_PLATFORM
+    bool "Enable DTB overlay"
+    default y
+    ---help---
+
+    Allows dynamic addition/removal of Xen device tree nodes using a dtbo.
+
 config HVM
         def_bool y