From patchwork Thu Aug 11 12:39:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 9275223 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4631A600CB for ; Thu, 11 Aug 2016 12:42:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 368AB2862B for ; Thu, 11 Aug 2016 12:42:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B4202862E; Thu, 11 Aug 2016 12:42:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A399F2862B for ; Thu, 11 Aug 2016 12:42:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXpHO-0000hc-Ej; Thu, 11 Aug 2016 12:40:10 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXpHM-0000hU-Ch for xen-devel@lists.xenproject.org; Thu, 11 Aug 2016 12:40:08 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id 8D/12-30284-7227CA75; Thu, 11 Aug 2016 12:40:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRWlGSWpSXmKPExsVy5bEgr6560Zp wgxOHOCy+b5nM5MDocfjDFZYAxijWzLyk/IoE1owvJy4wFhzmr7i1Mb6B8Q9PFyMXh5DAGkaJ xV07mLsYOTnYBJQlXh+dwgpiiwioS7S032UEKWIWWMcs0dt3hg0kISxgLHFtWh87iM0ioCpxt v0bWAOvgKbE1D+HwGpEBTwkJvU+AavhFHCSOLe6A2gQB9A2R4kpD/0hygUlTs58wgJiMwvIS3 RcbmSFsHUkFuz+xAayV0LgM6NE97sJUM4ZNonlz66yTGDkn4VkwCwkA2YhGbCAkXkVo3pxalF ZapGumV5SUWZ6RkluYmaOrqGBqV5uanFxYnpqTmJSsV5yfu4mRmAYMgDBDsapDc6HGCU5mJRE eYVjVocL8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuCVKVwTLiRYlJqeWpGWmQOMCJi0BAePkghEm re4IDG3ODMdInWKUVFKnFcBJCEAksgozYNrg0XhJUZZKWFeRqBDhHgKUotyM0tQ5V8xinMwKg nzvioAmsKTmVcCN/0V0GImoMUnzMAWlyQipKQaGAtvLpj4//RprXk7WfWZNELrHfJ21NiKvH3 DYacYExRuHcWSUcjBG5Bjt/79g5eci5+3/E/M0V8u+tGP9eBCjmP6OyKyPZ1y921hnVd+8Xpy 3cW1K132OMz/HGH32Y7hMnPR+tx0vsCtPqszVY5t2u15y2mf2dOZHKVrly/drXDk27ZZF5KUt iixFGckGmoxFxUnAgAwRrAbvQIAAA== X-Env-Sender: arnd@arndb.de X-Msg-Ref: server-2.tower-206.messagelabs.com!1470919206!38034961!1 X-Originating-IP: [212.227.17.13] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 55313 invoked from network); 11 Aug 2016 12:40:07 -0000 Received: from mout.kundenserver.de (HELO mout.kundenserver.de) (212.227.17.13) by server-2.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 11 Aug 2016 12:40:07 -0000 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue101) with ESMTPSA (Nemesis) id 0Lmcct-1azaed0FU3-00aCyO; Thu, 11 Aug 2016 14:39:56 +0200 From: Arnd Bergmann To: Nicholas Piggin Date: Thu, 11 Aug 2016 14:39:50 +0200 Message-ID: <16541778.WMH6K24aDt@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1470910580-18458-1-git-send-email-npiggin@gmail.com> References: <1470910580-18458-1-git-send-email-npiggin@gmail.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:JE2C84xG/TLBBWJd4cJ/fzz8ilwgzXhl92v2PxvhvgmB0hv1esy NWGNvzvHSOPoOYlRLTf4zBoTHIlUe3qSojN50zMyY5vxpHJKayWUlyxilcI2m2qA7koWF+s F1LySe2CN3PY1geWQhaX/WNZwAYQDxCg6bjyTqnpg2PkXvewh+2Wg2oUNvelvUptT+nfXMo +JE0einFTAU4xgPolVZew== X-UI-Out-Filterresults: notjunk:1; V01:K0:7hDygVVaoNQ=:j5D6/eWwL3ERYfDcV415kt eAeSOOshjPA+gtr/08nU0WJC8PthSkuwjBv64EwBX4pWXSCf6wDxr8tZvPggPP0I7qPhBm7V9 Xv/ew8odJRZAp7KtrgWaYnO4/0isnON/DRORF5ZBzDYBTrk0QERKXEFBeEMJXLePU2uCveqlC K62cEEUrnPkkVdIt9mHy65k+uTjFVc3YwglTB7q+BQeZNDSwMOjNRqXGFC+As32QGkHlkkY/T MAVi4KaYfvDtEMXTvlPLHeeP92fn5zjxkn7tqSfm9QemXz1YD4qy39IzQCyJjXQe9ZcN5duW2 NgOHzjCBic9v/HpGz1s7yksBv2k2FG60ha6ToabbizMU7PG0XLLJ2tdF3qUKxSyPz97kQr6NB OEfAYGq2VwjLApmgzvsqFa+8qW42f8D1QXyfq9DLPVuxy8zQe2aRKKSSvQQmMHpDoeCOBm+pU IPbB36Aa6MJnrXHIFCVLYpeifCPeIfRqGB3lTga5DizXm+/JGf4VA5BL+bjHiQuJ8+BxBoyqQ jqQONssf8tTXRRgjS7IFw7uUpbanpbYfDZ76RwliYNdh/eA5soQClOCZgSqYJYjTDNJedbrv1 dpqsg/bLGNDFpI/hNFHLOGzmb8bQ2s3sG24uaGID3ZLZjoMF73xJ5hQ0S4/+Kj0HGuVBJCVGw cFQhpu00vh5yVIKoj16vgnzkeMIusTNu/3MGTY0/wU5bZz0V7XSBxsZcBEymWyRXT3NBzJ5Q1 W8k+X0WKhEnq3Tt8 Cc: linux-arch@vger.kernel.org, Stephen Rothwell , Juergen Gross , Segher Boessenkool , Nicolas Pitre , linux-kbuild@vger.kernel.org, Alan Modra , Michal Marek , David Vrabel , xen-devel@lists.xenproject.org, Boris Ostrovsky , Sam Ravnborg Subject: [Xen-devel] [PATCH] Xen: remove -fshort-wchar gcc flag X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP A previous patch added the --no-wchar-size-warning to the Makefile to avoid this harmless warning: arm-linux-gnueabi-ld: warning: drivers/xen/efi.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail Changing kbuild to use thin archives instead of recursive linking unfortunately brings the same warning back during the final link. This time, we remove the -fshort-wchar flag that originally caused the warning, hopefully fixing the problem for good. I don't see any reason for having the flag in the first place, as the Xen code does not use wchar_t at all. Signed-off-by: Arnd Bergmann Fixes: 971a69db7dc0 ("Xen: don't warn about 2-byte wchar_t in efi") Acked-by: David Vrabel --- On Thursday, August 11, 2016 8:16:14 PM CEST Nicholas Piggin wrote: > Hi, > > I would like to submit the kbuild changes in patches 1-3 for > consideration. > > I've taken on the feedback, so thanks everybody for that. The > biggest change since last time is a more general way for > architectures to do a post-link pass in patch 3. > > On the question of whether to enable thin archives unconditionally, > I prefer to have architectures enable them as they are tested. But > I would like to see everybody moved as soon as possible and the > incremental linking removed. It would be nice to get this patch merged along with the thin archive conversion, either by merging it through the xen Tree, or by making it part of Nick's series with an Ack from the xen maintainers. diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 8feab810aed9..7f188b8d0c67 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -7,9 +7,6 @@ obj-y += xenbus/ nostackp := $(call cc-option, -fno-stack-protector) CFLAGS_features.o := $(nostackp) -CFLAGS_efi.o += -fshort-wchar -LDFLAGS += $(call ld-option, --no-wchar-size-warning) - dom0-$(CONFIG_ARM64) += arm-device.o dom0-$(CONFIG_PCI) += pci.o dom0-$(CONFIG_USB_SUPPORT) += dbgp.o