diff mbox series

[2/2] build: silence future GNU ld warning about executable stacks

Message ID 1905d86c-6363-c6b0-97b3-beb91aca9055@suse.com (mailing list archive)
State New, archived
Headers show
Series build: deal with future GNU ld warnings | expand

Commit Message

Jan Beulich May 6, 2022, 1:38 p.m. UTC 
While for C files the compiler is supposed to arrange for emitting
respective information, for assembly sources we're responsible ourselves.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Julien Grall May 6, 2022, 1:44 p.m. UTC | #1 
Hi,

You say future, has this option been merged or still in discussion on 
the ML?

On 06/05/2022 14:38, Jan Beulich wrote:
> While for C files the compiler is supposed to arrange for emitting
> respective information, for assembly sources we're responsible ourselves.

Is this a preventive measure, or you have seen it in action?

Cheers,
Jan Beulich May 6, 2022, 1:46 p.m. UTC | #2 
On 06.05.2022 15:44, Julien Grall wrote:
> You say future, has this option been merged or still in discussion on 
> the ML?
> 
> On 06/05/2022 14:38, Jan Beulich wrote:
>> While for C files the compiler is supposed to arrange for emitting
>> respective information, for assembly sources we're responsible ourselves.
> 
> Is this a preventive measure, or you have seen it in action?

Same answers as for patch 1.

Jan
diff mbox series

Patch

--- a/xen/Makefile
+++ b/xen/Makefile
@@ -397,6 +397,8 @@  endif
 
 AFLAGS += -D__ASSEMBLY__
 
+$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+
 LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments
 
 CFLAGS += $(CFLAGS-y)