From patchwork Mon Dec 18 10:17:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13496515 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4845FC46CCD for ; Mon, 18 Dec 2023 10:17:55 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.655803.1023602 (Exim 4.92) (envelope-from ) id 1rFAgx-0005O0-8T; Mon, 18 Dec 2023 10:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 655803.1023602; Mon, 18 Dec 2023 10:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFAgx-0005NF-3f; Mon, 18 Dec 2023 10:17:43 +0000 Received: by outflank-mailman (input) for mailman id 655803; Mon, 18 Dec 2023 10:17:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1rFAgv-00055V-V8 for xen-devel@lists.xenproject.org; Mon, 18 Dec 2023 10:17:41 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad1d3069-9d8e-11ee-98eb-6d05b1d4d9a1; Mon, 18 Dec 2023 11:17:41 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 103064EE0C81; Mon, 18 Dec 2023 11:17:39 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad1d3069-9d8e-11ee-98eb-6d05b1d4d9a1 From: Nicola Vetrini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Nicola Vetrini , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH v2 2/7] x86/mm: address MISRA C:2012 Rule 2.1 Date: Mon, 18 Dec 2023 11:17:28 +0100 Message-Id: <1cd82cf19a613a122a770bf6670e681ca7fccd44.1702891792.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The "return 0" after the swich statement in 'xen/arch/x86/mm.c' is unreachable because all switch clauses end with returns, and can thus be dropped. No functional changes. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Changes in v2: - Drop the final return instead. A stripped-down version of this switch has been tested on godbolt.org with gcc-4.1.2 and shows no compile-time issues. --- xen/arch/x86/mm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0a66db10b959..49d9f371f35c 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -4887,8 +4887,6 @@ long arch_memory_op(unsigned long cmd, XEN_GUEST_HANDLE_PARAM(void) arg) default: return subarch_memory_op(cmd, arg); } - - return 0; } int cf_check mmio_ro_emulated_write(