| Message ID | 1ea0cd2e-1821-541d-068f-a18309d1823c@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | common: asm/desc.h is an x86-only header | expand |
On 08/08/2023 10:42 am, Jan Beulich wrote: > From briefly going over 9062553a0dc1 it looks like the #include in what > was ac_timer.c was added there for no reason. It's unneeded now in any > event, and it is the sole reason for Arm to have that dummy header. > Purge that, thus avoiding PPC to also gain one. And RISC-V too. > Signed-off-by: Jan Beulich <jbeulich@suse.com> I'd noticed this too, and was wondering why it had escaped into common code. Good riddance. Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Hi Jan, On 08/08/2023 10:42, Jan Beulich wrote: > From briefly going over 9062553a0dc1 it looks like the #include in what > was ac_timer.c was added there for no reason. It's unneeded now in any > event, and it is the sole reason for Arm to have that dummy header. > Purge that, thus avoiding PPC to also gain one. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
--- a/xen/arch/arm/include/asm/desc.h +++ /dev/null @@ -1,12 +0,0 @@ -#ifndef __ARCH_DESC_H -#define __ARCH_DESC_H - -#endif /* __ARCH_DESC_H */ -/* - * Local variables: - * mode: C - * c-file-style: "BSD" - * c-basic-offset: 4 - * indent-tabs-mode: nil - * End: - */ --- a/xen/common/timer.c +++ b/xen/common/timer.c @@ -22,7 +22,6 @@ #include <xen/rcupdate.h> #include <xen/symbols.h> #include <asm/system.h> -#include <asm/desc.h> #include <asm/atomic.h> /* We program the time hardware this far behind the closest deadline. */
From briefly going over 9062553a0dc1 it looks like the #include in what was ac_timer.c was added there for no reason. It's unneeded now in any event, and it is the sole reason for Arm to have that dummy header. Purge that, thus avoiding PPC to also gain one. Signed-off-by: Jan Beulich <jbeulich@suse.com>