From patchwork Fri Feb 12 15:56:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8292761 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C38BDC1F0D for ; Fri, 12 Feb 2016 15:59:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E8E6B203C4 for ; Fri, 12 Feb 2016 15:59:31 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 160E0203C1 for ; Fri, 12 Feb 2016 15:59:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aUG5U-0005Mw-1N; Fri, 12 Feb 2016 15:56:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aUG5S-0005Mr-GW for xen-devel@lists.xenproject.org; Fri, 12 Feb 2016 15:56:50 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 07/43-29293-1C00EB65; Fri, 12 Feb 2016 15:56:49 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-16.tower-206.messagelabs.com!1455292607!21737039!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58244 invoked from network); 12 Feb 2016 15:56:49 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-16.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 12 Feb 2016 15:56:49 -0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1CFujkQ032566 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Feb 2016 15:56:46 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u1CFujUL030087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 12 Feb 2016 15:56:45 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1CFuino030656; Fri, 12 Feb 2016 15:56:44 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 12 Feb 2016 07:56:44 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 0B3486A4BF0; Fri, 12 Feb 2016 10:56:42 -0500 (EST) Date: Fri, 12 Feb 2016 10:56:42 -0500 From: Konrad Rzeszutek Wilk To: Stefano Stabellini Message-ID: <20160212155642.GC28574@char.us.oracle.com> References: <1455246507-5589-1-git-send-email-konrad.wilk@oracle.com> <1455246507-5589-3-git-send-email-konrad.wilk@oracle.com> <20160212141753.GC6596@localhost.localdomain> <56BE027802000078000D1765@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v3 2/5] arm/config: Declare ELFSIZE_[32|64] respectively. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Feb 12, 2016 at 03:26:14PM +0000, Stefano Stabellini wrote: > On Fri, 12 Feb 2016, Jan Beulich wrote: > > >>> On 12.02.16 at 15:17, wrote: > > > --- a/xen/include/asm-arm/config.h > > > +++ b/xen/include/asm-arm/config.h > > > @@ -15,8 +15,10 @@ > > > > > > #if defined(CONFIG_ARM_64) > > > # define LONG_BYTEORDER 3 > > > +# define ELFSIZE 64 > > > #else > > > # define LONG_BYTEORDER 2 > > > +# define ELFSIZE 64 > > > #endif > > > > Leaving the question - why twice instead of outside the #ifdef? > > Right, please move it out of the #ifdef. Done! From 32a062c119091f2f3f6a4c540a8098e97c273dd2 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Fri, 5 Feb 2016 10:44:45 -0500 Subject: [PATCH] arm/config: Declare ELFSIZE_64. Otherwise any code that tries to use Elf_* macros would require us to use Elf64_* types instead of the more friendly Elf_ one. This is OK to do since 32-bit ARM uses LPAE mode. CC: ian.campbell@citrix.com CC: wei.liu2@citrix.com CC: stefano.stabellini@citrix.com Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Stefano Stabellini --- xen/include/asm-arm/config.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h index bd832df..a1b968d 100644 --- a/xen/include/asm-arm/config.h +++ b/xen/include/asm-arm/config.h @@ -25,6 +25,9 @@ /* xen_ulong_t is always 64 bits */ #define BITS_PER_XEN_ULONG 64 +/* And ELF files are also 64-bit. */ +#define ELFSIZE 64 + #define CONFIG_PAGING_ASSISTANCE 1 #define CONFIG_PAGING_LEVELS 3