From patchwork Fri Feb 12 16:29:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8293351 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EA553C02AA for ; Fri, 12 Feb 2016 16:31:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 033202021F for ; Fri, 12 Feb 2016 16:31:57 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDE8C200F3 for ; Fri, 12 Feb 2016 16:31:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aUGb7-0007IJ-RG; Fri, 12 Feb 2016 16:29:33 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aUGb5-0007HY-TI for xen-devel@lists.xenproject.org; Fri, 12 Feb 2016 16:29:32 +0000 Received: from [85.158.137.68] by server-10.bemta-3.messagelabs.com id 31/2D-02807-A680EB65; Fri, 12 Feb 2016 16:29:30 +0000 X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1455294570!22046718!1 X-Originating-IP: [74.125.82.66] X-SpamReason: No, hits=0.7 required=7.0 tests=BODY_RANDOM_LONG, RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 18422 invoked from network); 12 Feb 2016 16:29:30 -0000 Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by server-14.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 12 Feb 2016 16:29:30 -0000 Received: by mail-wm0-f66.google.com with SMTP id p63so3596208wmp.1 for ; Fri, 12 Feb 2016 08:29:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=LFAkG9mOHn5thNhFSCnDhse2Spu1uCyfNJPlhGQ4eKw=; b=b5DZ6y/phsc/UFsEyi+6DsBqNagYgKCk6n2UrbUF0b7c+0rCGbqADh458oBjRPRcsG mvG0Y7EcCeedfiHUS4docwoxixFGjeaAPnBbFkfzZY5O1ToZWg3GjEimJyHzusb3r7Um v0gZ8M3jguOz17HbVaE1OmGHqtbfQ7Zod6u4+WKcl5OrfYNnEbgdL3BI42Knuxg2byh5 b3eop03j0Vmbw2nrXO6phD5/P0KMvU5+R2HLTZC3NSg7uEm2fJutjqFRIAAbJJXerGyB IMhrdRGpW9ECuj/zgYskpZdh1DN45TD/XvSm9qubH8SKdzl49FnOcXufk8IoCIefB5XZ F+Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version:content-type :content-transfer-encoding; bh=LFAkG9mOHn5thNhFSCnDhse2Spu1uCyfNJPlhGQ4eKw=; b=k9odxgiULrNg14CXF7f2yrEPz0OdlpiYHm4PeQkU8hRVqJsDYI9xEW5rHS/LElICJt oEA9hrmXS8AGmc9BcmmLPvHsF0BnY/pW+xc/i0UZBFqohCP2ngmDLapVKWM0UY9EzWac bvOJ9OcVQy/qJy0YjvJuceLhWjcK5HiIinFpFm0l2RsEB4IbNbWezWFXyB96Wayg+9OQ LEaGc+z2fyT1UFEoJcd/U/iyV5/6Hh1h+Ro96o+LCdlR/OgX39vksJYHDYPMymHd0s8L fywjut82UlkTDpUkjWMNSutOlWTEpX7aBNn7ZLYaRGDw4mw7at7XvjUeY9MwrA32bJ8c 8Lwg== X-Gm-Message-State: AG10YORs4VkEarrKawPs4yY6jIsHvgpeP4Sd+O9Oxccn+y0JEtp08HW796xTmmlgH33RZg== X-Received: by 10.194.52.8 with SMTP id p8mr2599702wjo.62.1455294570112; Fri, 12 Feb 2016 08:29:30 -0800 (PST) Received: from Solace.station (net-2-35-170-8.cust.vodafonedsl.it. [2.35.170.8]) by smtp.gmail.com with ESMTPSA id v66sm3054458wmb.18.2016.02.12.08.29.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Feb 2016 08:29:29 -0800 (PST) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Fri, 12 Feb 2016 17:29:27 +0100 Message-ID: <20160212162926.25796.58870.stgit@Solace.station> In-Reply-To: <20160212162338.25796.17618.stgit@Solace.station> References: <20160212162338.25796.17618.stgit@Solace.station> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: George Dunlap , Jan Beulich Subject: [Xen-devel] [PATCH v3 2/2] xen: credit1: avoid boosting vCPUs being "just" migrated X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Moving a vCPU to a different pCPU means offlining it and then waking it up, on the new pCPU. Credit1 grants BOOST priority to vCPUs that wakes up, with the aim of improving I/O latency. The net effect of this all is that vCPUs get boosted when migrating, which shouldn't happen. For instance, this causes scheduling anomalies and, potentially, performance problems, as reported here: http://lists.xen.org/archives/html/xen-devel/2015-10/msg02851.html This patch fixes this by noting down (by means of a flag) the fact that the vCPU is about to undergo a migration. This way we can tell, later, during a wakeup, whether the vCPU is migrating or unblocking, and decide whether or not to apply the boosting. Note that it is important that atomic-safe bit operations are used when manipulating vCPUs' flags. Take the chance and add a comment about this. Signed-off-by: Dario Faggioli --- Cc: George Dunlap Cc: Jan Beulich --- Changes from v2: * test_and_clear() is necessary when accessing svc->flags; * added a comment about such need at the top, where the flags are defined. Changes from v1: * rewritten, following suggestion got during review: there are no wakeup flags any longer, and all is done in sched_credit.c by setting a flag in csched_cpu_pick() and testing (and cleating) it in csched_vcpu_wake(). --- xen/common/sched_credit.c | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 5708701..597a784 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -63,9 +63,14 @@ /* * Flags + * + * Note that svc->flags (where these flags live) is protected by an + * inconsistent set of locks. Therefore atomic-safe bit operations must + * be used for accessing it. */ #define CSCHED_FLAG_VCPU_PARKED 0x0 /* VCPU over capped credits */ #define CSCHED_FLAG_VCPU_YIELD 0x1 /* VCPU yielding */ +#define CSCHED_FLAG_VCPU_MIGRATING 0x2 /* VCPU may have moved to a new pcpu */ /* @@ -787,6 +792,16 @@ _csched_cpu_pick(const struct scheduler *ops, struct vcpu *vc, bool_t commit) static int csched_cpu_pick(const struct scheduler *ops, struct vcpu *vc) { + struct csched_vcpu *svc = CSCHED_VCPU(vc); + + /* + * We have been called by vcpu_migrate() (in schedule.c), as part + * of the process of seeing if vc can be migrated to another pcpu. + * We make a note about this in svc->flags so that later, in + * csched_vcpu_wake() (still called from vcpu_migrate()) we won't + * get boosted, which we don't deserve as we are "only" migrating. + */ + set_bit(CSCHED_FLAG_VCPU_MIGRATING, &svc->flags); return _csched_cpu_pick(ops, vc, 1); } @@ -1022,11 +1037,18 @@ csched_vcpu_wake(const struct scheduler *ops, struct vcpu *vc) * more CPU resource intensive VCPUs without impacting overall * system fairness. * - * The one exception is for VCPUs of capped domains unpausing - * after earning credits they had overspent. We don't boost - * those. + * There are two cases, when we don't want to boost: + * - VCPUs that are waking up after a migration, rather than + * after having block; + * - VCPUs of capped domains unpausing after earning credits + * they had overspent. + * + * Note that checking whether we are "only" migrating must be + * done up front, as we do not want the clearing of the bit we + * set in csched_cpu_pick() to be short-circuited away. */ - if ( svc->pri == CSCHED_PRI_TS_UNDER && + if ( !test_and_clear_bit(CSCHED_FLAG_VCPU_MIGRATING, &svc->flags) && + svc->pri == CSCHED_PRI_TS_UNDER && !test_bit(CSCHED_FLAG_VCPU_PARKED, &svc->flags) ) { TRACE_2D(TRC_CSCHED_BOOST_START, vc->domain->domain_id, vc->vcpu_id);