From patchwork Tue Feb 16 18:11:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8330541 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 298F79F399 for ; Tue, 16 Feb 2016 18:14:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43399202AE for ; Tue, 16 Feb 2016 18:14:18 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6465820268 for ; Tue, 16 Feb 2016 18:14:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVk6T-0003X2-49; Tue, 16 Feb 2016 18:12:01 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVk6R-0003Vq-5o for xen-devel@lists.xenproject.org; Tue, 16 Feb 2016 18:11:59 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id CF/04-07651-E6663C65; Tue, 16 Feb 2016 18:11:58 +0000 X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1455646317!22801509!1 X-Originating-IP: [74.125.82.67] X-SpamReason: No, hits=0.2 required=7.0 tests=RCVD_ILLEGAL_IP X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20905 invoked from network); 16 Feb 2016 18:11:57 -0000 Received: from mail-wm0-f67.google.com (HELO mail-wm0-f67.google.com) (74.125.82.67) by server-12.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 16 Feb 2016 18:11:57 -0000 Received: by mail-wm0-f67.google.com with SMTP id c200so21903772wme.0 for ; Tue, 16 Feb 2016 10:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=d3jh11/AtMJQJA/nfPMA96WAovustkW1uU9zVUp4f6c=; b=SEGiVsE0MQW7ZfCoDobp+x1DXZRutAG0IlkQwg5e16+ZLVTOZKVbzih9TZgUY9QRm6 vIypFvo2f/aI4kJKYYZI5Nra06Ezyi4zyFGitUQIjwR6PpoF6uTRxGRE9UupbiLxK+KW eiVPdrqNCrHHDMj2hfrLt92HdUBR4uzd0khL/jXY/vrNBVhD4vScMnHmvLPVVsVzPANB uOeEQXD/YfDT4u5gXLcKnvgEB5VNaBaLWg9VrDOYedD0OVHscyvwWMJx+DRan4wrKEJF dlHFaNpcZajCq5q+TdnEdr4KB4gbYnecP53mKEFL8R6UlP7Z9HSUCxrpPXWpAnRB+XWt FgVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version:content-type :content-transfer-encoding; bh=d3jh11/AtMJQJA/nfPMA96WAovustkW1uU9zVUp4f6c=; b=XQ1Qk3IBvNfONtCsZyWqDZX0mqIX4p5ga+jDJRl6TzXv+JjssY4CtmykHIbm3B9/aH dXeDyItowdebXdElxKgeYnRaD20KwS98MJychXo8lxw5IgUDofv9dZ+cS1XZrTU07rhV Yg5PFeoJP6+la1E7ytKWt8muoyHYqr2AdTeV5Y1eN67yaj7io2I3vdsFoPoDcTLKVQiI luxk+D9IzfMmAFhjcqA0pfz9oDbs4hoBXrapwWHKQUAmxKR/ax2KY8jYd1CMyBhxwzQy 1W6M0cjpe5/HJTtkoix00JNHn/4TGA5jjhj1SZZLZ3Vvwvq3fR+zmGBCnAgl6wzq3Y83 EzyA== X-Gm-Message-State: AG10YOQFoX6TFUNAreC/nz2jQOVawVq5avTdP5iK9p2NvT4UYvpsxyQ4EXFLTNsssX+uFQ== X-Received: by 10.28.19.130 with SMTP id 124mr21602121wmt.2.1455646317545; Tue, 16 Feb 2016 10:11:57 -0800 (PST) Received: from Solace.station (net-2-35-170-8.cust.vodafonedsl.it. [2.35.170.8]) by smtp.gmail.com with ESMTPSA id t3sm31363188wjz.11.2016.02.16.10.11.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Feb 2016 10:11:56 -0800 (PST) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Tue, 16 Feb 2016 19:11:53 +0100 Message-ID: <20160216181153.27876.34317.stgit@Solace.station> In-Reply-To: <20160216180550.27876.22680.stgit@Solace.station> References: <20160216180550.27876.22680.stgit@Solace.station> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: Olaf Hering , Tianyang Chen , Meng Xu , George Dunlap Subject: [Xen-devel] [PATCH v2 06/16] xen: sched: tracing: enable TSC tracing for all events X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP it is enabled for pretty much all of them already. There were just a few that had it disabled. When tracing a scheduler, timing information is really important, so enable it everywhere scheduling related. Note that this was not really a problem if looking at the traces with xenalyze, but it was if using xentrace_format. Signed-off-by: Dario Faggioli Reviewed-by: Meng Xu Acked-by: George Dunlap --- Cc: George Dunlap Cc: Meng Xu Cc: Tianyang Chen Cc: Olaf Hering --- xen/common/sched_credit.c | 2 +- xen/common/sched_credit2.c | 6 +++--- xen/common/sched_rt.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 5279b92..bd2f37f 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -476,7 +476,7 @@ static inline void __runq_tickle(struct csched_vcpu *new) { /* Avoid TRACE_*: saves checking !tb_init_done each step */ for_each_cpu(cpu, &mask) - __trace_var(TRC_CSCHED_TICKLE, 0, sizeof(cpu), &cpu); + __trace_var(TRC_CSCHED_TICKLE, 1, sizeof(cpu), &cpu); } /* Send scheduler interrupts to designated CPUs */ diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index cf40f68..2934e26 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -456,7 +456,7 @@ runq_insert(const struct scheduler *ops, unsigned int cpu, struct csched2_vcpu * d.dom = svc->vcpu->domain->domain_id; d.vcpu = svc->vcpu->vcpu_id; d.pos = pos; - trace_var(TRC_CSCHED2_RUNQ_POS, 0, + trace_var(TRC_CSCHED2_RUNQ_POS, 1, sizeof(d), (unsigned char *)&d); } @@ -564,7 +564,7 @@ tickle: unsigned cpu:16, pad:16; } d; d.cpu = ipid; d.pad = 0; - trace_var(TRC_CSCHED2_TICKLE, 0, + trace_var(TRC_CSCHED2_TICKLE, 1, sizeof(d), (unsigned char *)&d); } @@ -1721,7 +1721,7 @@ csched2_schedule( */ if ( tasklet_work_scheduled ) { - trace_var(TRC_CSCHED2_SCHED_TASKLET, 0, 0, NULL); + trace_var(TRC_CSCHED2_SCHED_TASKLET, 1, 0, NULL); snext = CSCHED2_VCPU(idle_vcpu[cpu]); } else diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index 53de6d6..33ac9de 100644 --- a/xen/common/sched_rt.c +++ b/xen/common/sched_rt.c @@ -985,7 +985,7 @@ out: } d; d.cpu = cpu_to_tickle; d.pad = 0; - trace_var(TRC_RTDS_TICKLE, 0, + trace_var(TRC_RTDS_TICKLE, 1, sizeof(d), (unsigned char *)&d); }