From patchwork Fri Feb 19 16:59:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8362971 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 42BBEC0553 for ; Fri, 19 Feb 2016 17:02:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 067762052D for ; Fri, 19 Feb 2016 17:02:26 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9177C20524 for ; Fri, 19 Feb 2016 17:02:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWoOw-00027n-OG; Fri, 19 Feb 2016 16:59:30 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aWoOu-00027h-MS for xen-devel@lists.xenproject.org; Fri, 19 Feb 2016 16:59:28 +0000 Received: from [193.109.254.147] by server-4.bemta-14.messagelabs.com id 51/35-10715-FE947C65; Fri, 19 Feb 2016 16:59:27 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1455901165!16615678!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 52661 invoked from network); 19 Feb 2016 16:59:26 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-11.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 19 Feb 2016 16:59:26 -0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1JGxLPs003997 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 19 Feb 2016 16:59:22 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u1JGxL4I009274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 19 Feb 2016 16:59:21 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u1JGxKXx029177; Fri, 19 Feb 2016 16:59:20 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 19 Feb 2016 08:59:20 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 8D7E06A3C8D; Fri, 19 Feb 2016 11:59:17 -0500 (EST) Date: Fri, 19 Feb 2016 11:59:17 -0500 From: Konrad Rzeszutek Wilk To: Jan Beulich Message-ID: <20160219165917.GA11078@char.us.oracle.com> References: <20160215160057.GA4308@char.us.oracle.com> <56C1F859.7040007@citrix.com> <56C211EF02000078000D2514@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56C211EF02000078000D2514@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0022.oracle.com [156.151.31.74] Cc: xen-devel , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [Xen-devel] git workflow and http://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Feb 15, 2016 at 09:59:11AM -0700, Jan Beulich wrote: > >>> On 15.02.16 at 17:10, wrote: > > El 15/2/16 a les 17:00, Konrad Rzeszutek Wilk ha escrit: > >> Hey, > >> > >> I wanted to ask what folks would think of expanding the Wiki to include > > (making it a diff > >> for simpler) this change. With my giant 30 set of patches that not only CC-ed > >> xen-devel twice but had some patches CC some maintainers but not others - I > > figured > >> it may be good to describe this in the Wiki: > >> > >> --- orig 2016-02-15 10:45:27.719204371 -0500 > >> +++ new 2016-02-15 10:58:33.113755665 -0500 > >> @@ -140,7 +140,35 @@ > >> * The maintainers are listed in the MAINTAINERS file at the top of the Xen > > source tree. If no maintainer is listed then there is no need for a CC (if > > you are modifying code with no maintainer then you might like to consider > > becoming the maintainer for that piece of code!). > >> ** You can pipe your patch to the ./scripts/get_maintainer.pl tool > > and it will list the relevant maintainers. > >> * In addition to CCing the maintainer you should always send patches to > > (via TO) the xen-devel@lists.xenproject.org mailing list as well. > >> -* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA. > >> +* To add a CC when sending the mail you can: > >> + * use the ''--cc'' option to the ''git send-email'' command - however if your > >> + patchset is to multiple maintainers - you may end up sending all of the > >> + patches to all maintainers - where some of them have no interest in > >> + viewing them (as they are not under their responsibility). > >> + * edit each patch to have the proper maintainer on the CC list by adding: > >> +
> >> +CC: joe@doe.com 
> > 
> > I'm not a maintainer/committer myself, but since we are spelling this
> > out, I think maintainers/committers prefer that the "Cc:" tags are
> > placed after a "---".
> 
> While I'm one of those who indeed does, I recall there having been
> different views (derived from there being different view on whether
> it is a good idea to retain these Cc-s in what gets committed).
> 


How about:

--- orig	2016-02-15 10:45:27.719204371 -0500
+++ new	2016-02-19 11:57:34.827213537 -0500
@@ -140,7 +140,42 @@
 * The maintainers are listed in the MAINTAINERS file at the top of the Xen source tree. If no maintainer is listed then there is no need for a CC (if you are modifying code with no maintainer then you might like to consider becoming the maintainer for that piece of code!).
 ** You can pipe your patch to the ./scripts/get_maintainer.pl tool and it will list the relevant maintainers.
 * In addition to CCing the maintainer you should always send patches to (via TO) the xen-devel@lists.xenproject.org mailing list as well.
-* To add a CC when sending the mail you can use the ''--cc'' option to the ''git send-email'' command, or you can do it manually in your MUA.
+* To add a CC when sending the mail you can:
+  * use the ''--cc'' option to the ''git send-email'' command - however if your
+    patchset is to multiple maintainers - you may end up sending all of the
+    patches to all maintainers  - where some of them have no interest in
+    viewing them (as they are not under their responsibility)
+  * edit each patch to have the proper maintainer on the CC list by adding:
+
+---
+CC: joe@example.com
+---
+

+   in the patch. The ''---'' means that when the patch is applied the text
+in between them is discarded.
+  * or alternatively use --cc-cmd in your .gitconfig or git-send-email:
+
+[sendemail]
+    cc-cmd = scripts/get_maintainer.pl --no-l
+

+or:
+
+git send-email --cc-cmd="scripts/get_maintainer.pl 
+

+which will automatically add the proper maintainer on the CC line.
+The ''no-l'' is to not add the mailing list to the CC (as you would
+be adding that via the TO - see above)
+  * or you can do it manually in your MUA.
+
+In short, it could look like this:
+
+$pwd
+/home/joe/xen
+git send-email --cc-cmd="scripts/get_maintainer.pl --no-l --to xen-devel@lists.xenproject.org --to jo@example.com --compose --subject "[PATCH v1] Fixes to frobnicator." *.patch
+

+
+Which will send all patches to yourself on the TO, to xen-devel mailiing list (on the TO:)
+and the patches will have their CC: list generated based on scripts/get_maintainer.pl.
 
 === Providing a git branch ===