From patchwork Wed Feb 24 16:26:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8409391 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3B751C0553 for ; Wed, 24 Feb 2016 16:29:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 63BA320361 for ; Wed, 24 Feb 2016 16:29:08 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E85720221 for ; Wed, 24 Feb 2016 16:29:07 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYcGt-0007iZ-Qm; Wed, 24 Feb 2016 16:26:39 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYcGr-0007iD-B0 for xen-devel@lists.xen.org; Wed, 24 Feb 2016 16:26:37 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id 95/ED-02874-CB9DDC65; Wed, 24 Feb 2016 16:26:36 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-10.tower-27.messagelabs.com!1456331194!26454117!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 52815 invoked from network); 24 Feb 2016 16:26:35 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-10.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 24 Feb 2016 16:26:35 -0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1OGQOHr001025 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Feb 2016 16:26:24 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u1OGQNrW008371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 24 Feb 2016 16:26:23 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u1OGQMs3018885; Wed, 24 Feb 2016 16:26:23 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Feb 2016 08:26:17 -0800 Received: by char.us.oracle.com (Postfix, from userid 1000) id 67F856A4BF5; Wed, 24 Feb 2016 11:26:16 -0500 (EST) Date: Wed, 24 Feb 2016 11:26:16 -0500 From: Konrad Rzeszutek Wilk To: Andrew Cooper Message-ID: <20160224162616.GB25409@char.us.oracle.com> References: <1455300361-13092-1-git-send-email-konrad.wilk@oracle.com> <1455300361-13092-10-git-send-email-konrad.wilk@oracle.com> <56C37A04.6030501@citrix.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <56C37A04.6030501@citrix.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: userv0021.oracle.com [156.151.31.71] Cc: Keir Fraser , Ian Campbell , jinsong.liu@alibaba-inc.com, xen-devel@lists.xen.org, mpohlack@amazon.de, ross.lagerwall@citrix.com, Stefano Stabellini , Jan Beulich , xen-devel@lists.xenproject.org, sasha.levin@citrix.com Subject: Re: [Xen-devel] [PATCH v3 09/23] xsplice: Add support for bug frames. (v4) X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Feb 16, 2016 at 07:35:32PM +0000, Andrew Cooper wrote: > On 12/02/16 18:05, Konrad Rzeszutek Wilk wrote: > > diff --git a/xen/common/symbols.c b/xen/common/symbols.c > > index a59c59d..bf5623f 100644 > > --- a/xen/common/symbols.c > > +++ b/xen/common/symbols.c > > @@ -17,6 +17,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -101,6 +102,12 @@ bool_t is_active_kernel_text(unsigned long addr) > > (system_state < SYS_STATE_active && is_kernel_inittext(addr))); > > } > > > > +bool_t is_active_text(unsigned long addr) > > +{ > > + return is_active_kernel_text(addr) || > > + is_active_module_text(addr); > > +} > > This would be better as a static inline in a header file, to avoid a > call into a separate translation unit. I stuck it in kernel.h, as so, would that work for you? diff --git a/xen/include/xen/kernel.h b/xen/include/xen/kernel.h index 548b64d..1e8ed68 100644 --- a/xen/include/xen/kernel.h +++ b/xen/include/xen/kernel.h @@ -100,5 +100,20 @@ extern enum system_state { bool_t is_active_kernel_text(unsigned long addr); +#ifdef CONFIG_XSPLICE +#include + +static bool_t is_active_text(unsigned long addr) +{ + return is_active_kernel_text(addr) || + is_active_patch_text(addr); +} +#else +static bool_t is_active_text(unsigned long addr) +{ + return is_active_kernel_text(addr); +} +#endif + #endif /* _LINUX_KERNEL_H */