From patchwork Wed Mar 16 07:35:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8595241 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4DB1EC0553 for ; Wed, 16 Mar 2016 07:38:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13AD5203B6 for ; Wed, 16 Mar 2016 07:38:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9D8B203A5 for ; Wed, 16 Mar 2016 07:38:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ag5zF-0002cU-Gs; Wed, 16 Mar 2016 07:35:21 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ag5zD-0002cO-Ki for xen-devel@lists.xen.org; Wed, 16 Mar 2016 07:35:19 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id 4F/B3-02874-6BC09E65; Wed, 16 Mar 2016 07:35:18 +0000 X-Env-Sender: konrad@char.us.oracle.com X-Msg-Ref: server-14.tower-27.messagelabs.com!1458113716!19324171!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24048 invoked from network); 16 Mar 2016 07:35:18 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-14.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 16 Mar 2016 07:35:18 -0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u2G7Z881006533 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Mar 2016 07:35:09 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u2G7Z8lm005625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 16 Mar 2016 07:35:08 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u2G7Z7ZR007743; Wed, 16 Mar 2016 07:35:07 GMT Received: from char.us.oracle.com (/10.137.176.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 16 Mar 2016 00:35:07 -0700 Received: by char.us.oracle.com (Postfix, from userid 1000) id 273A96A00B6; Wed, 16 Mar 2016 03:35:06 -0400 (EDT) Date: Wed, 16 Mar 2016 03:35:06 -0400 From: Konrad Rzeszutek Wilk To: Doug Goldstein Message-ID: <20160316073506.GA31125@char.us.oracle.com> References: <1458073130-5126-1-git-send-email-cardoe@cardoe.com> <1458073130-5126-4-git-send-email-cardoe@cardoe.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1458073130-5126-4-git-send-email-cardoe@cardoe.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Cc: Andrew Cooper , Keir Fraser , Jan Beulich , xen-devel@lists.xen.org Subject: Re: [Xen-devel] [PATCH v2 3/3] tmem: allow tmem to be disabled with Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Mar 15, 2016 at 03:18:50PM -0500, Doug Goldstein wrote: > Wrap the various tmem functions with the Kconfig generated CONFIG_TMEM > option allowing users to build Xen without tmem support. I ended with this change on top of yours (which I will squash): The 'bool "tmem" so that if I did make an change in .config file it would still take effect even if I forgot XEN_CONFIG_EXPERT. Otherwise it would keep on making it CONFIG_TMEM=y instead of the # CONFIG_TMEM is not set. which I wrote in the .config file. From b9d173eb0e0e1274c784fde5580b119d6f7b4bdc Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Wed, 16 Mar 2016 03:28:39 -0400 Subject: [PATCH] squash! tmem: allow tmem to be disabled with Kconfig --- xen/common/Kconfig | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 39b0fa7..5bd8a84 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -87,16 +87,21 @@ config LATE_HWDOM If unsure, say N. -# Enables transactional memory support +# Enables transcendent memory support config TMEM def_bool y - prompt "Transactional Memory Support" if EXPERT = "y" + bool "tmem" + prompt "Transcendent Memory Support" if EXPERT = "y" ---help--- Transcendent memory allows PV-aware guests to collaborate on memory usage. Guests can 'swap' their memory to the hypervisor or have an collective pool of memory shared across guests. The end result is less memory usage by guests allowing higher guest density. + You also have to enable it on the Xen commandline by using tmem=1 + + If unsure, say Y. + # Adds support for Xenoprof config XENOPROF def_bool y