From patchwork Fri Apr 8 01:23:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Faggioli X-Patchwork-Id: 8779511 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2D3B1C0553 for ; Fri, 8 Apr 2016 01:25:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 458D0201C7 for ; Fri, 8 Apr 2016 01:25:51 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68F9D201CD for ; Fri, 8 Apr 2016 01:25:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoL9V-0007qq-3A; Fri, 08 Apr 2016 01:24:01 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aoL9U-0007qI-6C for xen-devel@lists.xenproject.org; Fri, 08 Apr 2016 01:24:00 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id CE/6D-04050-F2807075; Fri, 08 Apr 2016 01:23:59 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHIsWRWlGSWpSXmKPExsXiVRvkqKvHwR5 ucHCfgcX3LZOZHBg9Dn+4whLAGMWamZeUX5HAmjHrzzbmgud8FT27L7A1ME7g7WLk4hASmMoo sfncB1YQh0VgDavE081r2UEcCYFLrBLtO64zdjFyAjkxEpNXL2fqYuQAssslvn6UAwkLCahI3 Ny+igli0iImiZPHj7CDJIQF9CSOHP0BZSdJbLvWzQZiswkYSLzZsZcVxBYRUJK4t2oyWDMzyB nrH2xkAUmwCKhKvNqykhnE5hWwl+h/fBlsEKeAg8TEDU+ZIDbbS2zrPgFmiwrISay83MIKUS8 ocXLmExaQQ5kFNCXW79IHCTMLyEtsfzuHeQKjyCwkVbMQqmYhqVrAyLyKUb04tagstUjXXC+p KDM9oyQ3MTNH19DAWC83tbg4MT01JzGpWC85P3cTIzD8GYBgB2Pjd6dDjJIcTEqivFfesIUL8 SXlp1RmJBZnxBeV5qQWH2LU4OAQmHB27nQmKZa8/LxUJQnej2zs4UKCRanpqRVpmTnACIUple DgURLh/Q2S5i0uSMwtzkyHSJ1i1OXYMvXeWiYhsBlS4ryvQYoEQIoySvPgRsCSxSVGWSlhXka gA4V4ClKLcjNLUOVfMYpzMCoJ8y4EmcKTmVcCt+kV0BFMQEdc4GcDOaIkESEl1cB4MIpBdJ2J 2jPd9a9ZbhzY/HCTu/qtU21sE2ujH/mGbzdatGfqm1nT4xg3L//z5VL29bRtux5Y7TfzzZB9n 3DW7Qzb+Z/yjTHBMtrHFD5u5nq8Rdno+MZiu/OvNqxVzJtXUyIteyfNTVNk+7X9/47sDf1zvN Kl/daPt79eBtiynTuqc+j6vNMLJZRYijMSDbWYi4oTAYfPIuQRAwAA X-Env-Sender: raistlin.df@gmail.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1460078638!16900609!1 X-Originating-IP: [74.125.82.65] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47413 invoked from network); 8 Apr 2016 01:23:58 -0000 Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by server-12.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 8 Apr 2016 01:23:58 -0000 Received: by mail-wm0-f65.google.com with SMTP id n3so760326wmn.1 for ; Thu, 07 Apr 2016 18:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=hSWiCSqfO6rwwkaDLT8kfByK1XhNA4ih8vMk78ng5rw=; b=mwOpVtBhdDm6Zpe+0GigYW9vq3KVe9v6bROIX2qKiHFT99ww4xYSBh6S/aLkCXkERP oH0vMJoad1c52Xf6kFPGiEkJ9XeSWOy56JtUq4LTQGBybwks5ei5cJC9mmH1P39dOQtZ X3wtDdluS001VQYXrKD+YhM0eCegLALUl3bta5XQPT8Nn9szksiIN8xxIoM+054oUmNq evRX+WGYc7lNLc6n5oLeChTVYh3nZW7u+z3qHTcUq9jHi+qWpaaD06jEMRJe/UkpjdkJ 5GErfNkHp+IgPSqE9PSLbxhN7mYob2Woomjy9vWcSM0RpSxuCzQdpA37eusSi2dgiCur mvKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=hSWiCSqfO6rwwkaDLT8kfByK1XhNA4ih8vMk78ng5rw=; b=bb5qrv6smtTE4F0fppj2ABn14wwUhcXs4XI6It5bAbv/+18ugt4tAohaODLOeM9xzD aRU/fytWqtukR5ReXpERRNn6j3htyUFxiHr+an/Ap2UNV4DgyU755QtE2z9iu2YwlbrT YtynX2EmbQoqZFPsvTKch6G6v29B6oFgpePMX8uwweM1+uuoMNDLyDoTT51r8Nrfqihe QxaQ9xbb1x/I2znD5Kbxmjxihkd+o5D2HjbQ0CzzQNGc51JkZJm1wzf5MPnnRXfutm+X u6ddZGAIjc8ZbOU1rohhj/Mlo7Hs6qqZQ66wCBM4d3hu8ibabmn1+rlfoszI7tTKuQ9e nA7g== X-Gm-Message-State: AD7BkJK/LoW70as47oa5JrBqlV1NH0arxW2UKn0ZyPo+NE01MURjowfz9L2H1bAdAwfS7w== X-Received: by 10.28.128.88 with SMTP id b85mr638202wmd.46.1460078638514; Thu, 07 Apr 2016 18:23:58 -0700 (PDT) Received: from Solace.fritz.box (net-37-116-155-252.cust.vodafonedsl.it. [37.116.155.252]) by smtp.gmail.com with ESMTPSA id 198sm560480wml.22.2016.04.07.18.23.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Apr 2016 18:23:57 -0700 (PDT) From: Dario Faggioli To: xen-devel@lists.xenproject.org Date: Fri, 08 Apr 2016 03:23:56 +0200 Message-ID: <20160408012355.10762.18416.stgit@Solace.fritz.box> In-Reply-To: <20160408011204.10762.14241.stgit@Solace.fritz.box> References: <20160408011204.10762.14241.stgit@Solace.fritz.box> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Cc: Juergen Gross , George Dunlap , Jan Beulich , Uma Sharma Subject: [Xen-devel] [PATCH v3 05/11] xen: sched: improve credit2 bootparams' scope, placement and signedness X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Uma Sharma and, while we are adjusting signedness of opt_load_window_shift, make also prv->load_window_shift unsigned, as approapriate. Signed-off-by: Uma Sharma Signed-off-by: Dario Faggioli Reviewed-by: Juergen Gross Acked-by: George Dunlap --- Cc: Jan Beulich --- xen/common/sched_credit2.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c index 60c6f5b..7286e50 100644 --- a/xen/common/sched_credit2.c +++ b/xen/common/sched_credit2.c @@ -162,7 +162,7 @@ #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request) -int opt_migrate_resist=500; +static unsigned int __read_mostly opt_migrate_resist = 500; integer_param("sched_credit2_migrate_resist", opt_migrate_resist); /* @@ -185,12 +185,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist); * to a load of 1. */ #define LOADAVG_GRANULARITY_SHIFT (10) -int opt_load_window_shift=18; +static unsigned int __read_mostly opt_load_window_shift = 18; #define LOADAVG_WINDOW_SHIFT_MIN 4 integer_param("credit2_load_window_shift", opt_load_window_shift); -int opt_underload_balance_tolerance=0; +static int __read_mostly opt_underload_balance_tolerance = 0; integer_param("credit2_balance_under", opt_underload_balance_tolerance); -int opt_overload_balance_tolerance=-3; +static int __read_mostly opt_overload_balance_tolerance = -3; integer_param("credit2_balance_over", opt_overload_balance_tolerance); /* @@ -227,7 +227,7 @@ struct csched2_private { cpumask_t active_queues; /* Queues which may have active cpus */ struct csched2_runqueue_data rqd[NR_CPUS]; - int load_window_shift; + unsigned int load_window_shift; }; /*