diff mbox

[v2,15/20] livepatch: Move test-cases to common

Message ID 20160906171614.GE2161@char.us.oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Konrad Rzeszutek Wilk Sept. 6, 2016, 5:16 p.m. UTC 
On Thu, Aug 25, 2016 at 09:05:27AM -0600, Jan Beulich wrote:
> >>> On 25.08.16 at 15:37, <konrad.wilk@oracle.com> wrote:
> > So they can be shared with ARM64 (but not yet, so they
> > are only built on x86).
> > 
> > No functional change.
> > 
> > We also need to tweak the MAINTAINERS and .gitignore file
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> for whichever parts it's relevant
> Acked-by: Jan Beulich <jbeulich@suse.com>

Thank you!
> with one adjustment request:
> 
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -271,6 +271,7 @@ F:  tools/misc/xen-livepatch.c
> >  F:  xen/arch/*/livepatch*
> >  F:  xen/arch/*/*/livepatch*
> >  F:  xen/common/livepatch*
> > +F:  xen/test/livepatch/*
> >  F:  xen/include/xen/livepatch*
> 
> Please keep this sorted.

A side effect of that is that * vs / gets moved too.

> 
> Jan
>

Comments

Jan Beulich Sept. 7, 2016, 8:28 a.m. UTC | #1 
>>> On 06.09.16 at 19:16, <konrad.wilk@oracle.com> wrote:
> On Thu, Aug 25, 2016 at 09:05:27AM -0600, Jan Beulich wrote:
>> >>> On 25.08.16 at 15:37, <konrad.wilk@oracle.com> wrote:
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -271,6 +271,7 @@ F:  tools/misc/xen-livepatch.c
>> >  F:  xen/arch/*/livepatch*
>> >  F:  xen/arch/*/*/livepatch*
>> >  F:  xen/common/livepatch*
>> > +F:  xen/test/livepatch/*
>> >  F:  xen/include/xen/livepatch*
>> 
>> Please keep this sorted.
> 
> A side effect of that is that * vs / gets moved too.
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7d42883..507bb40 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -268,10 +268,11 @@ M:  Ross Lagerwall <ross.lagerwall@citrix.com>
>  S:  Supported
>  F:  docs/misc/livepatch.markdown
>  F:  tools/misc/xen-livepatch.c
> -F:  xen/arch/*/livepatch*
>  F:  xen/arch/*/*/livepatch*
> +F:  xen/arch/*/livepatch*
>  F:  xen/common/livepatch*
>  F:  xen/include/xen/livepatch*
> +F:  xen/test/livepatch/*
> 
> You OK with that or would you prefer to leave it as is?

I'd prefer if you just put the addition at the right slot. I don't think
we mean to fully specify collating rules here. Alphabetical / numerical
sorting should be kept, but whether meta-characters like * are
meant to sort before or after alphanumeric ones is, I would say,
simply undefined here.

Jan
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 7d42883..507bb40 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -268,10 +268,11 @@  M:  Ross Lagerwall <ross.lagerwall@citrix.com>
 S:  Supported
 F:  docs/misc/livepatch.markdown
 F:  tools/misc/xen-livepatch.c
-F:  xen/arch/*/livepatch*
 F:  xen/arch/*/*/livepatch*
+F:  xen/arch/*/livepatch*
 F:  xen/common/livepatch*
 F:  xen/include/xen/livepatch*
+F:  xen/test/livepatch/*

You OK with that or would you prefer to leave it as is?