From patchwork Mon Sep 19 09:29:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olaf Hering X-Patchwork-Id: 9338901 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D5A3607D0 for ; Mon, 19 Sep 2016 09:33:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D38D28C61 for ; Mon, 19 Sep 2016 09:33:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 11E5028C81; Mon, 19 Sep 2016 09:33:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM, RCVD_IN_SORBS_WEB, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 10A2628C61 for ; Mon, 19 Sep 2016 09:33:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bluvH-0003i0-6x; Mon, 19 Sep 2016 09:31:35 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bluvF-0003hM-SW for xen-devel@lists.xen.org; Mon, 19 Sep 2016 09:31:34 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id FA/A8-15404-570BFD75; Mon, 19 Sep 2016 09:31:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRWlGSWpSXmKPExsUSuHLSZt2SDff DDQ4fELdY8nExiwOjx9Hdv5kCGKNYM/OS8isSWDPWz57AWLCFu+LdPtEGxg7OLkYuDhaBx0wS B16dY+li5OSQEBCROHTiIZTtK3Hj/gJ2kCIhgYdMEq+vXgdKcAA56RJtK5xBatgElCT2HjzOC GKLCEhLXPt8mRGknlngAZPExZ0rWUESwgKWEv8/3GEGsVkEVCWuHL4DFucVMJLY1XGCDWKZvM S17//YJjDyLGBkWMWoUZxaVJZapGtkopdUlJmeUZKbmJmja2hgppebWlycmJ6ak5hUrJecn7u JEeh3BiDYwbhyXeAhRkkOJiVR3sWz74cL8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuBVXA+UEyxK TU+tSMvMAQYgTFqCg0dJhPfLOqA0b3FBYm5xZjpE6hSjLse2eXuvMAmx5OXnpUqJ83KBzBAAK coozYMbAYuGS4yyUsK8jEBHCfEUpBblZpagyr9iFOdgVBLmPQ+yiiczrwRu0yugI5iAjmDsAT uiJBEhJdXAaCLRvSTxZ1zl/MDlFQrpp/9k/p75ZfOU0NO5njVe/gFzjHrv/eec6JX79aUvl9L sf+d4knsieveeuP37y4Ye62TXlbzn3qf/u+alqCiZFj5x9aHCyUqv7flfi30MbVpnYeLd/8D+ 0++zK9oan258KpSqxSR90zNt1entTdvuebrWcXq7/NxxXImlOCPRUIu5qDgRAEpb3gmBAgAA X-Env-Sender: olaf@aepfle.de X-Msg-Ref: server-2.tower-27.messagelabs.com!1474277492!7459690!1 X-Originating-IP: [81.169.146.179] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 63588 invoked from network); 19 Sep 2016 09:31:32 -0000 Received: from mo4-p04-ob.smtp.rzone.de (HELO mo4-p04-ob.smtp.rzone.de) (81.169.146.179) by server-2.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 19 Sep 2016 09:31:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1474277492; l=1413; s=domk; d=aepfle.de; h=Date:Subject:Cc:To:From; bh=4w4sZjbfy9FMaGl+hzwpUOmFYcsCVwsVIxeFBh5wx6A=; b=JXrLD/YmJc6uV8ozL6UMoOuo2HK8AhA1Z/M+hbN7aoF38VWlxcBfbfsMhU3qPwQagUK dpF/+/LoQ3kOPxCUDw0A8u5O+cX3axgscQpxnclD525qX9vIyGCgW4Aae/J72uSpsxfBo 65Q7ZZp8UvuH2UhML9t7q8uPHUpSpBWOslg= X-RZG-CLASS-ID: mo04 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWtqWFmrC5F/k8792brrkQ== Received: from probook (aftr-185-17-204-180.dynamic.mnet-online.de [185.17.204.180]) by smtp.strato.de (RZmta 39.2 SBL|AUTH) with ESMTPSA id L087d8s8J9UL9gO (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Mon, 19 Sep 2016 11:30:21 +0200 (CEST) Received: by probook (Postfix, from userid 1000) id E38E7508A0; Mon, 19 Sep 2016 11:30:19 +0200 (CEST) From: Olaf Hering To: xen-devel@lists.xen.org Date: Mon, 19 Sep 2016 09:29:46 +0000 Message-Id: <20160919092946.3292-1-olaf@aepfle.de> X-Mailer: git-send-email 2.10.0 Cc: Olaf Hering , Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich Subject: [Xen-devel] [PATCH] docs: correct values for old VMDP unplug X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Fix commit f6d4cf5 ("docs: document old SUSE/Novell unplug for HVM"). The values which VMDP used to control either NIC or disk are flipped. What the code does is: case 8: if (val == 1 ) { ide_unplug_harddisks(); } else if (val == 2) { pci_unplug_netifs(); net_tap_shutdown_all(); } break; Signed-off-by: Olaf Hering Acked-by: Wei Liu --- docs/misc/hvm-emulated-unplug.markdown | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index 70fb024..256cea2 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -89,8 +89,8 @@ Novells VMDP. Depending on how VMDP was configured it would control all devices, or either NIC or storage. To control all devices the value 0x1 was written to offset 0x4 in the memory region of the Xen Platform PCI Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP -was configured to control just NIC devices it would write the value 0x1 +was configured to control just NIC devices it would write the value 0x2 to offset 0x8. If VMDP was configured to control just storage devices it -would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7 +would write the value 0x1 to offset 0x8. Starting with VMDP version 1.7 (released 2011) the official protocol was used.