From patchwork Mon Sep 19 20:19:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 9340461 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E35E76022E for ; Mon, 19 Sep 2016 20:22:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D689D2986F for ; Mon, 19 Sep 2016 20:22:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CAA9229884; Mon, 19 Sep 2016 20:22:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RCVD_IN_SORBS_SPAM,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A86202986F for ; Mon, 19 Sep 2016 20:22:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bm536-0000K5-M2; Mon, 19 Sep 2016 20:20:20 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bm535-0000Jz-BF for xen-devel@lists.xenproject.org; Mon, 19 Sep 2016 20:20:19 +0000 Received: from [85.158.137.68] by server-9.bemta-3.messagelabs.com id 09/F2-27233-28840E75; Mon, 19 Sep 2016 20:20:18 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMIsWRWlGSWpSXmKPExsXSO6nOVbfJ40G 4wctZXBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8a0Jy3sBfP4K97unsvUwHiOo4uRi0NIoINJ YkLnTWYI5xujxKFV19khnI2MEnOWTAbKcAI5nYwSC1dXg9gsAqoS+0//Y+pi5OBgEzCReLPKE SQsIqAu8efCBEaQXmaBM4wSR55MZgVJCAsEScycuI4dxOYVMJPY2b6TFWLBY0aJ78cvMEMkBC VOznzCAmIzC2hJ3Pj3EmwBs4C0xPJ/HCBhTgFridffFoPNERVQlmiY8QCsVULAWKJvVh/LBEb BWUgmzUIyaRbCpAWMzKsYNYpTi8pSi3SNTPWSijLTM0pyEzNzdA0NjPVyU4uLE9NTcxKTivWS 83M3MQIDt56BgXEHY+sJv0OMkhxMSqK8cnwPwoX4kvJTKjMSizPii0pzUosPMcpwcChJ8Mq5A +UEi1LTUyvSMnOAMQSTluDgURLhve4GlOYtLkjMLc5Mh0idYlSUEuf9DZIQAElklObBtcHi9h KjrJQwLyMDA4MQT0FqUW5mCar8K0ZxDkYlYd5XIFN4MvNK4Ka/AlrMBLSYsec+yOKSRISUVAO jfap2xIKWQ+yWFj2T0mL5p29fcvkFx+bLmSeO8Ewq8Lz8sZkj2+LuObuiXyxXJ6nJ7NNjiKno iCuqOLX83iG91L+O9buYn99UZuCbskK++zp/UEtWzeMSjtp/m53dvmsU2uZ4lOXufxi68lSc3 k1BmckmabqpD9jXWFttnWK8+8tUFSF/TgslluKMREMt5qLiRACTIjmf1gIAAA== X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-13.tower-31.messagelabs.com!1474316416!60948236!1 X-Originating-IP: [141.146.126.69] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTQxLjE0Ni4xMjYuNjkgPT4gMjc3MjE4\n X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 34464 invoked from network); 19 Sep 2016 20:20:17 -0000 Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by server-13.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 19 Sep 2016 20:20:17 -0000 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u8JKK86t025438 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Sep 2016 20:20:09 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u8JKK8RP015761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 19 Sep 2016 20:20:08 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u8JKK2S5019998; Mon, 19 Sep 2016 20:20:07 GMT Received: from x230.dumpdata.com (/10.154.139.13) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 19 Sep 2016 13:20:01 -0700 Date: Mon, 19 Sep 2016 16:19:55 -0400 From: Konrad Rzeszutek Wilk To: Julien Grall Message-ID: <20160919201939.GA28345@x230.dumpdata.com> References: <1474043908-12101-1-git-send-email-konrad.wilk@oracle.com> <1474043908-12101-13-git-send-email-konrad.wilk@oracle.com> <971defec-b158-051d-dd48-a70be37317bc@arm.com> <0af2ec65-1af8-3341-5fe8-53f02a9ce10b@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0af2ec65-1af8-3341-5fe8-53f02a9ce10b@arm.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Cc: sstabellini@kernel.org, Andrew Cooper , ross.lagerwall@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH v4 12/16] bug/x86/arm: Align bug_frames sections. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP > > > Signed-off-by: Konrad Rzeszutek Wilk > > I forgot to mention that with those NITs fixed: > > Reviewed-by: Julien Grall Thanks. However I noticed (and I recall having it replaced in earlier versions so I must have in a hurry missed it), but this: > > > --- a/xen/include/asm-arm/bug.h > > > +++ b/xen/include/asm-arm/bug.h > > > @@ -52,6 +52,7 @@ struct bug_frame { > > > > > > ".popsection\n" \ > > > ".pushsection .bug_frames." __stringify(type) ", \"a\", > > > %progbits\n"\ > > > > > > "4:\n" \ > > > + ".align 4\n" \ [fixed up, your mailer mangled it] This should have been: So that it would be in sync with x86 version. The end result is exactly the same - it is just that p2align is preferred because it has the same semantics across platforms while .align differs. I made the change (along with your recommendations) and put your Reviewed-by. I hope that is OK. diff --git a/xen/include/asm-arm/bug.h b/xen/include/asm-arm/bug.h index 773d63e..affe64f 100644 --- a/xen/include/asm-arm/bug.h +++ b/xen/include/asm-arm/bug.h @@ -52,7 +52,7 @@ struct bug_frame { ".popsection\n" \ ".pushsection .bug_frames." __stringify(type) ", \"a\", %progbits\n"\ "4:\n" \ - ".align 4\n" \ + ".p2align 4\n" \ ".long (1b - 4b)\n" \ ".long (2b - 4b)\n" \ ".long (3b - 4b)\n" \