| Message ID | 20160928182457.12433-15-andre.przywara@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, 28 Sep 2016, Andre Przywara wrote: > The INT command sets a given LPI identified by a DeviceID/EventID pair > as pending and thus triggers it to be injected. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > xen/arch/arm/vgic-its.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/xen/arch/arm/vgic-its.c b/xen/arch/arm/vgic-its.c > index 99d9e9c..7072753 100644 > --- a/xen/arch/arm/vgic-its.c > +++ b/xen/arch/arm/vgic-its.c > @@ -192,6 +192,37 @@ static int its_handle_clear(struct virt_its *its, uint64_t *cmdptr) > return 0; > } > > +static int its_handle_int(struct virt_its *its, uint64_t *cmdptr) > +{ > + uint32_t devid = its_cmd_get_deviceid(cmdptr); > + uint32_t eventid = its_cmd_get_id(cmdptr); > + struct vits_itte *itte; > + struct vcpu *vcpu; > + int ret = -1; > + uint32_t vlpi; > + > + spin_lock(&its->its_lock); > + > + itte = get_devid_evid(its, devid, eventid); > + if ( !itte ) > + goto out_unlock; > + > + vcpu = its->d->vcpu[itte->collection]; We need to check that itte->collection is a valid vcpu before using as array index. > + vlpi = itte->vlpi; > + > + ret = 0; > + > + put_devid_evid(its, itte); > + > +out_unlock: > + spin_unlock(&its->its_lock); > + > + if ( !ret) code style > + vgic_vcpu_inject_irq(vcpu, vlpi); > + > + return ret; > +} > + > #define ITS_CMD_BUFFER_SIZE(baser) ((((baser) & 0xff) + 1) << 12) > > static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, > @@ -215,6 +246,9 @@ static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, > case GITS_CMD_CLEAR: > its_handle_clear(its, cmdptr); > break; > + case GITS_CMD_INT: > + its_handle_int(its, cmdptr); > + break; > case GITS_CMD_SYNC: > /* We handle ITS commands synchronously, so we ignore SYNC. */ > break; > -- > 2.9.0 >
diff --git a/xen/arch/arm/vgic-its.c b/xen/arch/arm/vgic-its.c index 99d9e9c..7072753 100644 --- a/xen/arch/arm/vgic-its.c +++ b/xen/arch/arm/vgic-its.c @@ -192,6 +192,37 @@ static int its_handle_clear(struct virt_its *its, uint64_t *cmdptr) return 0; } +static int its_handle_int(struct virt_its *its, uint64_t *cmdptr) +{ + uint32_t devid = its_cmd_get_deviceid(cmdptr); + uint32_t eventid = its_cmd_get_id(cmdptr); + struct vits_itte *itte; + struct vcpu *vcpu; + int ret = -1; + uint32_t vlpi; + + spin_lock(&its->its_lock); + + itte = get_devid_evid(its, devid, eventid); + if ( !itte ) + goto out_unlock; + + vcpu = its->d->vcpu[itte->collection]; + vlpi = itte->vlpi; + + ret = 0; + + put_devid_evid(its, itte); + +out_unlock: + spin_unlock(&its->its_lock); + + if ( !ret) + vgic_vcpu_inject_irq(vcpu, vlpi); + + return ret; +} + #define ITS_CMD_BUFFER_SIZE(baser) ((((baser) & 0xff) + 1) << 12) static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, @@ -215,6 +246,9 @@ static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, case GITS_CMD_CLEAR: its_handle_clear(its, cmdptr); break; + case GITS_CMD_INT: + its_handle_int(its, cmdptr); + break; case GITS_CMD_SYNC: /* We handle ITS commands synchronously, so we ignore SYNC. */ break;
The INT command sets a given LPI identified by a DeviceID/EventID pair as pending and thus triggers it to be injected. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- xen/arch/arm/vgic-its.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)