From patchwork Fri Oct 14 19:28:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyle Huey X-Patchwork-Id: 9377339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 67BDE60779 for ; Fri, 14 Oct 2016 19:31:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5384E2A833 for ; Fri, 14 Oct 2016 19:31:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47D312A835; Fri, 14 Oct 2016 19:31:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_SPAM,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3F89E2A833 for ; Fri, 14 Oct 2016 19:31:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv8A7-0005Gd-5F; Fri, 14 Oct 2016 19:28:59 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bv8A5-0005GV-WD for xen-devel@lists.xen.org; Fri, 14 Oct 2016 19:28:58 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id 0F/1E-10540-9F131085; Fri, 14 Oct 2016 19:28:57 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrAIsWRWlGSWpSXmKPExsVyMfTAEd0fhow RBtO3KVss+biYxYHR4+ju30wBjFGsmXlJ+RUJrBkPT6gX/OSueNp9hqmBcSVHFyMXh5DAREaJ dT/fsIA4LALNrBInLkxnBXEkBPpZJabtv8DWxcgJ5MRILJo+mR3CLpP4c381I4gtJCAnceDkC SaIUcuYJKad/MkMkmATUJS4t24HI0SDmUTrpResILaIgK7EswXPwIYyC2xhlNj8w6eLkYNDWM BHYukreZAwi4CqROOCnWDlvECt1xr7oG6Ql7hw9RQLiM0pYCex9c1BdogbbCWmfDjLMoFRcAE jwypG9eLUorLUIl1jvaSizPSMktzEzBxdQwNjvdzU4uLE9NScxKRiveT83E2MwHBjAIIdjM1f nA4xSnIwKYny2nxliBDiS8pPqcxILM6ILyrNSS0+xCjDwaEkwXtAkjFCSLAoNT21Ii0zBxj4M GkJDh4lEd4FIGne4oLE3OLMdIjUKUZjji2/r61l4tg29d5aJiGWvPy8VClx3gsgpQIgpRmleX CDYBF5iVFWSpiXEeg0IZ6C1KLczBJU+VeM4hyMSsK820Cm8GTmlcDtewV0ChPQKR/aGEBOKUl ESEk1MM5/E7LEa+sel16r1mely8tNfmWH1F0urQgqfnHh2UG1657XMzeGRfMdeNN71nSSwZeQ 601N7+f9/256+fCiuwE7vjvvl1T+dmwhw2Th+YaG7mEfFCxO5lwW280vOMnDsOLyJu4N9abPP 7tsffx7vdtl4UsPy96pRcusKXvYs/IzX9MTd/NgubVKLMUZiYZazEXFiQDW05YNwwIAAA== X-Env-Sender: me@kylehuey.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1476473335!66233397!1 X-Originating-IP: [209.85.192.196] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.84; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15252 invoked from network); 14 Oct 2016 19:28:56 -0000 Received: from mail-pf0-f196.google.com (HELO mail-pf0-f196.google.com) (209.85.192.196) by server-14.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 14 Oct 2016 19:28:56 -0000 Received: by mail-pf0-f196.google.com with SMTP id 128so7792084pfz.1 for ; Fri, 14 Oct 2016 12:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kylehuey-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yecM8jS7K7Wc3DkokE/Xf+CUNaClPQMSi+/Pe70BwGo=; b=cBb6qUCO880+iItGBYJqxBfNZ5FrqANZ5QDCy5nJ9utURmHsBjyxhTMeuDLtaE8Gf1 gLdRJMYzLqPMFVydQvhKEW7b0ODyMmjD+/DTZr5UF+rZbQ0P0/E1Zdv54UYAtyRro5Rr NEyP8tstN/cUM49j1Zv8jyf8r8P8LupNrng2OC9sgP41CvOaHDUC+821w3sW6hG5/7gS qE1/HuQunJbrRLjltaCoq+5EkqmvNQbKbJJBmXH2plHM8AodvgSHGOe0P6KfT3BKIgHQ gzPt2YPsMWYIwoMF+kpelor26IH+FdfBinyEx7DkJoLH+TwfqYOJyYe4TYBaUypfrZi1 8QuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yecM8jS7K7Wc3DkokE/Xf+CUNaClPQMSi+/Pe70BwGo=; b=K9kPUbfR4+BY0NWzSw5Hh7X8CD/xciEUBXtR0qfJg5qHbAux9wv116ETAr2TynYj9b vYqn46PyuhVkpqXc/HIz41GX7SkR+r+JFXTuUyYkuYNyPk6/+zFeihqx+CaFdNYQr6+k wIpAevo6bUCOdR3Fqy2bbrzTPbyqAFbvqftIO7M+Ifv+UgtfR41FEWtQSo5f3Xg9MFAe TrvcxhX0zbXBt1UzE/+A0rsMO0JvgS+xMhyt1qgIefoekYBMHlsdjWYnQTnL6SX3uXqP 8EmFkooLcHwqF2xd3jHLO6C4g8u88rwoqwCSAPnhPriZnmNCoJcdYm5jdT+32lfVMOph y7YA== X-Gm-Message-State: AA6/9Rnaw/kAAfxK93pOzaVbVCqj6o+LEkC+2jRaoCBrulgdGCVDUsyVM8yEn88r/oFZrw== X-Received: by 10.98.113.1 with SMTP id m1mr16813521pfc.2.1476473334758; Fri, 14 Oct 2016 12:28:54 -0700 (PDT) Received: from minbar.hsd1.ca.comcast.net (c-73-162-102-141.hsd1.ca.comcast.net. [73.162.102.141]) by smtp.gmail.com with ESMTPSA id oo10sm26038200pac.12.2016.10.14.12.28.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 14 Oct 2016 12:28:53 -0700 (PDT) From: Kyle Huey X-Google-Original-From: Kyle Huey To: Andrew Cooper Date: Fri, 14 Oct 2016 12:28:52 -0700 Message-Id: <20161014192852.5355-1-khuey@kylehuey.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: References: Cc: Kevin Tian , xen-devel@lists.xen.org, Jun Nakajima , Jan Beulich , Robert O'Callahan Subject: Re: [Xen-devel] [PATCH v2 2/2] x86/Intel: virtualize support for cpuid faulting X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP > :) I am now curious as to which bit I missed. I made these changes. - Kyle --- tests/cpuid-faulting/main.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) base-commit: 0342fd279b05d0c2e31c8418fcffcdc9e48eb42f diff --git a/tests/cpuid-faulting/main.c b/tests/cpuid-faulting/main.c index 3e782a2..221567d 100644 --- a/tests/cpuid-faulting/main.c +++ b/tests/cpuid-faulting/main.c @@ -37,36 +37,39 @@ bool ex_record_fault_ebx(struct cpu_regs *regs, } unsigned int stub_rdmsr(uint32_t idx, uint64_t *val) { unsigned int fault = 0; uint32_t lo, hi; *val = 0; - asm volatile("1: rdmsr; 2:" + asm volatile("1: rdmsr;" + "xor %%ebx, %%ebx; 2:" _ASM_EXTABLE_HANDLER(1b, 2b, ex_record_fault_ebx) : "=a" (lo), "=d" (hi), "=&b" (fault) : "c" (idx)); if ( !fault ) *val = (((uint64_t)hi) << 32) | lo; return fault; } unsigned int stub_wrmsr(uint32_t idx, uint64_t val) { unsigned int fault = 0; - asm volatile("1: rdmsr; 2:" + asm volatile("1: wrmsr;" + "xor %%ebx, %%ebx; 2:" _ASM_EXTABLE_HANDLER(1b, 2b, ex_record_fault_ebx) : "=&b" (fault) : "c" (idx), "a" ((uint32_t)val), - "d" ((uint32_t)(val >> 32))); + "d" ((uint32_t)(val >> 32)) + : "memory"); return fault; } unsigned long stub_cpuid(void) { unsigned int fault = 0;