From patchwork Fri Nov 18 10:24:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olaf Hering X-Patchwork-Id: 9436179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D4EA560469 for ; Fri, 18 Nov 2016 10:27:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CE156286AB for ; Fri, 18 Nov 2016 10:27:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C2C762987B; Fri, 18 Nov 2016 10:27:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C26D0286AB for ; Fri, 18 Nov 2016 10:27:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7gMC-0002iN-Ht; Fri, 18 Nov 2016 10:25:20 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c7gMB-0002iH-Bi for xen-devel@lists.xensource.com; Fri, 18 Nov 2016 10:25:19 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id D1/2D-01948-E07DE285; Fri, 18 Nov 2016 10:25:18 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDLMWRWlGSWpSXmKPExsUSuHLSYl3e63o RBmcuclrcm/Ke3YHRY3vfLvYAxijWzLyk/IoE1ow1B7+xFcwSq9i/dzdTA2OzYBcjFweLwGMm iW3ffrF1MXJySAh4Ssz4P4O9i5EDyBaRePI/DaRGSOAhk8SGu11gNUICaRKb22aygNhsAkoSe w8eZwSxRQQkJa48nwtWwyywmEli3013kDnCAvYSp9e5gYRZBFQl1j5rYgEJ8woYSSxYWAixVV 5i4fkjTBMYeRYwMqxi1ChOLSpLLdI1NNVLKspMzyjJTczM0TU0MNXLTS0uTkxPzUlMKtZLzs/ dxAj0OQMQ7GBs2O55iFGSg0lJlNe7Xy9CiC8pP6UyI7E4I76oNCe1+BCjDAeHkgQv8zWgnGBR anpqRVpmDjD4YNISHDxKIrw8IGne4oLE3OLMdIjUKUZdjjuPPjxgEmLJy89LlRLnfXMVqEgAp CijNA9uBCwSLjHKSgnzMgIdJcRTkFqUm1mCKv+KUZyDUUmYlxNkFU9mXgncpldARzABHbFHQA fkiJJEhJRUA2M/+40JG4SNHP7Kz21mS7m3wyfk0FHz6bVFpubWd5/1223I3TXjA3tm4blT3La ybiK9rZb6fDqzE9MUzer7/ILzd298PO/8j7uStampz+YWd0uVbV/Bdker6fCUDxv/h624+2LX bWXGn5HBe7ZX/LlxW6XLqYOnY7+JZUFXsot70pOjBtxnjZVYijMSDbWYi4oTAS8QhVJ/AgAA X-Env-Sender: olaf@aepfle.de X-Msg-Ref: server-14.tower-206.messagelabs.com!1479464715!32120939!1 X-Originating-IP: [81.169.146.163] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 64498 invoked from network); 18 Nov 2016 10:25:15 -0000 Received: from mo4-p00-ob.smtp.rzone.de (HELO mo4-p00-ob.smtp.rzone.de) (81.169.146.163) by server-14.tower-206.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 18 Nov 2016 10:25:15 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1479464716; l=2596; s=domk; d=aepfle.de; h=Date:Subject:Cc:To:From; bh=8mj3OEseC6g6K0gt5jxYZZ5W8EJ6Y8MUB0msVKmLyQY=; b=lDDt3vtNrefSLEyK7KCI0kdSFfhj5uWNxzb8zg1iBK1eQuMnGWIY93ZVWvnillIBTH fKgX+jufnDSh5rU///2KzPuFTS7ECigJdxpp3JCNDSjma99cF1niaOo4mtvxrghiHnK1 IdlJoQ2mVWJC6N1mULy9lcPQIc2g+ouSf8Uao= X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+zrwiavkK6tmQaLfvzsjDHvnJrF4x7tmeNvA= X-RZG-CLASS-ID: mo00 Received: from probook (aftr-185-17-205-239.dynamic.mnet-online.de [185.17.205.239]) by smtp.strato.de (RZmta 39.9 DYNA|AUTH) with ESMTPSA id 4043c8sAIAP7g91 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 18 Nov 2016 11:25:07 +0100 (CET) Received: by probook (Postfix, from userid 1000) id 426BA50B58; Fri, 18 Nov 2016 11:25:07 +0100 (CET) From: Olaf Hering To: qemu-block@nongnu.org Date: Fri, 18 Nov 2016 10:24:52 +0000 Message-Id: <20161118102452.5779-1-olaf@aepfle.de> X-Mailer: git-send-email 2.10.2 Cc: Kevin Wolf , Olaf Hering , Stefano Stabellini , "open list:All patches CC here" , Max Reitz , "open list:X86" , Anthony Perard Subject: [Xen-devel] [PATCH] xen_disk: convert discard input to byte ranges X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The guest sends discard requests as u64 sector/count pairs, but the block layer operates internally with s64/s32 pairs. The conversion leads to IO errors in the guest, the discard request is not processed. domU.cfg: 'vdev=xvda, format=qcow2, backendtype=qdisk, target=/x.qcow2' domU: mkfs.ext4 -F /dev/xvda Discarding device blocks: failed - Input/output error Fix this by splitting the request into chunks of BDRV_REQUEST_MAX_SECTORS. Add input range checking to avoid overflow. Signed-off-by: Olaf Hering --- hw/block/xen_disk.c | 45 +++++++++++++++++++++++++++++++++++++++------ 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 3a7dc19..c3f572f 100644 --- a/hw/block/xen_disk.c +++ b/hw/block/xen_disk.c @@ -660,6 +660,41 @@ static void qemu_aio_complete(void *opaque, int ret) qemu_bh_schedule(ioreq->blkdev->bh); } +static bool blk_split_discard(struct ioreq *ioreq, blkif_sector_t sector_number, + uint64_t nr_sectors) +{ + struct XenBlkDev *blkdev = ioreq->blkdev; + int64_t byte_offset; + int byte_chunk; + uint64_t sec_start = sector_number; + uint64_t sec_count = nr_sectors; + uint64_t byte_remaining; + uint64_t limit = BDRV_REQUEST_MAX_SECTORS << BDRV_SECTOR_BITS; + + /* Wrap around? */ + if ((sec_start + sec_count) < sec_count) { + return false; + } + /* Overflowing byte limit? */ + if ((sec_start + sec_count) > ((INT64_MAX + INT_MAX) >> BDRV_SECTOR_BITS)) { + return false; + } + + byte_offset = sec_start << BDRV_SECTOR_BITS; + byte_remaining = sec_count << BDRV_SECTOR_BITS; + + do { + byte_chunk = byte_remaining > limit ? limit : byte_remaining; + ioreq->aio_inflight++; + blk_aio_pdiscard(blkdev->blk, byte_offset, byte_chunk, + qemu_aio_complete, ioreq); + byte_remaining -= byte_chunk; + byte_offset += byte_chunk; + } while (byte_remaining > 0); + + return true; +} + static int ioreq_runio_qemu_aio(struct ioreq *ioreq) { struct XenBlkDev *blkdev = ioreq->blkdev; @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) break; case BLKIF_OP_DISCARD: { - struct blkif_request_discard *discard_req = (void *)&ioreq->req; - ioreq->aio_inflight++; - blk_aio_pdiscard(blkdev->blk, - discard_req->sector_number << BDRV_SECTOR_BITS, - discard_req->nr_sectors << BDRV_SECTOR_BITS, - qemu_aio_complete, ioreq); + struct blkif_request_discard *req = (void *)&ioreq->req; + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) { + goto err; + } break; } default: