| Message ID | 20161123165639.3609-1-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Nov 23, 2016 at 04:56:39PM +0000, Roger Pau Monne wrote: > When PKG_INSTALLDIR was introduced the creation of the previous pkgconf install > directory was not changed. Fix this by correctly using PKG_INSTALLDIR for the > directory creation in libxl Makefile. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Acked + applied.
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile index f5053a0..ef01785 100644 --- a/tools/libxl/Makefile +++ b/tools/libxl/Makefile @@ -308,7 +308,7 @@ install: all $(INSTALL_DIR) $(DESTDIR)$(includedir) $(INSTALL_DIR) $(DESTDIR)$(BASH_COMPLETION_DIR) $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) - $(INSTALL_DIR) $(DESTDIR)$(SHAREDIR)/pkgconfig + $(INSTALL_DIR) $(DESTDIR)$(PKG_INSTALLDIR) $(INSTALL_PROG) xl $(DESTDIR)$(sbindir) $(INSTALL_PROG) libxl-save-helper $(DESTDIR)$(LIBEXEC_BIN) $(INSTALL_SHLIB) libxenlight.so.$(MAJOR).$(MINOR) $(DESTDIR)$(libdir)
When PKG_INSTALLDIR was introduced the creation of the previous pkgconf install directory was not changed. Fix this by correctly using PKG_INSTALLDIR for the directory creation in libxl Makefile. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- Not sure whether this should be considered for 4.8. IMHO, it's a harmless fix for Linux (where PKG_INSTALLDIR is already $(SHAREDIR)/pkgconfig), but it might be more important for FreeBSD. --- tools/libxl/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)