| Message ID | 20161202134851.57483-2-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/12/16 13:48, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > Cc: boris.ostrovsky@oracle.com > Cc: konrad.wilk@oracle.com > --- > tools/libacpi/acpi2_0.h | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h > index 775eb7a..5ddef8a 100644 > --- a/tools/libacpi/acpi2_0.h > +++ b/tools/libacpi/acpi2_0.h > @@ -227,9 +227,8 @@ struct acpi_20_fadt { > /* > * FADT Boot Architecture Flags. > */ > -#define ACPI_LEGACY_DEVICES (1 << 0) > -#define ACPI_8042 (1 << 1) > - > +#define ACPI_FADT_LEGACY_DEVICES (1 << 0) > +#define ACPI_FADT_8042 (1 << 1) It would be better to retain the newline here, Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> > /* > * FADT Fixed Feature Flags. > */
On Fri, Dec 02, 2016 at 01:53:44PM +0000, Andrew Cooper wrote: > On 02/12/16 13:48, Roger Pau Monne wrote: > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > Cc: Jan Beulich <jbeulich@suse.com> > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > Cc: Wei Liu <wei.liu2@citrix.com> > > Cc: boris.ostrovsky@oracle.com > > Cc: konrad.wilk@oracle.com > > --- > > tools/libacpi/acpi2_0.h | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h > > index 775eb7a..5ddef8a 100644 > > --- a/tools/libacpi/acpi2_0.h > > +++ b/tools/libacpi/acpi2_0.h > > @@ -227,9 +227,8 @@ struct acpi_20_fadt { > > /* > > * FADT Boot Architecture Flags. > > */ > > -#define ACPI_LEGACY_DEVICES (1 << 0) > > -#define ACPI_8042 (1 << 1) > > - > > +#define ACPI_FADT_LEGACY_DEVICES (1 << 0) > > +#define ACPI_FADT_8042 (1 << 1) > > It would be better to retain the newline here, Otherwise, Reviewed-by: > Andrew Cooper <andrew.cooper3@citrix.com> Right, I somehow managed to screw it. I've pushed a new version with the newline issue fixed, it's at: git://xenbits.xen.org/people/royger/xen.git libacpi_bootflags_v2 Sorry, Roger.
>>> On 02.12.16 at 14:48, <roger.pau@citrix.com> wrote: > --- a/tools/libacpi/acpi2_0.h > +++ b/tools/libacpi/acpi2_0.h > @@ -227,9 +227,8 @@ struct acpi_20_fadt { > /* > * FADT Boot Architecture Flags. > */ > -#define ACPI_LEGACY_DEVICES (1 << 0) > -#define ACPI_8042 (1 << 1) > - > +#define ACPI_FADT_LEGACY_DEVICES (1 << 0) > +#define ACPI_FADT_8042 (1 << 1) > /* > * FADT Fixed Feature Flags. > */ Afaict this breaks the build (until patch 3). Jan
diff --git a/tools/libacpi/acpi2_0.h b/tools/libacpi/acpi2_0.h index 775eb7a..5ddef8a 100644 --- a/tools/libacpi/acpi2_0.h +++ b/tools/libacpi/acpi2_0.h @@ -227,9 +227,8 @@ struct acpi_20_fadt { /* * FADT Boot Architecture Flags. */ -#define ACPI_LEGACY_DEVICES (1 << 0) -#define ACPI_8042 (1 << 1) - +#define ACPI_FADT_LEGACY_DEVICES (1 << 0) +#define ACPI_FADT_8042 (1 << 1) /* * FADT Fixed Feature Flags. */
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> Cc: boris.ostrovsky@oracle.com Cc: konrad.wilk@oracle.com --- tools/libacpi/acpi2_0.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)