From patchwork Tue Dec 13 13:58:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9472339 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1030960476 for ; Tue, 13 Dec 2016 14:01:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 029FE2851B for ; Tue, 13 Dec 2016 14:01:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EAF402851F; Tue, 13 Dec 2016 14:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8E2BA2851B for ; Tue, 13 Dec 2016 14:01:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGnbG-0003QN-JR; Tue, 13 Dec 2016 13:58:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGnbF-0003PY-C5 for xen-devel@lists.xenproject.org; Tue, 13 Dec 2016 13:58:33 +0000 Received: from [85.158.139.211] by server-3.bemta-5.messagelabs.com id 3E/5F-01948-88EFF485; Tue, 13 Dec 2016 13:58:32 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRWlGSWpSXmKPExsVyuP0Ov277P/8 Ig2+3rCy+b5nM5MDocfjDFZYAxijWzLyk/IoE1oze2XfZCh5wV3ROOMjcwHiZs4uRk0NCwEji 7cR/TF2MXBxCAgsZJWa1bGQHSbAJqEpsuH6KFcQWEVCSuLdqMhOIzSwQIfFy8UowW1jARWLFh DMsIDYLUP3HHyvBenkFTCQe/j/NDrFAXmLh+SNMExg5FzAyrGLUKE4tKkst0jU01UsqykzPKM lNzMzRNTQw1ctNLS5OTE/NSUwq1kvOz93ECPQXAxDsYGzY7nmIUZKDSUmU93O1f4QQX1J+SmV GYnFGfFFpTmrxIUYZDg4lCV63v0A5waLU9NSKtMwcYODApCU4eJREeItA0rzFBYm5xZnpEKlT jIpS4rzBIAkBkERGaR5cGyxYLzHKSgnzMgIdIsRTkFqUm1mCKv+KUZyDUUmYdz/IFJ7MvBK46 a+AFjMBLRZdAra4JBEhJdXAyPaZYY19iLjDpO6PPfK11mlHbqT/vitfNnF5hqBe4vbsG8w8DV r/TT1317oKONUsTeloC74iUXKT7dCM5KNOpiW5PTWztus/kImXzUg7/Sd93d4723gUrQSC3nw 4eyGqYH7Wh7kTzse2uuzdNIFvidvLls/BRR96WCyCX52w6rzPfCnixuHDSizFGYmGWsxFxYkA GHIzNlECAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1481637507!36363549!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7242 invoked from network); 13 Dec 2016 13:58:28 -0000 Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by server-14.tower-206.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 13 Dec 2016 13:58:28 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id CB1F4ADE7; Tue, 13 Dec 2016 13:58:30 +0000 (UTC) From: Juergen Gross To: xen-devel@lists.xenproject.org Date: Tue, 13 Dec 2016 14:58:27 +0100 Message-Id: <20161213135827.31212-1-jgross@suse.com> X-Mailer: git-send-email 2.10.2 Cc: Juergen Gross , samuel.thibault@ens-lyon.org, wei.liu2@citrix.com Subject: [Xen-devel] [PATCH v2] stubdom: modify ioemu linkfarm only if necessary X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Several stubdom libraries are being rebuilt each time a top level make is called as they depend on stubdom/ioemu/linkfarm.stamp which is depending on tools/qemu-xen-traditional-dir. Unfortunately this directory is modified by each "make tools" call. This can be avoided by writing stubdom/ioemu/linkfarm.stamp only if a source file beneath tools/qemu-xen-traditional-dir has been added or removed. Signed-off-by: Juergen Gross Acked-by: Wei Liu --- V2: maintain a list of the to be linked files in linkfarm.stamp and rebuild this list at each make call for detecting any change Signed-off-by: Juergen Gross --- stubdom/Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/stubdom/Makefile b/stubdom/Makefile index bc49cfe..38f1688 100644 --- a/stubdom/Makefile +++ b/stubdom/Makefile @@ -298,9 +298,13 @@ ioemu/linkfarm.stamp: $(XEN_ROOT)/tools/qemu-xen-traditional-dir (cd $$src && find * ! -type l -type f $(addprefix ! -name , \ '*.[oda1]' 'config-*' config.mak qemu-dm qemu-img-xen \ '*.html' '*.pod' \ - )) | \ - while read f; do rm -f "$$f"; ln -s "$$src/$$f" "$$f"; done - touch ioemu/linkfarm.stamp + )) >linkfarm.stamp.tmp; \ + cmp linkfarm.stamp.tmp linkfarm.stamp 2>/dev/null && \ + rm linkfarm.stamp.tmp || { \ + mv linkfarm.stamp.tmp linkfarm.stamp; \ + cat linkfarm.stamp | while read f; \ + do rm -f "$$f"; ln -s "$$src/$$f" "$$f"; done; \ + } else export QEMU_ROOT