| Message ID | 20161219150204.4481-3-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Dec 19, 2016 at 03:02:02PM +0000, Roger Pau Monne wrote: > ...because it's empty. While there also rename xendriverdomain_startcmd to > xendriverdomain_start in order to match the nomenclature of the file. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > --- > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> > --- > tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > index 3917de2..c71871c 100644 > --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > @@ -13,19 +13,13 @@ LD_LIBRARY_PATH="${libdir}" > export LD_LIBRARY_PATH > > name="xendriverdomain" > -start_precmd="xendriverdomain_precmd" > start_cmd="xendriverdomain_startcmd" ^^^^^^^^ You missed this. otherwise: Acked-by: Wei Liu <wei.liu2@citrix.com> > stop_cmd="xendriverdomain_stop" > extra_commands="" > > XLDEVD_PIDFILE="@XEN_RUN_DIR@/xldevd.pid" > > -xendriverdomain_precmd() > -{ > - : > -} > - > -xendriverdomain_startcmd() > +xendriverdomain_start() > { > printf "Starting xenservices: xl devd." > > -- > 2.10.1 (Apple Git-78) >
On Wed, Dec 21, 2016 at 11:48:40AM +0000, Wei Liu wrote: > On Mon, Dec 19, 2016 at 03:02:02PM +0000, Roger Pau Monne wrote: > > ...because it's empty. While there also rename xendriverdomain_startcmd to > > xendriverdomain_start in order to match the nomenclature of the file. > > > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > > --- > > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > > Cc: Wei Liu <wei.liu2@citrix.com> > > --- > > tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > > index 3917de2..c71871c 100644 > > --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > > +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in > > @@ -13,19 +13,13 @@ LD_LIBRARY_PATH="${libdir}" > > export LD_LIBRARY_PATH > > > > name="xendriverdomain" > > -start_precmd="xendriverdomain_precmd" > > start_cmd="xendriverdomain_startcmd" > ^^^^^^^^ > You missed this. > > otherwise: > > Acked-by: Wei Liu <wei.liu2@citrix.com> Would you like to fix this while committing, or should I push the updated series to a git branch? Thanks, Roger.
diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in index 3917de2..c71871c 100644 --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in @@ -13,19 +13,13 @@ LD_LIBRARY_PATH="${libdir}" export LD_LIBRARY_PATH name="xendriverdomain" -start_precmd="xendriverdomain_precmd" start_cmd="xendriverdomain_startcmd" stop_cmd="xendriverdomain_stop" extra_commands="" XLDEVD_PIDFILE="@XEN_RUN_DIR@/xldevd.pid" -xendriverdomain_precmd() -{ - : -} - -xendriverdomain_startcmd() +xendriverdomain_start() { printf "Starting xenservices: xl devd."
...because it's empty. While there also rename xendriverdomain_startcmd to xendriverdomain_start in order to match the nomenclature of the file. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)