diff mbox

[3/4] init/FreeBSD: fix xencommons so it can only be launched by Dom0

Message ID 20161219150204.4481-4-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monne Dec. 19, 2016, 3:02 p.m. UTC
At the moment the execution of xencommons is gated on the presence of the
privcmd device, but that's not correct, since privcmd is available to all Xen
domains (privileged or unprivileged). Instead of using privcmd use the
xenstored device, which will only be available to the domain that's in charge
of running xenstored, and thus xencommons.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu Dec. 21, 2016, 11:48 a.m. UTC | #1
On Mon, Dec 19, 2016 at 03:02:03PM +0000, Roger Pau Monne wrote:
> At the moment the execution of xencommons is gated on the presence of the
> privcmd device, but that's not correct, since privcmd is available to all Xen
> domains (privileged or unprivileged). Instead of using privcmd use the
> xenstored device, which will only be available to the domain that's in charge
> of running xenstored, and thus xencommons.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>
diff mbox

Patch

diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
index efa8801..81f69f3 100644
--- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
+++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
@@ -16,7 +16,7 @@  start_cmd="xen_startcmd"
 stop_cmd="xen_stop"
 status_cmd="xen_status"
 extra_commands="status"
-required_files="/dev/xen/privcmd"
+required_files="/dev/xen/xenstored"
 
 XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"