From patchwork Mon Jan 30 18:31:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 9545871 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B0A0660415 for ; Mon, 30 Jan 2017 18:32:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A770727F82 for ; Mon, 30 Jan 2017 18:32:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9C2B0281C3; Mon, 30 Jan 2017 18:32:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2AFBD27F82 for ; Mon, 30 Jan 2017 18:32:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYGjI-0008FZ-T2; Mon, 30 Jan 2017 18:31:04 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cYGjH-0008B0-B7 for xen-devel@lists.xenproject.org; Mon, 30 Jan 2017 18:31:03 +0000 Received: from [85.158.143.35] by server-6.bemta-6.messagelabs.com id E5/EA-15112-6668F885; Mon, 30 Jan 2017 18:31:02 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRWlGSWpSXmKPExsVysyfVTTe1rT/ CYNJWG4vvWyYzOTB6HP5whSWAMYo1My8pvyKBNePYgwesBS8NKvZPnczWwPhItYuRi0NIYDOj xM8Zv1ggnOWMEtseLGXtYuTkYBPQldhx8zUziC0iECox5+cjIJuDg1nAS+LLe2+QsLCAmcTMu a+YQMIsAqoSpx+VgoR5BWwkGhcuBuuUEJCTaDh/H8zmBIrP3vybCcQWErCW+NeznHECI/cCRo ZVjOrFqUVlqUW6FnpJRZnpGSW5iZk5uoYGZnq5qcXFiempOYlJxXrJ+bmbGIG+ZQCCHYyzL/s fYpTkYFIS5e372BchxJeUn1KZkVicEV9UmpNafIhRhoNDSYK3q7U/QkiwKDU9tSItMwcYZDBp CQ4eJRHeVJA0b3FBYm5xZjpE6hSjopQ4bx5IQgAkkVGaB9cGC+xLjLJSwryMQIcI8RSkFuVml qDKv2IU52BUEub1A5nCk5lXAjf9FdBiJqDF7q/6QBaXJCKkpBoYk7xvvbe5vFC7cGvHaYEJl/ 5pKEdNWTTHuCz2kfJB/XMX3ez/6X9t31IUmOns6FhQc/KHyrPD0VeDclLKlx7YOHfighULVl2 W2so0b1JMkqLO5jrbVcmMog07Yt6vrOD7khH+N5Sps93gu6vmxJV2irGHI+byF8Z5bwqb2CGx KeULZ1ju8pVSSizFGYmGWsxFxYkAxTtnh2cCAAA= X-Env-Sender: andre.przywara@arm.com X-Msg-Ref: server-3.tower-21.messagelabs.com!1485801061!54636576!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10918 invoked from network); 30 Jan 2017 18:31:01 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-3.tower-21.messagelabs.com with SMTP; 30 Jan 2017 18:31:01 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 249B414F6; Mon, 30 Jan 2017 10:31:01 -0800 (PST) Received: from e104803-lin.lan (unknown [10.1.207.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 43AC53F24D; Mon, 30 Jan 2017 10:31:00 -0800 (PST) From: Andre Przywara To: Stefano Stabellini , Julien Grall Date: Mon, 30 Jan 2017 18:31:46 +0000 Message-Id: <20170130183153.28566-22-andre.przywara@arm.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170130183153.28566-1-andre.przywara@arm.com> References: <20170130183153.28566-1-andre.przywara@arm.com> Cc: xen-devel@lists.xenproject.org, Vijay Kilari Subject: [Xen-devel] [PATCH 21/28] ARM: vITS: handle MAPTI command X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The MAPTI commands associates a DeviceID/EventID pair with a LPI/CPU pair and actually instantiates LPI interrupts. We connect the already allocated host LPI to this virtual LPI, so that any triggering IRQ on the host can be quickly forwarded to a guest. Signed-off-by: Andre Przywara --- xen/arch/arm/gic-v3-its.c | 58 ++++++++++++++++++++++++++++++++++++++++ xen/arch/arm/gic-v3-lpi.c | 18 +++++++++++++ xen/arch/arm/vgic-v3-its.c | 27 +++++++++++++++++-- xen/include/asm-arm/gic_v3_its.h | 5 ++++ 4 files changed, 106 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 2a7093f..1268d64 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c @@ -632,6 +632,64 @@ int gicv3_its_unmap_device(struct domain *d, int guest_devid) return -ENOENT; } +/* + * Translates an event for a given guest device ID into the associated host + * LPI number. This can be used to look up the mapped guest LPI. + */ +static uint32_t translate_event(struct domain *d, + uint32_t devid, uint32_t eventid) +{ + struct rb_node *node; + struct its_devices *dev; + uint32_t host_lpi = 0; + + spin_lock(&d->arch.vgic.its_devices_lock); + node = d->arch.vgic.its_devices.rb_node; + while (node) + { + dev = rb_entry(node, struct its_devices, rbnode); + if ( dev->guest_devid == devid ) + { + if ( eventid >= dev->eventids ) + goto out; + + host_lpi = dev->host_lpis[eventid / 32] + (eventid % 32); + if ( !is_lpi(host_lpi) ) + host_lpi = 0; + goto out; + } + + if ( devid < dev->guest_devid ) + node = node->rb_left; + else + node = node->rb_right; + } + +out: + spin_unlock(&d->arch.vgic.its_devices_lock); + + return host_lpi; +} + +/* + * Connects the event ID for an already assigned device to the given VCPU/vLPI + * pair. The corresponding physical LPI is already mapped on the host side + * (when assigning the physical device to the guest), so we just connect the + * target VCPU/vLPI pair to that interrupt to inject it properly if it fires. + */ +int gicv3_assign_guest_event(struct domain *d, uint32_t devid, uint32_t eventid, + struct vcpu *v, uint32_t virt_lpi) +{ + uint32_t host_lpi = translate_event(d, devid, eventid); + + if ( !host_lpi ) + return -ENOENT; + + gicv3_lpi_update_host_entry(host_lpi, d->domain_id, v->vcpu_id, virt_lpi); + + return 0; +} + /* Scan the DT for any ITS nodes and create a list of host ITSes out of it. */ void gicv3_its_dt_init(const struct dt_device_node *node) { diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c index ade8b69..494ae22 100644 --- a/xen/arch/arm/gic-v3-lpi.c +++ b/xen/arch/arm/gic-v3-lpi.c @@ -135,6 +135,24 @@ void do_LPI(unsigned int lpi) vgic_vcpu_inject_irq(vcpu, hlpi.virt_lpi); } +int gicv3_lpi_update_host_entry(uint32_t host_lpi, int domain_id, int vcpu_id, + uint32_t virt_lpi) +{ + union host_lpi *hlpip, hlpi; + + host_lpi -= LPI_OFFSET; + + hlpip = &lpi_data.host_lpis[host_lpi / HOST_LPIS_PER_PAGE][host_lpi % HOST_LPIS_PER_PAGE]; + + hlpi.virt_lpi = virt_lpi; + hlpi.dom_id = domain_id; + hlpi.vcpu_id = vcpu_id; + + write_u64_atomic(&hlpip->data, hlpi.data); + + return 0; +} + uint64_t gicv3_lpi_allocate_pendtable(void) { uint64_t reg; diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c index 5be40d8..3e74f46 100644 --- a/xen/arch/arm/vgic-v3-its.c +++ b/xen/arch/arm/vgic-v3-its.c @@ -164,8 +164,8 @@ static bool read_itte(struct virt_its *its, uint32_t devid, uint32_t evid, } #define SKIP_LPI_UPDATE 1 -bool write_itte(struct virt_its *its, uint32_t devid, uint32_t evid, - uint32_t collid, uint32_t vlpi, struct vcpu **vcpu) +static bool write_itte(struct virt_its *its, uint32_t devid, uint32_t evid, + uint32_t collid, uint32_t vlpi, struct vcpu **vcpu) { struct vits_itte *itte; @@ -310,6 +310,25 @@ static int its_handle_mapd(struct virt_its *its, uint64_t *cmdptr) return 0; } +static int its_handle_mapti(struct virt_its *its, uint64_t *cmdptr) +{ + uint32_t devid = its_cmd_get_deviceid(cmdptr); + uint32_t eventid = its_cmd_get_id(cmdptr); + uint32_t intid = its_cmd_get_physical_id(cmdptr); + int collid = its_cmd_get_collection(cmdptr); + struct vcpu *vcpu; + + if ( its_cmd_get_command(cmdptr) == GITS_CMD_MAPI ) + intid = eventid; + + if ( !write_itte(its, devid, eventid, collid, intid, &vcpu) ) + return -1; + + gicv3_assign_guest_event(its->d, devid, eventid, vcpu, intid); + + return 0; +} + #define ITS_CMD_BUFFER_SIZE(baser) ((((baser) & 0xff) + 1) << 12) static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, @@ -342,6 +361,10 @@ static int vgic_its_handle_cmds(struct domain *d, struct virt_its *its, case GITS_CMD_MAPD: its_handle_mapd(its, cmdptr); break; + case GITS_CMD_MAPI: + case GITS_CMD_MAPTI: + its_handle_mapti(its, cmdptr); + break; case GITS_CMD_SYNC: /* We handle ITS commands synchronously, so we ignore SYNC. */ break; diff --git a/xen/include/asm-arm/gic_v3_its.h b/xen/include/asm-arm/gic_v3_its.h index 0e6b06a..160ece3 100644 --- a/xen/include/asm-arm/gic_v3_its.h +++ b/xen/include/asm-arm/gic_v3_its.h @@ -159,6 +159,11 @@ int gicv3_allocate_host_lpi_block(struct host_its *its, struct domain *d, uint32_t host_devid, uint32_t eventid); int gicv3_free_host_lpi_block(struct host_its *its, uint32_t lpi); +int gicv3_assign_guest_event(struct domain *d, + uint32_t devid, uint32_t eventid, + struct vcpu *v, uint32_t virt_lpi); +int gicv3_lpi_update_host_entry(uint32_t host_lpi, int domain_id, int vcpu_id, + uint32_t virt_lpi); #else static inline void gicv3_its_dt_init(const struct dt_device_node *node)