diff mbox

[v2,03/12] x86: extract vendor numeric id to x86-vendors.h

Message ID 20170131110809.30001-4-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Jan. 31, 2017, 11:08 a.m. UTC
They will be shared between xen and userspace programs.

No functional change.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/include/asm-x86/processor.h | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Jan Beulich Jan. 31, 2017, 12:48 p.m. UTC | #1
>>> On 31.01.17 at 12:08, <wei.liu2@citrix.com> wrote:
> They will be shared between xen and userspace programs.

Please clarify here that this is not strictly necessary, but rather just
a convenience / reduction of overall code size. Otherwise someone
looking back in a couple of years may wonder where the hidden
dependency is for values to be identical between hypervisor and
user space testing code.

> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

With the above clarification in place,
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
diff mbox

Patch

diff --git a/xen/include/asm-x86/processor.h b/xen/include/asm-x86/processor.h
index ff0e51f3d5..be2ff71c72 100644
--- a/xen/include/asm-x86/processor.h
+++ b/xen/include/asm-x86/processor.h
@@ -17,15 +17,7 @@ 
 #endif
 
 #include "x86-defns.h"
-
-/*
- * CPU vendor IDs
- */
-#define X86_VENDOR_INTEL 0
-#define X86_VENDOR_AMD 1
-#define X86_VENDOR_CENTAUR 2
-#define X86_VENDOR_NUM 3
-#define X86_VENDOR_UNKNOWN 0xff
+#include "x86-vendors.h"
 
 
 /* Set for entry via SYSCALL. Informs return code to use SYSRETQ not IRETQ. */