From patchwork Tue Feb 7 11:02:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 9559673 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8BCBC60236 for ; Tue, 7 Feb 2017 11:05:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A06E283D3 for ; Tue, 7 Feb 2017 11:05:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6D0A2283E0; Tue, 7 Feb 2017 11:05:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D79AF283D3 for ; Tue, 7 Feb 2017 11:05:12 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb3Xr-0001yq-Av; Tue, 07 Feb 2017 11:02:47 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cb3Xp-0001yk-E7 for xen-devel@lists.xenproject.org; Tue, 07 Feb 2017 11:02:45 +0000 Received: from [85.158.143.35] by server-3.bemta-6.messagelabs.com id 37/0A-22349-459A9985; Tue, 07 Feb 2017 11:02:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRWlGSWpSXmKPExsXitHSDvW7Iypk RBv93iVl83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBmLdh9jLHjNVnGh/y9TA+Mr1i5GTg4JAX+J H0u+s4DYbALKEj87e9lAbBEBPYmmA88ZQWxmgTyJs6sXAdVzcAgLeElcPmIAEmYRUJH49XIZ2 BheAQuJt5/2MEGMlJfY1XYRLC4koCDRMf0YE0SNoMTJmU9YIEZKSBx88YJ5AiP3LCSpWUhSCx iZVjGqF6cWlaUW6ZrrJRVlpmeU5CZm5ugaGpjp5aYWFyemp+YkJhXrJefnbmIEBgIDEOxgnHn Z/xCjJAeTkihv6dyZEUJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeJevAMoJFqWmp1akZeYAQxIm LcHBoyTCux8kzVtckJhbnJkOkTrFqMtx6tOFl0xCLHn5ealS4rzzQYoEQIoySvPgRsDi4xKjr JQwLyPQUUI8BalFuZklqPKvGMU5GJWEeZeCTOHJzCuB2/QK6AgmoCO2XZkGckRJIkJKqoExd7 PXraU7vFdc/Koy43RcymXGa8sO8mXvPSfIZ2u79gDn9XIbP94T374f1crIv7M+ya/wRb77uXf M32Rm/Lmt+0yi4N+ZP8WWy9YceqUk718ZeLOJ3+Vr5Hvv8ENty83zyq2q1niFXDz9OPlg9tV9 a//edOuY/NdhadgOF0WjSTLpykcnZJ09o8RSnJFoqMVcVJwIAMzyLOCKAgAA X-Env-Sender: prvs=204953962=wei.liu2@citrix.com X-Msg-Ref: server-7.tower-21.messagelabs.com!1486465362!56516333!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 47609 invoked from network); 7 Feb 2017 11:02:44 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 7 Feb 2017 11:02:44 -0000 X-IronPort-AV: E=Sophos;i="5.33,346,1477958400"; d="scan'208";a="413874412" From: Wei Liu To: Xen-devel Date: Tue, 7 Feb 2017 11:02:40 +0000 Message-ID: <20170207110240.18478-1-wei.liu2@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Cc: Andrew Cooper , Wei Liu , Jan Beulich Subject: [Xen-devel] [PATCH] fuzz/x86emul: remove bogus check against fuzzer msr index X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The "reg" variable in fuzz_read_msr stores the real MSR index, not an index within the fuzzer. The rest of that function already handles things correctly. We just need to remove the bogus check. Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c b/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c index 3b6d33aa25..4a2bdbe392 100644 --- a/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c +++ b/tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c @@ -347,9 +347,6 @@ static int fuzz_read_msr( { unsigned int idx; - if ( reg >= MSR_INDEX_MAX ) - return X86EMUL_UNHANDLEABLE; - switch ( reg ) { case MSR_TSC_AUX: