diff mbox

x86/iommu: add missing break

Message ID 20170209175328.69515-1-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monne Feb. 9, 2017, 5:53 p.m. UTC 
50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
adding IOMMU entries for p2m_mmio_direct regions.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
---
 xen/include/asm-x86/p2m.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Roger Pau Monne Feb. 9, 2017, 5:55 p.m. UTC | #1 
Ccing the maintainers...

On Thu, Feb 09, 2017 at 05:53:28PM +0000, Roger Pau Monne wrote:
> 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
> adding IOMMU entries for p2m_mmio_direct regions.
> 
> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> ---
>  xen/include/asm-x86/p2m.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
> index 173a6f8..c68ff58 100644
> --- a/xen/include/asm-x86/p2m.h
> +++ b/xen/include/asm-x86/p2m.h
> @@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn)
>          flags = IOMMUF_readable;
>          if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
>              flags |= IOMMUF_writable;
> +        break;
>      default:
>          flags = 0;
>          break;
> -- 
> 2.10.1 (Apple Git-78)
>
Andrew Cooper Feb. 9, 2017, 5:56 p.m. UTC | #2 
On 09/02/17 17:55, Roger Pau Monne wrote:
> Ccing the maintainers...
>
> On Thu, Feb 09, 2017 at 05:53:28PM +0000, Roger Pau Monne wrote:
>> 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not
>> adding IOMMU entries for p2m_mmio_direct regions.

Spotted by Coverity

>>
>> Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 173a6f8..c68ff58 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -819,6 +819,7 @@  static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn)
         flags = IOMMUF_readable;
         if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) )
             flags |= IOMMUF_writable;
+        break;
     default:
         flags = 0;
         break;