From patchwork Thu Feb 9 17:53:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9565305 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2DAFF601C3 for ; Thu, 9 Feb 2017 17:55:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E5DD28545 for ; Thu, 9 Feb 2017 17:55:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 12CAE28547; Thu, 9 Feb 2017 17:55:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B8C0428545 for ; Thu, 9 Feb 2017 17:55:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbsuV-0003cZ-21; Thu, 09 Feb 2017 17:53:35 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cbsuT-0003cT-VK for xen-devel@lists.xenproject.org; Thu, 09 Feb 2017 17:53:34 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id 0B/BF-29440-D9CAC985; Thu, 09 Feb 2017 17:53:33 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeJIrShJLcpLzFFi42JxWrrBXnfOmjk RBtOm6Vp83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBlf1q9kKljJVnH3UAtjA+ME1i5GTg4JAX+J w42zmUBsNgEdiYtzd7J1MXJwiAioSNzeawBiMgtoSSxZKQVSISygK3FizltGEJsFqGLvtslgn bwClhLTb69ig5ioJ7HryG9WiLigxMmZT1hAbGYBTYnW7b/ZIWx5ieats5lBbCEBRYn+eQ/YJj DyzELSMgtJyywkLQsYmVcxahSnFpWlFukaGuolFWWmZ5TkJmbm6BoamOnlphYXJ6an5iQmFes l5+duYgQGDgMQ7GD8tCzgEKMkB5OSKK9swZwIIb6k/JTKjMTijPii0pzU4kOMMhwcShK8CquB coJFqempFWmZOcAQhklLcPAoifD2gKR5iwsSc4sz0yFSpxh1OU59uvCSSYglLz8vVUqcVw6kS ACkKKM0D24ELJ4uMcpKCfMyAh0lxFOQWpSbWYIq/4pRnINRSZh3A8gUnsy8ErhNr4COYAI64v rpWSBHlCQipKQaGGPvCfHnNyW82JATLi6a27RvQRJDmMd1z3Uagi4CC91eHU76Miv7qpqh5tX n03ac+W9XzKLLG7dEeuGGV5WTH0ufYy+zvmL7vudtSNDSS0ftNr8xXltnvbZad+Xms36L4zK/ m7AtWHpcKcF6ycz3jd+aF0TmnkwweRd++ELaFJ8ul8+vGM0evVFiKc5INNRiLipOBAC08wMeo gIAAA== X-Env-Sender: prvs=206367711=roger.pau@citrix.com X-Msg-Ref: server-7.tower-27.messagelabs.com!1486662811!81680247!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39623 invoked from network); 9 Feb 2017 17:53:32 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-7.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 9 Feb 2017 17:53:32 -0000 X-IronPort-AV: E=Sophos;i="5.35,137,1484006400"; d="scan'208";a="414718320" From: Roger Pau Monne To: Date: Thu, 9 Feb 2017 17:53:28 +0000 Message-ID: <20170209175328.69515-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.10.1 (Apple Git-78) MIME-Version: 1.0 Cc: Roger Pau Monne Subject: [Xen-devel] [PATCH] x86/iommu: add missing break X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP 50a498 failed to add a break in the p2m_mmio_direct case, so Xen was still not adding IOMMU entries for p2m_mmio_direct regions. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper --- --- xen/include/asm-x86/p2m.h | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h index 173a6f8..c68ff58 100644 --- a/xen/include/asm-x86/p2m.h +++ b/xen/include/asm-x86/p2m.h @@ -819,6 +819,7 @@ static inline unsigned int p2m_get_iommu_flags(p2m_type_t p2mt, mfn_t mfn) flags = IOMMUF_readable; if ( !rangeset_contains_singleton(mmio_ro_ranges, mfn_x(mfn)) ) flags |= IOMMUF_writable; + break; default: flags = 0; break;