From patchwork Tue Feb 14 12:30:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9571831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5AEFB60578 for ; Tue, 14 Feb 2017 12:33:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4A6B228394 for ; Tue, 14 Feb 2017 12:33:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3E9D9283F6; Tue, 14 Feb 2017 12:33:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A2D3628394 for ; Tue, 14 Feb 2017 12:33:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdcGF-0008GW-W3; Tue, 14 Feb 2017 12:31:11 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdcGE-0008Fd-9O for xen-devel@lists.xenproject.org; Tue, 14 Feb 2017 12:31:10 +0000 Received: from [85.158.139.211] by server-10.bemta-5.messagelabs.com id DB/45-01703-D88F2A85; Tue, 14 Feb 2017 12:31:09 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRWlGSWpSXmKPExsXitHSDvW7Pj0U RBtduWll83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBkXp0xjKpgqUtG/6iNbA+MK/i5GTg4JAX+J D4f+MoLYbAI6Ehfn7mTrYuTgEBFQkbi916CLkYuDWeA5k8T7CQ3MIHFhAVuJ10siQUwWAVWJ3 bsjQDp5BSwl5k+exQgxUU9i15HfrCA2p4CVxMQFj8BsIaCaR/8fMkPUC0qcnPmEBcRmFtCUaN 3+mx3Clpdo3jqbGaJeUaJ/3gO2CYx8s5C0zELSMgtJywJG5lWMGsWpRWWpRbpGJnpJRZnpGSW 5iZk5uoYGpnq5qcXFiempOYlJxXrJ+bmbGIGBVs/AwLiD8eZkv0OMkhxMSqK8sZsWRgjxJeWn VGYkFmfEF5XmpBYfYpTh4FCS4PX/vihCSLAoNT21Ii0zBxjyMGkJDh4lEd4z34DSvMUFibnFm ekQqVOMilLivJIgfQIgiYzSPLg2WJxdYpSVEuZlZGBgEOIpSC3KzSxBlX/FKM7BqCTMKw4yhS czrwRu+iugxUxAi1njFoIsLklESEk1ME6qW2zUvf1YcPAia9a7yw7fXBX8rb1401dB9cnLH6+ c+mSCc2f1/AXzxU1/Oh9I5WR8/Nur6++vN0Hc6o+Un70++Wvi16LvC/kmnmX8IKVmpHSsxU4r M9nijUzSml/pWTKFqmt0zvrqq+Wui7k40X+VrN3+C1wqe6I+yrntzWwLPiK/R/+66kwlluKMR EMt5qLiRADWi5QyrgIAAA== X-Env-Sender: prvs=211416eb8=roger.pau@citrix.com X-Msg-Ref: server-6.tower-206.messagelabs.com!1487075465!84628136!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 61942 invoked from network); 14 Feb 2017 12:31:08 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 14 Feb 2017 12:31:08 -0000 X-IronPort-AV: E=Sophos;i="5.35,161,1484006400"; d="scan'208";a="415705125" From: Roger Pau Monne To: Date: Tue, 14 Feb 2017 12:30:57 +0000 Message-ID: <20170214123057.92544-5-roger.pau@citrix.com> X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <20170214123057.92544-1-roger.pau@citrix.com> References: <20170214123057.92544-1-roger.pau@citrix.com> MIME-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Jan Beulich , Roger Pau Monne Subject: [Xen-devel] [PATCH v4 4/4] build: enable no-parentheses in clang X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP And fix the following errors reported: traps.c:2014:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~ traps.c:2014:25: note: remove extraneous parentheses around the comparison to silence this warning else if ( (port == RTC_PORT(0)) ) ~ ^ ~ traps.c:2014:25: note: use '=' to turn this equality comparison into an assignment else if ( (port == RTC_PORT(0)) ) ^~ = traps.c:2083:25: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] else if ( (port == RTC_PORT(0)) ) ~~~~~^~~~~~~~~~~~~~ Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Wei Liu --- Config.mk | 3 --- xen/arch/x86/traps.c | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/Config.mk b/Config.mk index bff4dc5..9a28d15 100644 --- a/Config.mk +++ b/Config.mk @@ -212,9 +212,6 @@ CFLAGS += -std=gnu99 CFLAGS += -Wall -Wstrict-prototypes -# Clang complains about macros that expand to 'if ( ( foo == bar ) ) ...' -CFLAGS-$(clang) += -Wno-parentheses - $(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement) $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 691c9a2..eb634d9 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -2011,7 +2011,7 @@ uint32_t guest_io_read(unsigned int port, unsigned int bytes, { sub_data = pv_pit_handler(port, 0, 0); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { sub_data = currd->arch.cmos_idx; } @@ -2080,7 +2080,7 @@ void guest_io_write(unsigned int port, unsigned int bytes, uint32_t data, { pv_pit_handler(port, (uint8_t)data, 1); } - else if ( (port == RTC_PORT(0)) ) + else if ( port == RTC_PORT(0) ) { currd->arch.cmos_idx = data; }