diff mbox

[v3,1/7] xenstore: correct test for opened logfile in reopen_log()

Message ID 20170222152851.20099-2-jgross@suse.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jürgen Groß Feb. 22, 2017, 3:28 p.m. UTC 
As 0 is a valid file descriptor testing a descriptor to be valid
should be done via >= 0 instead of > 0.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 tools/xenstore/xenstored_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wei Liu Feb. 23, 2017, 10:36 a.m. UTC | #1 
On Wed, Feb 22, 2017 at 04:28:45PM +0100, Juergen Gross wrote:
> As 0 is a valid file descriptor testing a descriptor to be valid
> should be done via >= 0 instead of > 0.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---

Acked-by: Wei Liu <wei.liu2@citrix.com>

Ian, this should be backported.

>  tools/xenstore/xenstored_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
> index 1e9b622..7b16338 100644
> --- a/tools/xenstore/xenstored_core.c
> +++ b/tools/xenstore/xenstored_core.c
> @@ -209,7 +209,7 @@ static void trigger_reopen_log(int signal __attribute__((unused)))
>  static void reopen_log(void)
>  {
>  	if (tracefile) {
> -		if (tracefd > 0)
> +		if (tracefd >= 0)
>  			close(tracefd);
>  
>  		tracefd = open(tracefile, O_WRONLY|O_CREAT|O_APPEND, 0600);
> -- 
> 2.10.2
>
diff mbox

Patch

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index 1e9b622..7b16338 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -209,7 +209,7 @@  static void trigger_reopen_log(int signal __attribute__((unused)))
 static void reopen_log(void)
 {
 	if (tracefile) {
-		if (tracefd > 0)
+		if (tracefd >= 0)
 			close(tracefd);
 
 		tracefd = open(tracefile, O_WRONLY|O_CREAT|O_APPEND, 0600);