| Message ID | 20170223115217.32764-5-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 23.02.17 at 12:52, <roger.pau@citrix.com> wrote: > So that the function can be called from other files without adding prototypes > to each of them. If you plan to add more callers, this is the time to name the function properly (an apic_ prefix rather suggests the LAPIC) and to convert its parameter to unsigned int. Jan
diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index 24ee431..77572fc 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2274,8 +2274,6 @@ static int ioapic_physbase_to_id(unsigned long physbase) return -EINVAL; } -unsigned apic_gsi_base(int apic); - static int apic_pin_2_gsi_irq(int apic, int pin) { int idx; diff --git a/xen/include/asm-x86/io_apic.h b/xen/include/asm-x86/io_apic.h index 225edd6..411fa3f 100644 --- a/xen/include/asm-x86/io_apic.h +++ b/xen/include/asm-x86/io_apic.h @@ -127,6 +127,9 @@ struct __packed IO_APIC_route_entry { /* I/O APIC entries */ extern struct mpc_config_ioapic mp_ioapics[MAX_IO_APICS]; +/* Base GSI for this IO APIC */ +unsigned apic_gsi_base(int apic); + /* Only need to remap ioapic RTE (reg: 10~3Fh) */ #define ioapic_reg_remapped(reg) (iommu_intremap && ((reg) >= 0x10))
So that the function can be called from other files without adding prototypes to each of them. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> --- xen/arch/x86/io_apic.c | 2 -- xen/include/asm-x86/io_apic.h | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-)