From patchwork Thu Feb 23 15:18:20 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 9588449 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3227B60578 for ; Thu, 23 Feb 2017 15:33:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 22DEF2891B for ; Thu, 23 Feb 2017 15:33:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17B332891D; Thu, 23 Feb 2017 15:33:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B700E2891B for ; Thu, 23 Feb 2017 15:33:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgvM2-0005Ej-H4; Thu, 23 Feb 2017 15:30:50 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cgvM1-0005Eb-Ek for xen-devel@lists.xenproject.org; Thu, 23 Feb 2017 15:30:49 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id ED/2C-01711-8200FA85; Thu, 23 Feb 2017 15:30:48 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRWlGSWpSXmKPExsXitHSDva4Gw/o Ig9YlXBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bEZy1sBX9ZK5ben8bcwNjN2sXIwSEh4C/x rsuwi5GTg01AWeJnZy8biC0ioCfRdOA5I4jNLFAs0XP/EguILSzgK9F75yGYzSKgKnGpdQEzi M0rYCFxaO9eVhBbQkBeYlfbRTBbSEBBomP6MSaIGkGJkzOfsEDMlJA4+OIF8wRG7llIUrOQpB YwMq1i1ChOLSpLLdI1NNNLKspMzyjJTczM0TU0MNXLTS0uTkxPzUlMKtZLzs/dxAgMBQYg2MF 4/rTnIUZJDiYlUd5nF9dFCPEl5adUZiQWZ8QXleakFh9ilOHgUJLg3fEPKCdYlJqeWpGWmQMM Spi0BAePkgjvGZA0b3FBYm5xZjpE6hSjLseN4wfeMAmx5OXnpUqJ834AKRIAKcoozYMbAYuQS 4yyUsK8jEBHCfEUpBblZpagyr9iFOdgVBLmvQgyhSczrwRu0yugI5iAjrB0XgtyREkiQkqqgf Fsjezee0eUb8svLL2U2u7j4njoAp+N7OznrxfMfFIzKb9SO2q970nR9U/eMjbeTJgvZhT44Kt C0xGhJ3uNM0q8LudGKZ5+5tGX4rljesHl6CD5P16u2ZqTrvoxvfDQ7pX5WXH3/PlKs5O28ol3 uQ1X7cth6vkr+/X6z6R+1WWz/Rrcl66b0afEUpyRaKjFXFScCABEhbpdiwIAAA== X-Env-Sender: prvs=220f0fe9b=wei.liu2@citrix.com X-Msg-Ref: server-13.tower-206.messagelabs.com!1487863846!70883096!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 14825 invoked from network); 23 Feb 2017 15:30:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-13.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 23 Feb 2017 15:30:47 -0000 X-IronPort-AV: E=Sophos;i="5.35,198,1484006400"; d="scan'208";a="418091189" From: Wei Liu To: Xen-devel Date: Thu, 23 Feb 2017 15:18:20 +0000 Message-ID: <20170223151820.31922-1-wei.liu2@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Cc: Ian Jackson , Paul Durrant , Wei Liu Subject: [Xen-devel] [PATCH] libs/devicemodel: initialise op_bufs in xendevicemodel_xcall X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP To avoid freeing uninitialised buffer when taking the first error exit path. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- Cc: Ian Jackson Cc: Paul Durrant --- tools/libs/devicemodel/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/devicemodel/core.c b/tools/libs/devicemodel/core.c index 504543c1c5..19ebef63b3 100644 --- a/tools/libs/devicemodel/core.c +++ b/tools/libs/devicemodel/core.c @@ -79,7 +79,7 @@ int xendevicemodel_xcall(xendevicemodel_handle *dmod, { int ret = -1; void **xcall_bufs; - xen_dm_op_buf_t *op_bufs; + xen_dm_op_buf_t *op_bufs = NULL; unsigned int i; xcall_bufs = calloc(nr_bufs, sizeof(*xcall_bufs));