diff mbox

xen-access: request compat devicemodel API

Message ID 20170223164645.11752-1-wei.liu2@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Wei Liu Feb. 23, 2017, 4:46 p.m. UTC
xc_hvm_inject_trap is moved to the new libdevicemodel. Request the
compat layer from libxenctrl for now to make it build again.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: Tamas K Lengyel <tamas@tklengyel.com>

This patch is urgent to unblock staging build.

Another way of fixing this is to actually use the new function. I'm not
too fussed about this.
---
 tools/tests/xen-access/Makefile | 1 +
 1 file changed, 1 insertion(+)

Comments

Ian Jackson Feb. 23, 2017, 5 p.m. UTC | #1
Wei Liu writes ("[PATCH] xen-access: request compat devicemodel API"):
> xc_hvm_inject_trap is moved to the new libdevicemodel. Request the
> compat layer from libxenctrl for now to make it build again.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Paul Durrant Feb. 23, 2017, 5 p.m. UTC | #2
> -----Original Message-----

> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of

> Wei Liu

> Sent: 23 February 2017 16:47

> To: Xen-devel <xen-devel@lists.xenproject.org>

> Cc: Ian Jackson <Ian.Jackson@citrix.com>; Tamas K Lengyel

> <tamas@tklengyel.com>; Wei Liu <wei.liu2@citrix.com>; Razvan Cojocaru

> <rcojocaru@bitdefender.com>

> Subject: [Xen-devel] [PATCH] xen-access: request compat devicemodel API

> 

> xc_hvm_inject_trap is moved to the new libdevicemodel. Request the

> compat layer from libxenctrl for now to make it build again.

> 

> Signed-off-by: Wei Liu <wei.liu2@citrix.com>

> ---

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>

> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>

> Cc: Tamas K Lengyel <tamas@tklengyel.com>

> 

> This patch is urgent to unblock staging build.

> 

> Another way of fixing this is to actually use the new function. I'm not

> too fussed about this.


Reviewed-by: Paul Durrant <paul.durrant@citrix.com>


> ---

>  tools/tests/xen-access/Makefile | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-

> access/Makefile

> index 25ff4694c5..e11f639ccf 100644

> --- a/tools/tests/xen-access/Makefile

> +++ b/tools/tests/xen-access/Makefile

> @@ -2,6 +2,7 @@ XEN_ROOT=$(CURDIR)/../../..

>  include $(XEN_ROOT)/tools/Rules.mk

> 

>  CFLAGS += -Werror

> +CFLAGS += -DXC_WANT_COMPAT_DEVICEMODEL_API

> 

>  CFLAGS += $(CFLAGS_libxenctrl)

>  CFLAGS += $(CFLAGS_libxenguest)

> --

> 2.11.0

> 

> 

> _______________________________________________

> Xen-devel mailing list

> Xen-devel@lists.xen.org

> https://lists.xen.org/xen-devel
Razvan Cojocaru Feb. 23, 2017, 5:18 p.m. UTC | #3
On 02/23/2017 06:46 PM, Wei Liu wrote:
> xc_hvm_inject_trap is moved to the new libdevicemodel. Request the
> compat layer from libxenctrl for now to make it build again.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Cc: Tamas K Lengyel <tamas@tklengyel.com>
> 
> This patch is urgent to unblock staging build.
> 
> Another way of fixing this is to actually use the new function. I'm not
> too fussed about this.

No argument from me.

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>


Thanks,
Razvan
Wei Liu Feb. 23, 2017, 5:21 p.m. UTC | #4
On Thu, Feb 23, 2017 at 07:18:17PM +0200, Razvan Cojocaru wrote:
> On 02/23/2017 06:46 PM, Wei Liu wrote:
> > xc_hvm_inject_trap is moved to the new libdevicemodel. Request the
> > compat layer from libxenctrl for now to make it build again.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> > Cc: Tamas K Lengyel <tamas@tklengyel.com>
> > 
> > This patch is urgent to unblock staging build.
> > 
> > Another way of fixing this is to actually use the new function. I'm not
> > too fussed about this.
> 
> No argument from me.
> 
> Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
> 

Pushed.

> 
> Thanks,
> Razvan
>
diff mbox

Patch

diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/Makefile
index 25ff4694c5..e11f639ccf 100644
--- a/tools/tests/xen-access/Makefile
+++ b/tools/tests/xen-access/Makefile
@@ -2,6 +2,7 @@  XEN_ROOT=$(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 CFLAGS += -Werror
+CFLAGS += -DXC_WANT_COMPAT_DEVICEMODEL_API
 
 CFLAGS += $(CFLAGS_libxenctrl)
 CFLAGS += $(CFLAGS_libxenguest)