[04/29] xl: use <> variant to include Xen tools library headers

Commit Message

Wei Liu Feb. 24, 2017, 4:12 p.m. UTC

They should be treated like any other libraries installed on the build
host. Compiler options are set correctly to point to their locations.

Signed-off-by: Wei Liu <[e-mail]>
---
 tools/xl/xl.c          | 6 +++---
 tools/xl/xl.h          | 2 +-
 tools/xl/xl_cmdimpl.c  | 8 ++++----
 tools/xl/xl_cmdtable.c | 2 +-
 tools/xl/xl_sxp.c      | 4 ++--
 5 files changed, 11 insertions(+), 11 deletions(-)

Comments

Ian Jackson Feb. 27, 2017, 3:54 p.m. UTC | #1

Wei Liu writes ("[PATCH 04/29] xl: use <> variant to include Xen tools library headers"):
> They should be treated like any other libraries installed on the build
> host. Compiler options are set correctly to point to their locations.

Acked-by: Ian Jackson <[e-mail]>

Patch

diff --git a/tools/xl/xl.c b/tools/xl/xl.c
index 5eab2c31c4..32346ad7a5 100644
--- a/tools/xl/xl.c
+++ b/tools/xl/xl.c
@@ -24,9 +24,9 @@ 
 #include <inttypes.h>
 #include <regex.h>
 
-#include "libxl.h"
-#include "libxl_utils.h"
-#include "libxlutil.h"
+#include <libxl.h>
+#include <libxl_utils.h>
+#include <libxlutil.h>
 #include "xl.h"
 
 xentoollog_logger_stdiostream *logger;
diff --git a/tools/xl/xl.h b/tools/xl/xl.h
index 84dd2a9265..a8b6264c59 100644
--- a/tools/xl/xl.h
+++ b/tools/xl/xl.h
@@ -18,7 +18,7 @@ 
 #include <assert.h>
 
 #include "_paths.h"
-#include "xentoollog.h"
+#include <xentoollog.h>
 
 struct cmd_spec {
     char *cmd_name;
diff --git a/tools/xl/xl_cmdimpl.c b/tools/xl/xl_cmdimpl.c
index 4dfcbe61ca..9901011008 100644
--- a/tools/xl/xl_cmdimpl.c
+++ b/tools/xl/xl_cmdimpl.c
@@ -34,10 +34,10 @@ 
 #include <limits.h>
 #include <xen/hvm/e820.h>
 
-#include "libxl.h"
-#include "libxl_utils.h"
-#include "libxl_json.h"
-#include "libxlutil.h"
+#include <libxl.h>
+#include <libxl_utils.h>
+#include <libxl_json.h>
+#include <libxlutil.h>
 #include "xl.h"
 
 /* For calls which return an errno on failure */
diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c
index ddcd6c2423..1219b3309d 100644
--- a/tools/xl/xl_cmdtable.c
+++ b/tools/xl/xl_cmdtable.c
@@ -14,7 +14,7 @@ 
 
 #include <string.h>
 
-#include "libxl.h"
+#include <libxl.h>
 #include "xl.h"
 
 struct cmd_spec cmd_table[] = {
diff --git a/tools/xl/xl_sxp.c b/tools/xl/xl_sxp.c
index 9ced6f17be..e738bf2465 100644
--- a/tools/xl/xl_sxp.c
+++ b/tools/xl/xl_sxp.c
@@ -19,8 +19,8 @@ 
 #include <stdlib.h>
 #include <inttypes.h>
 
-#include "libxl.h"
-#include "libxl_utils.h"
+#include <libxl.h>
+#include <libxl_utils.h>
 #include "xl.h"
 
 /* In general you should not add new output to this function since it