From patchwork Mon Feb 27 03:26:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haozhong Zhang X-Patchwork-Id: 9592663 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3EB1460453 for ; Mon, 27 Feb 2017 03:29:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2684027FBB for ; Mon, 27 Feb 2017 03:29:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1ACFF28365; Mon, 27 Feb 2017 03:29:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A488A27FBB for ; Mon, 27 Feb 2017 03:29:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciBxo-0007fD-Dp; Mon, 27 Feb 2017 03:27:04 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ciBxn-0007eU-OK for xen-devel@lists.xen.org; Mon, 27 Feb 2017 03:27:03 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id 6A/40-08534-78C93B85; Mon, 27 Feb 2017 03:27:03 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRWlGSWpSXmKPExsVywNykWLdtzuY Ig/m7NSyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oyOD9tZCpawVbz6t5u1gfEdSxcjF4eQwDRG ideXXjB3MXJySAjwShxZNoMVwvaXWLPkNxtEUS+jxM+tx8GK2AT0JVY8PghWJCIgLXHt82VGE JtZoFpi2spzbCC2sICrxLp3E9hBbBYBVYm25TuBejk4eAVsJR71CULMl5e4cPUUC4jNKWAnse LhQTBbCKhk+8O1LBMYeRcwMqxi1ChOLSpLLdI1MtVLKspMzyjJTczM0TU0MNbLTS0uTkxPzUl MKtZLzs/dxAgMh3oGBsYdjK0n/A4xSnIwKYnyLjLeGCHEl5SfUpmRWJwRX1Sak1p8iFGGg0NJ glcaGF5CgkWp6akVaZk5wMCESUtw8CiJ8C6eDZTmLS5IzC3OTIdInWLU5bhx/MAbJiGWvPy8V Clx3psgRQIgRRmleXAjYFFyiVFWSpiXkYGBQYinILUoN7MEVf4VozgHo5Iw7zqQKTyZeSVwm1 4BHcEEdMRskPt5i0sSEVJSDYzOPsfv1HLy5Ibds/buenz5s8f5b2W/PKrPP3vw2XtVmJO58l8 W+V5Vb+NtyiqhrZckPV5WPfGecTwifBNfmbJDm0vLLYGJge//uAdNe5CVuUri4+Plz9UObfCe oeE5f3d7wvKtKsYr/POPfly27zxDEcd+Th7pqTNFXVqX6iw+ttSnXT3n0GYlluKMREMt5qLiR ABrhZX4jQIAAA== X-Env-Sender: haozhong.zhang@intel.com X-Msg-Ref: server-14.tower-31.messagelabs.com!1488166020!87513304!1 X-Originating-IP: [192.55.52.115] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 48257 invoked from network); 27 Feb 2017 03:27:02 -0000 Received: from mga14.intel.com (HELO mga14.intel.com) (192.55.52.115) by server-14.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 27 Feb 2017 03:27:02 -0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2017 19:26:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,212,1484035200"; d="scan'208";a="938405724" Received: from hz-desktop.sh.intel.com (HELO localhost) ([10.239.159.133]) by orsmga003.jf.intel.com with ESMTP; 26 Feb 2017 19:26:58 -0800 From: Haozhong Zhang To: xen-devel@lists.xen.org Date: Mon, 27 Feb 2017 11:26:49 +0800 Message-Id: <20170227032649.15802-2-haozhong.zhang@intel.com> X-Mailer: git-send-email 2.10.1 In-Reply-To: <20170227032649.15802-1-haozhong.zhang@intel.com> References: <20170227032649.15802-1-haozhong.zhang@intel.com> Cc: Andrew Cooper , Jan Beulich , Haozhong Zhang Subject: [Xen-devel] [PATCH v3 2/2] x86/hvm: check HAP before enabling nested VMX X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The current implementation of nested VMX cannot work without HAP. Signed-off-by: Haozhong Zhang Acked-by: Jan Beulich --- Changes since v2: * Add the check by dropping the cpu_has_svm check. --- xen/arch/x86/hvm/hvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 6621d62..f4666be 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -4123,7 +4123,7 @@ static int hvmop_set_param( * Remove the check below once we have * shadow-on-shadow. */ - if ( cpu_has_svm && !paging_mode_hap(d) && a.value ) + if ( !paging_mode_hap(d) && a.value ) rc = -EINVAL; if ( a.value && d->arch.hvm_domain.params[HVM_PARAM_ALTP2M] )