From patchwork Thu Mar 16 11:48:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 9628007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C07CC60244 for ; Thu, 16 Mar 2017 11:50:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A123B285D4 for ; Thu, 16 Mar 2017 11:50:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 948B0285EF; Thu, 16 Mar 2017 11:50:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1BF36285D4 for ; Thu, 16 Mar 2017 11:50:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coTti-0005OO-3p; Thu, 16 Mar 2017 11:48:50 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1coTtg-0005Nv-QN for xen-devel@lists.xenproject.org; Thu, 16 Mar 2017 11:48:48 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id DD/AA-23854-F9B7AC85; Thu, 16 Mar 2017 11:48:47 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRWlGSWpSXmKPExsXitHSDve786lM RBouvK1h83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBnX/zxmLfjKXzG/9wZrA+Mn7i5GTg4JAX+J r28fMIHYbAI6Ehfn7mTrYuTgEBFQkbi91wAkzCyQJbH5ZDMbiC0s4Cnx9tcGsHIWAVWJ69OOg cV5BSwlDi/YyAoxUk9i15HfYDangJVE75a5LCC2EFDN632XmSBsRYn+eQ+gegUlTs58wgKxS0 Li4IsXzBMYeWchSc1CklrAyLSKUaM4tagstUjX2EAvqSgzPaMkNzEzR9fQwFgvN7W4ODE9NSc xqVgvOT93EyMwdOoZGBh3MHae8DvEKMnBpCTKq2V+KkKILyk/pTIjsTgjvqg0J7X4EKMMB4eS BG9jFVBOsCg1PbUiLTMHGMQwaQkOHiURXkeQNG9xQWJucWY6ROoUoy7HnNm73zAJseTl56VKi fPuAikSACnKKM2DGwGLqEuMslLCvIwMDAxCPAWpRbmZJajyrxjFORiVhCEu4cnMK4Hb9AroCC agI95+OAFyREkiQkqqgdE0prrj7LUPGbab9ghMPhXkbSTzR9709B9ll4bp7xpvB0ypr9tuKSf IZeO3/qJewoHPb7f217y/nR768fX59ZZX5k7j6vjIq3JG5JehydECjhlHLn6dd/239nP7uTcy ZKofbb45oa7atv+CPt/tV28lgxbqr+LY3zvtwSWVid79crOt8pj8ftUosRRnJBpqMRcVJwIAH teT3qMCAAA= X-Env-Sender: prvs=241026746=roger.pau@citrix.com X-Msg-Ref: server-6.tower-31.messagelabs.com!1489664916!64214033!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 30952 invoked from network); 16 Mar 2017 11:48:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 16 Mar 2017 11:48:47 -0000 X-IronPort-AV: E=Sophos;i="5.36,172,1486425600"; d="scan'208";a="422963945" From: Roger Pau Monne To: Date: Thu, 16 Mar 2017 11:48:19 +0000 Message-ID: <20170316114822.27611-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <20170316114822.27611-1-roger.pau@citrix.com> References: <20170316114822.27611-1-roger.pau@citrix.com> MIME-Version: 1.0 Cc: Wei Liu , Ian Jackson , David Scott Subject: [Xen-devel] [PATCH v4 1/4] ocaml/gen: fix ocaml type/code generator from IDL X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Ian Jackson This patch adds support for union members which have their own type name. Signed-off-by: Ian Jackson Reviewed-by: Wei Liu Acked-by: David Scott --- This is no longer a pre-requisite for the PVHv1 removal patch, but it's probably still nice to have it. --- Cc: David Scott Cc: Ian Jackson Cc: Wei Liu --- tools/ocaml/libs/xl/genwrap.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py index 1c8ad81..9a65d73 100644 --- a/tools/ocaml/libs/xl/genwrap.py +++ b/tools/ocaml/libs/xl/genwrap.py @@ -155,7 +155,7 @@ def gen_ocaml_keyedunions(ty, interface, indent, parent = None): u.append("%s" % (f.name.capitalize())) elif isinstance(f.type, idl.Struct): if f.type.rawname is not None: - u.append("%s of %s" % (f.name.capitalize(), f.type.rawname.capitalize())) + u.append("%s of %s.t" % (f.name.capitalize(), f.type.rawname.capitalize())) elif f.type.has_fields(): u.append("%s of %s_%s" % (f.name.capitalize(), nparent, f.name)) else: @@ -325,7 +325,7 @@ def c_val(ty, c, o, indent="", parent = None): s += "\t\t case %d:\n" % (n) s += "\t\t %s = %s;\n" % (parent + ty.keyvar.name, f.enumname) (nparent,fexpr) = ty.member(c, f, False) - s += "%s" % c_val(f.type, fexpr, "Field(%s, 0)" % o, indent=indent+"\t\t ") + s += "%s" % c_val(f.type, fexpr, "Field(%s, 0)" % o, parent=nparent, indent=indent+"\t\t ") s += "break;\n" n += 1 s += "\t\t default: failwith_xl(ERROR_FAIL, \"variant handling bug %s%s (block)\"); break;\n" % (parent, ty.keyvar.name)