| Message ID | 20170317110223.25130-2-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> -----Original Message----- > From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of > Wei Liu > Sent: 17 March 2017 11:02 > To: Xen-devel <xen-devel@lists.xenproject.org> > Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu > <wei.liu2@citrix.com>; Jan Beulich <JBeulich@suse.com>; Roger Pau Monne > <roger.pau@citrix.com> > Subject: [Xen-devel] [PATCH 1/4] docs: update dmop.markdown > > ... to match the code after the removal of PVHv1. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > --- > docs/designs/dmop.markdown | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/designs/dmop.markdown b/docs/designs/dmop.markdown > index a6cf6eb67b..8e9f95af47 100644 > --- a/docs/designs/dmop.markdown > +++ b/docs/designs/dmop.markdown > @@ -128,7 +128,7 @@ static int dm_op(domid_t domid, > if ( rc ) > return rc; > > - if ( !has_hvm_container_domain(d) ) > + if ( !is_hvm_domain(d) ) > goto out; > > rc = xsm_dm_op(XSM_DM_PRIV, d); > -- > 2.11.0 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel
On 17/03/17 11:30, Paul Durrant wrote: >> -----Original Message----- >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of >> Wei Liu >> Sent: 17 March 2017 11:02 >> To: Xen-devel <xen-devel@lists.xenproject.org> >> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu >> <wei.liu2@citrix.com>; Jan Beulich <JBeulich@suse.com>; Roger Pau Monne >> <roger.pau@citrix.com> >> Subject: [Xen-devel] [PATCH 1/4] docs: update dmop.markdown >> >> ... to match the code after the removal of PVHv1. >> >> Signed-off-by: Wei Liu <wei.liu2@citrix.com> > Reviewed-by: Paul Durrant <paul.durrant@citrix.com> As an observation, why do we have C in a design doc like this? ~Andrew
> -----Original Message----- > From: Andrew Cooper > Sent: 17 March 2017 11:33 > To: Paul Durrant <Paul.Durrant@citrix.com>; Wei Liu <wei.liu2@citrix.com>; > Xen-devel <xen-devel@lists.xenproject.org> > Cc: Jan Beulich <JBeulich@suse.com>; Roger Pau Monne > <roger.pau@citrix.com> > Subject: Re: [Xen-devel] [PATCH 1/4] docs: update dmop.markdown > > On 17/03/17 11:30, Paul Durrant wrote: > >> -----Original Message----- > >> From: Xen-devel [mailto:xen-devel-bounces@lists.xen.org] On Behalf Of > >> Wei Liu > >> Sent: 17 March 2017 11:02 > >> To: Xen-devel <xen-devel@lists.xenproject.org> > >> Cc: Andrew Cooper <Andrew.Cooper3@citrix.com>; Wei Liu > >> <wei.liu2@citrix.com>; Jan Beulich <JBeulich@suse.com>; Roger Pau > Monne > >> <roger.pau@citrix.com> > >> Subject: [Xen-devel] [PATCH 1/4] docs: update dmop.markdown > >> > >> ... to match the code after the removal of PVHv1. > >> > >> Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > Reviewed-by: Paul Durrant <paul.durrant@citrix.com> > > As an observation, why do we have C in a design doc like this? > It is there as an illustration of how the hypercall implementation is supposed to function. If you prefer pseudo code then I'd have no objection to a patch to change this. Paul > ~Andrew
diff --git a/docs/designs/dmop.markdown b/docs/designs/dmop.markdown index a6cf6eb67b..8e9f95af47 100644 --- a/docs/designs/dmop.markdown +++ b/docs/designs/dmop.markdown @@ -128,7 +128,7 @@ static int dm_op(domid_t domid, if ( rc ) return rc; - if ( !has_hvm_container_domain(d) ) + if ( !is_hvm_domain(d) ) goto out; rc = xsm_dm_op(XSM_DM_PRIV, d);
... to match the code after the removal of PVHv1. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- docs/designs/dmop.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)