| Message ID | 20170327091059.8452-3-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 27/03/2017 10:10, Wei Liu wrote: > It will be needed later when we split mm.c. > > No functional change. > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> I have a pending patch to take MEM_LOG() out entirely, along with correcting some of the information printed. I'd prefer not to perpetuate its existence. ~Andrew
On Tue, Mar 28, 2017 at 10:14:13PM +0100, Andrew Cooper wrote: > On 27/03/2017 10:10, Wei Liu wrote: > > It will be needed later when we split mm.c. > > > > No functional change. > > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > I have a pending patch to take MEM_LOG() out entirely, along with > correcting some of the information printed. > > I'd prefer not to perpetuate its existence. > Sure. Please send me that patch and I will stick it at the beginning. Wei. > ~Andrew
diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index c0bdc667bf..a1d867bd94 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -127,8 +127,6 @@ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap[L1_PAGETABLE_ENTRIES]; -#define MEM_LOG(_f, _a...) gdprintk(XENLOG_WARNING , _f "\n" , ## _a) - /* * PTE updates can be done with ordinary writes except: * 1. Debug builds get extra checking by using CMPXCHG[8B]. diff --git a/xen/include/asm-x86/mm.h b/xen/include/asm-x86/mm.h index e2baffa9a4..6bc9866359 100644 --- a/xen/include/asm-x86/mm.h +++ b/xen/include/asm-x86/mm.h @@ -606,4 +606,6 @@ void write_32bit_pse_identmap(uint32_t *l2); struct domain *mm_get_pg_owner(domid_t domid); void mm_put_pg_owner(struct domain *pg_owner); +#define MEM_LOG(_f, _a...) gdprintk(XENLOG_WARNING , _f "\n" , ## _a) + #endif /* __ASM_X86_MM_H__ */
It will be needed later when we split mm.c. No functional change. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- xen/arch/x86/mm.c | 2 -- xen/include/asm-x86/mm.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-)