diff mbox

[4/5] x86/physdev: move prototypes of physdev_{map/unmap}_pirq to headers

Message ID 20170327104429.99992-5-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monné March 27, 2017, 10:44 a.m. UTC 
So they can be called outside of the physdev.c file.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/arch/x86/physdev.c    | 4 ----
 xen/include/asm-x86/irq.h | 5 +++++
 2 files changed, 5 insertions(+), 4 deletions(-)

Comments

Jan Beulich April 18, 2017, 12:21 p.m. UTC | #1 
>>> On 27.03.17 at 12:44, <roger.pau@citrix.com> wrote:
> So they can be called outside of the physdev.c file.

But they aren't meant to be, which is the entire reason the
declarations aren't in a header. Hence the rationale needs to be
extended here.

Jan
diff mbox

Patch

diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
index d12086d0ec..4a0a890e55 100644
--- a/xen/arch/x86/physdev.c
+++ b/xen/arch/x86/physdev.c
@@ -18,10 +18,6 @@ 
 #include <xsm/xsm.h>
 #include <asm/p2m.h>
 
-int physdev_map_pirq(domid_t, int type, int *index, int *pirq_p,
-                     struct msi_info *);
-int physdev_unmap_pirq(domid_t, int pirq);
-
 #include "x86_64/mmconfig.h"
 
 #ifndef COMPAT
diff --git a/xen/include/asm-x86/irq.h b/xen/include/asm-x86/irq.h
index ef625ebb13..a0ddd6096a 100644
--- a/xen/include/asm-x86/irq.h
+++ b/xen/include/asm-x86/irq.h
@@ -147,6 +147,11 @@  int map_domain_emuirq_pirq(struct domain *d, int pirq, int irq);
 int unmap_domain_pirq_emuirq(struct domain *d, int pirq);
 bool_t hvm_domain_use_pirq(const struct domain *, const struct pirq *);
 
+struct msi_info;
+int physdev_map_pirq(domid_t, int type, int *index, int *pirq_p,
+                     struct msi_info *);
+int physdev_unmap_pirq(domid_t, int pirq);
+
 /* Reset irq affinities to match the given CPU mask. */
 void fixup_irqs(const cpumask_t *mask, bool_t verbose);
 void fixup_eoi(void);