diff mbox

x86/mmcfg: set pci_mmcfg_config_num to 0 on error path

Message ID 20170421134337.93531-1-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monné April 21, 2017, 1:43 p.m. UTC 
One error path of acpi_parse_mcfg doesn't set pci_mmcfg_config_num to zero, fix
this.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 xen/arch/x86/x86_64/acpi_mmcfg.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Beulich April 21, 2017, 4:07 p.m. UTC | #1 
>>> On 21.04.17 at 15:43, <roger.pau@citrix.com> wrote:
> One error path of acpi_parse_mcfg doesn't set pci_mmcfg_config_num to zero, fix
> this.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>

> --- a/xen/arch/x86/x86_64/acpi_mmcfg.c
> +++ b/xen/arch/x86/x86_64/acpi_mmcfg.c
> @@ -96,6 +96,7 @@ int __init acpi_parse_mcfg(struct acpi_table_header *header)
>      if (!pci_mmcfg_config) {
>          printk(KERN_WARNING PREFIX
>                 "No memory for MCFG config tables\n");
> +        pci_mmcfg_config_num = 0;
>          return -ENOMEM;

This being a boot-time out-of-memory, I don't think this is important
to have in 4.9, so I'll queue it for afterwards.

Jan
diff mbox

Patch

diff --git a/xen/arch/x86/x86_64/acpi_mmcfg.c b/xen/arch/x86/x86_64/acpi_mmcfg.c
index a96d5e00de..650140eec5 100644
--- a/xen/arch/x86/x86_64/acpi_mmcfg.c
+++ b/xen/arch/x86/x86_64/acpi_mmcfg.c
@@ -96,6 +96,7 @@  int __init acpi_parse_mcfg(struct acpi_table_header *header)
     if (!pci_mmcfg_config) {
         printk(KERN_WARNING PREFIX
                "No memory for MCFG config tables\n");
+        pci_mmcfg_config_num = 0;
         return -ENOMEM;
     }