diff mbox

docs: fix iommu_inclusive_mapping documentation

Message ID 20170421143657.94370-1-roger.pau@citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Roger Pau Monne April 21, 2017, 2:36 p.m. UTC
iommu_inclusive_mapping is enabled by default (and has been for a long time).

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
Cc: Tim Deegan <tim@xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 docs/misc/xen-command-line.markdown | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich April 21, 2017, 4:01 p.m. UTC | #1
>>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
>  ### iommu\_inclusive\_mapping (VT-d)
>  > `= <boolean>`
>  
> -> Default: `false`
> +> Default: `true`
>  
>  Use this to work around firmware issues providing correct RMRR entries. Rather

I think we should also take the opportunity and replace "correct" with
"incorrect" above. Easily doable while committing. Any reason you
didn't Cc Julien? A doc change like this should be quite fine for 4.9.

Jan
Roger Pau Monne April 21, 2017, 4:13 p.m. UTC | #2
On Fri, Apr 21, 2017 at 10:01:36AM -0600, Jan Beulich wrote:
> >>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
> > --- a/docs/misc/xen-command-line.markdown
> > +++ b/docs/misc/xen-command-line.markdown
> > @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
> >  ### iommu\_inclusive\_mapping (VT-d)
> >  > `= <boolean>`
> >  
> > -> Default: `false`
> > +> Default: `true`
> >  
> >  Use this to work around firmware issues providing correct RMRR entries. Rather
> 
> I think we should also take the opportunity and replace "correct" with
> "incorrect" above. Easily doable while committing. Any reason you
> didn't Cc Julien? A doc change like this should be quite fine for 4.9.

Yes, please change the correct -> incorrect.

I wasn't really sure if the doc or the code should be changed (I was quite sure
it was the docs) and didn't want to bother Julien with that until we settled on
what to do. I see that you have Cced him now, thanks.

Roger.
Julien Grall April 24, 2017, 11:34 a.m. UTC | #3
Hi Jan,

On 21/04/17 17:01, Jan Beulich wrote:
>>>> On 21.04.17 at 16:36, <roger.pau@citrix.com> wrote:
>> --- a/docs/misc/xen-command-line.markdown
>> +++ b/docs/misc/xen-command-line.markdown
>> @@ -1083,7 +1083,7 @@ wait descriptor timed out', try increasing this value.
>>  ### iommu\_inclusive\_mapping (VT-d)
>>  > `= <boolean>`
>>
>> -> Default: `false`
>> +> Default: `true`
>>
>>  Use this to work around firmware issues providing correct RMRR entries. Rather
>
> I think we should also take the opportunity and replace "correct" with
> "incorrect" above. Easily doable while committing. Any reason you
> didn't Cc Julien? A doc change like this should be quite fine for 4.9.

I am happy to see documentation change applied to staging without a 
release-ack.

Cheers,
diff mbox

Patch

diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
index 450b222734..cab2742b2e 100644
--- a/docs/misc/xen-command-line.markdown
+++ b/docs/misc/xen-command-line.markdown
@@ -1083,7 +1083,7 @@  wait descriptor timed out', try increasing this value.
 ### iommu\_inclusive\_mapping (VT-d)
 > `= <boolean>`
 
-> Default: `false`
+> Default: `true`
 
 Use this to work around firmware issues providing correct RMRR entries. Rather
 than only mapping RAM pages for IOMMU accesses for Dom0, with this option all