From patchwork Mon May 29 09:13:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juergen Gross X-Patchwork-Id: 9752997 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 30801602CC for ; Mon, 29 May 2017 09:16:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26D1826D08 for ; Mon, 29 May 2017 09:16:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A52528446; Mon, 29 May 2017 09:16:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7922F26D08 for ; Mon, 29 May 2017 09:16:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFGkE-00059c-SI; Mon, 29 May 2017 09:13:46 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFGkD-00059V-53 for xen-devel@lists.xenproject.org; Mon, 29 May 2017 09:13:45 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id F8/8D-19409-846EB295; Mon, 29 May 2017 09:13:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRWlGSWpSXmKPExsVyuP0Ov677M+1 Ig4aXxhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bEm1uYCyZyVJzp4GlgfMrWxcjJISFgJPF2 4j+mLkYuDiGBhYwS76bdBEuwCahKbLh+ihXEFhFwlFjdthTMZhZwkJg16yhzFyMHh7BAoMTl0 2kgJgtQ+aktHCAVvALGEu9uLWKCGC8v0XFgMssERs4FjAyrGDWKU4vKUot0jUz1kooy0zNKch Mzc3QNDYz1clOLixPTU3MSk4r1kvNzNzECPVXPwMC4g7H1hN8hRkkOJiVR3nXrtSOF+JLyUyo zEosz4otKc1KLDzHKcHAoSfDueQKUEyxKTU+tSMvMAYYMTFqCg0dJhPffY6A0b3FBYm5xZjpE 6hSjLseG1eu/MAmx5OXnpUqJ874DmSEAUpRRmgc3Aha+lxhlpYR5GRkYGIR4ClKLcjNLUOVfM YpzMCoJ82o+BZrCk5lXArfpFdARTEBH7NoBdkRJIkJKqoExIln7jqBpldFb/fRz7jO9l+2MmX 6f2fI9Z3Y934xZmYVVu8P9FFInztfQ+NQi/Uvh1s+9mwT7fjCeDugOfekwm/lW35lrezUcOfy fnn+yxebiau/whJgzMyu3JM4JmG/9MU560lYH8wtTAlsmS6yf0Gz/Yuks+/37Frq6scVWSU/R 9PjXtK1HiaU4I9FQi7moOBEAOkleDloCAAA= X-Env-Sender: jgross@suse.com X-Msg-Ref: server-11.tower-31.messagelabs.com!1496049223!72073348!1 X-Originating-IP: [195.135.220.15] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10224 invoked from network); 29 May 2017 09:13:43 -0000 Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by server-11.tower-31.messagelabs.com with DHE-RSA-CAMELLIA256-SHA encrypted SMTP; 29 May 2017 09:13:43 -0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 47D6FAC29; Mon, 29 May 2017 09:13:43 +0000 (UTC) From: Juergen Gross To: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org Date: Mon, 29 May 2017 11:13:39 +0200 Message-Id: <20170529091339.1449-1-jgross@suse.com> X-Mailer: git-send-email 2.12.3 Cc: Juergen Gross , boris.ostrovsky@oracle.com Subject: [Xen-devel] [PATCH] xen: don't print error message in case of missing Xenstore entry X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP When registering for the Xenstore watch of the node control/sysrq the handler will be called at once. Don't issue an error message if the Xenstore node isn't there, as it will be created only when an event is being triggered. Signed-off-by: Juergen Gross --- drivers/xen/manage.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c index c1ec8ee80924..7ddd0803da23 100644 --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -277,8 +277,11 @@ static void sysrq_handler(struct xenbus_watch *watch, const char *path, err = xenbus_transaction_start(&xbt); if (err) return; - if (xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key) < 0) { - pr_err("Unable to read sysrq code in control/sysrq\n"); + err = xenbus_scanf(xbt, "control", "sysrq", "%c", &sysrq_key); + if (err < 0) { + if (err != -ENOENT) + pr_err("Error %d reading sysrq code in control/sysrq\n", + err); xenbus_transaction_end(xbt, 1); return; }