| Message ID | 20170601114914.18601-2-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jun 01, 2017 at 12:49:11PM +0100, Roger Pau Monne wrote: > This filed is unused and serves no purpose. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> > Reported by: Jan Beulich <JBeulich@suse.com> Missing dash. Acked-by: Wei Liu <wei.liu2@citrix.com>
>>> On 01.06.17 at 13:49, <roger.pau@citrix.com> wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -559,7 +559,6 @@ typedef enum pt_irq_type_e { > struct xen_domctl_bind_pt_irq { > uint32_t machine_irq; > pt_irq_type_t irq_type; > - uint32_t hvm_domid; > > union { > struct { While there already is a patch pending* which increments the domctl version, you'd need to do it here too, as we can't be sure which one lands first. I can of course pull over the hunk from there and commit it ... With that addition Reviewed-by: Jan Beulich <jbeulich@suse.com> Jan * https://lists.xenproject.org/archives/html/xen-devel/2017-05/msg02817.html
On Thu, Jun 01, 2017 at 07:17:16AM -0600, Jan Beulich wrote: > >>> On 01.06.17 at 13:49, <roger.pau@citrix.com> wrote: > > --- a/xen/include/public/domctl.h > > +++ b/xen/include/public/domctl.h > > @@ -559,7 +559,6 @@ typedef enum pt_irq_type_e { > > struct xen_domctl_bind_pt_irq { > > uint32_t machine_irq; > > pt_irq_type_t irq_type; > > - uint32_t hvm_domid; > > > > union { > > struct { > > While there already is a patch pending* which increments the > domctl version, you'd need to do it here too, as we can't be > sure which one lands first. I can of course pull over the hunk > from there and commit it ... If you don't mind doing it (and there are no further comments) that's fine for me. > With that addition > Reviewed-by: Jan Beulich <jbeulich@suse.com> Thanks Roger
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c index 00909ad470..a447405903 100644 --- a/tools/libxc/xc_domain.c +++ b/tools/libxc/xc_domain.c @@ -1672,7 +1672,6 @@ int xc_domain_update_msi_irq( domctl.domain = (domid_t)domid; bind = &(domctl.u.bind_pt_irq); - bind->hvm_domid = domid; bind->irq_type = PT_IRQ_TYPE_MSI; bind->machine_irq = pirq; bind->u.msi.gvec = gvec; @@ -1699,7 +1698,6 @@ int xc_domain_unbind_msi_irq( domctl.domain = (domid_t)domid; bind = &(domctl.u.bind_pt_irq); - bind->hvm_domid = domid; bind->irq_type = PT_IRQ_TYPE_MSI; bind->machine_irq = pirq; bind->u.msi.gvec = gvec; @@ -1729,7 +1727,6 @@ static int xc_domain_bind_pt_irq_int( domctl.domain = (domid_t)domid; bind = &(domctl.u.bind_pt_irq); - bind->hvm_domid = domid; bind->irq_type = irq_type; bind->machine_irq = machine_irq; switch ( irq_type ) @@ -1788,7 +1785,6 @@ static int xc_domain_unbind_pt_irq_int( domctl.domain = (domid_t)domid; bind = &(domctl.u.bind_pt_irq); - bind->hvm_domid = domid; bind->irq_type = irq_type; bind->machine_irq = machine_irq; switch ( irq_type ) diff --git a/xen/include/public/domctl.h b/xen/include/public/domctl.h index e6cf211fe7..02a33def20 100644 --- a/xen/include/public/domctl.h +++ b/xen/include/public/domctl.h @@ -559,7 +559,6 @@ typedef enum pt_irq_type_e { struct xen_domctl_bind_pt_irq { uint32_t machine_irq; pt_irq_type_t irq_type; - uint32_t hvm_domid; union { struct {
This filed is unused and serves no purpose. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reported by: Jan Beulich <JBeulich@suse.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> Cc: Jan Beulich <JBeulich@suse.com> --- Changes since v3: - New in this version. --- tools/libxc/xc_domain.c | 4 ---- xen/include/public/domctl.h | 1 - 2 files changed, 5 deletions(-)